New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849674 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

The autoplay policy is applied to browser extensions

Reported by cool...@gmail.com, Jun 5 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce the problem:
1. load the page chrome-extension://blablabla/blablabla.html which contains <video>
2. add video via MSE
3. call HTMLVideoElement.play()

What is the expected behavior?
video playback should begin. the autoplay policy should not be applied to browser extensions.

What went wrong?
video playback is not begin. i see the message in Developer tool's console:
Uncaught (in promise) DOMException: play() failed because the user didn't interact with the document first. https://goo.gl/xX8pDD

Did this work before? Yes 66

Does this work in other browsers? Yes

Chrome version: 67.0.3396.62  Channel: beta
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

See also:
https://bugs.chromium.org/p/chromium/issues/detail?id=835767#c11
https://bugs.chromium.org/p/chromium/issues/detail?id=812767#c8
https://news.ycombinator.com/item?id=17009903
 

Comment 1 Deleted

Labels: Needs-Bisect Needs-Triage-M67
Cc: krajshree@chromium.org
Labels: Needs-Feedback
coolcmd@ - Thanks for filing the issue...!!

Could you please provide a sample test file/url to test the issue from TE-end.
This will help us in triaging the issue further.

Thanks...!!

Comment 4 by cool...@gmail.com, Jun 6 2018

krajshree@, steps to reproduce:
1. install this extension: https://chrome.google.com/webstore/detail/alternate-player-for-twit/bhplkbgoehhhddaoolmakpocnenplmhf
2. Press ctrl+shift+J to open console
3. navigate to https://www.twitch.tv/medrybw
4. extension redirect you to chrome-extension://bhplkbgoehhhddaoolmakpocnenplmhf/player.html?channel=medrybw
5. console contains following messages (until click):
Uncaught (in promise) DOMException: play() failed because the user didn't interact with the document first. https://goo.gl/xX8pDD

Project Member

Comment 5 by sheriffbot@chromium.org, Jun 6 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: mlamouri@chromium.org
Components: -Blink>Media Blink>Media>Autoplay
Owner: beccahughes@chromium.org
Extensions shouldn't have the autoplay policy applied to them. beccahughes@, can you PTAL?
Status: Started (was: Unconfirmed)
I can replicate this on 69.0.3452.0. It looks like the flag for extensions is being cleared by mistake on a same document navigation.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0285d9ab24f5537c59f2f1f41cdaa4727c6ace1

commit e0285d9ab24f5537c59f2f1f41cdaa4727c6ace1
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Jun 07 01:42:00 2018

[Autoplay] Do not clear flags on same document navigation

This fixes a bug where AutoplayFlags are cleared on same
document navigations. Flags are associated with a
Document so we should not do this.

BUG= 849674 

Change-Id: I9862b6397ff473f1af3e8bf9ec103cea8842c509
Reviewed-on: https://chromium-review.googlesource.com/1089350
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565139}
[modify] https://crrev.com/e0285d9ab24f5537c59f2f1f41cdaa4727c6ace1/chrome/browser/media/unified_autoplay_browsertest.cc
[modify] https://crrev.com/e0285d9ab24f5537c59f2f1f41cdaa4727c6ace1/content/renderer/render_frame_impl.cc

Labels: -Pri-2 -Needs-Bisect ReleaseBlock-Stable Triaged-ET RegressedIn-67 M-67 Target-67 FoundIn-67 Target-68 Target-69 FoundIn-69 FoundIn-68 OS-Linux OS-Mac Pri-1
Able to reproduce the issue on Windows 10, mac 10.13.3 and Ubuntu 17.10 using chrome reported version #67.0.3396.62 and latest canary #69.0.3451.0.
Removing the Needs-Bisect label as the fix has already landed in comment #9. Adding label RBS as it seems to be a recent regression. Please feel free to remove the same if not required.

Will verify the fix on as per test steps in C#4.

Thanks...!!
Labels: TE-Verified-69.0.3452.0 TE-Verified-M69
Able to reproduce the issue on Mac 10.13.3 using chrome build without fix.

Verified the fix on Mac 10.13.3, Win-10 and Ubuntu 17.10 using Chrome version #69.0.3452.0 as per the comment #4.
Attaching screen cast for reference.
Observed that video playback began and the autoplay policy did not apply to browser extensions.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
849674.webm
8.0 MB View Download
Labels: -ReleaseBlock-Stable Merge-Request-68 ReleaseBlock-Beta
This is not RBS for M67 but we can try and pick this to 68.
Project Member

Comment 13 by sheriffbot@chromium.org, Jun 8 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-68 Merge-Approved-68
Approving merge to 68. BRanch:3440
Status: Fixed (was: Started)
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 8 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ad16ada3ca6e354082496cb019e156bbaddb7c5

commit 1ad16ada3ca6e354082496cb019e156bbaddb7c5
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Jun 08 22:08:15 2018

[Autoplay] Do not clear flags on same document navigation

This fixes a bug where AutoplayFlags are cleared on same
document navigations. Flags are associated with a
Document so we should not do this.

BUG= 849674 

Change-Id: I9862b6397ff473f1af3e8bf9ec103cea8842c509
Reviewed-on: https://chromium-review.googlesource.com/1089350
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#565139}(cherry picked from commit e0285d9ab24f5537c59f2f1f41cdaa4727c6ace1)
Reviewed-on: https://chromium-review.googlesource.com/1093835
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#263}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/1ad16ada3ca6e354082496cb019e156bbaddb7c5/chrome/browser/media/unified_autoplay_browsertest.cc
[modify] https://crrev.com/1ad16ada3ca6e354082496cb019e156bbaddb7c5/content/renderer/render_frame_impl.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 12 2018

Labels: merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7aae4db57ba2ff8b6b12e432e9d4b14535ebec2f

commit 7aae4db57ba2ff8b6b12e432e9d4b14535ebec2f
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Jun 12 20:39:36 2018

[Autoplay] Do not clear flags on same document navigation

This fixes a bug where AutoplayFlags are cleared on same
document navigations. Flags are associated with a
Document so we should not do this.

BUG= 849674 

Change-Id: I9862b6397ff473f1af3e8bf9ec103cea8842c509
Reviewed-on: https://chromium-review.googlesource.com/1089350
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#565139}(cherry picked from commit e0285d9ab24f5537c59f2f1f41cdaa4727c6ace1)
Reviewed-on: https://chromium-review.googlesource.com/1097855
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#772}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/7aae4db57ba2ff8b6b12e432e9d4b14535ebec2f/chrome/browser/media/unified_autoplay_browsertest.cc
[modify] https://crrev.com/7aae4db57ba2ff8b6b12e432e9d4b14535ebec2f/content/renderer/render_frame_impl.cc

Sign in to add a comment