http/tests/devtools/service-workers/service-worker-v8-cache.js has flaky timeouts on debug |
||||||
Issue descriptionhttps://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=webkit_layout_tests&tests=service-worker-v8-cache.js%20 STDERR: [6084:2872:0605/054649.999:FATAL:scoped_refptr.h(219)] Check failed: ptr_. STDERR: Backtrace: STDERR: base::debug::StackTrace::StackTrace [0x6E529AA6+102] STDERR: base::debug::StackTrace::StackTrace [0x6E528B4B+27] STDERR: logging::LogMessage::~LogMessage [0x6E588084+148] STDERR: scoped_refptr<base::SingleThreadTaskRunner>::operator-> [0x5A38315F+175] STDERR: blink::InspectorTaskRunner::PerformSingleTaskDontWait [0x5B887FAF+47] STDERR: ??$Invoke@P8InspectorTaskRunner@blink@@AEXXZABV?$scoped_refptr@VInspectorTaskRunner@blink@@@@$$V@?$FunctorTraits@P8InspectorTaskRunner@blink@@AEXXZX@internal@base@@SAXP8InspectorTaskRunner@blink@@AEXXZABV?$scoped_refptr@VInspectorTaskRunner@blink@@@@@Z [0x5B889DF1+33] STDERR: base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall blink::InspectorTaskRunner::*const &)(void),scoped_refptr<blink::InspectorTaskRunner> const &> [0x5B889D2F+79] STDERR: base::internal::Invoker<base::internal::BindState<void (__thiscall blink::InspectorTaskRunner::*)(void),scoped_refptr<blink::InspectorTaskRunner> >,void __cdecl(void)>::RunImpl<void (__thiscall blink::InspectorTaskRunner::*const &)(void),std::tuple<scoped [0x5B889CDA+74] STDERR: base::internal::Invoker<base::internal::BindState<void (__thiscall blink::InspectorTaskRunner::*)(void),scoped_refptr<blink::InspectorTaskRunner> >,void __cdecl(void)>::Run [0x5B889BDF+63] STDERR: base::RepeatingCallback<void __cdecl(void)>::Run [0x590B4311+81] STDERR: WTF::CrossThreadFunction<void __cdecl(void)>::Run [0x590B42BB+27] STDERR: base::BindOnce<void (__cdecl*)(WTF::CrossThreadFunction<void __cdecl(void)>),WTF::CrossThreadFunction<void __cdecl(void)> > [0x590B373B+187] STDERR: base::internal::FunctorTraits<void (__cdecl*)(WTF::CrossThreadFunction<void __cdecl(void)>),void>::Invoke<void (__cdecl*)(WTF::CrossThreadFunction<void __cdecl(void)>),WTF::CrossThreadFunction<void __cdecl(void)> > [0x590B4A61+97] STDERR: base::internal::InvokeHelper<0,void>::MakeItSo<void (__cdecl*)(WTF::CrossThreadFunction<void __cdecl(void)>),WTF::CrossThreadFunction<void __cdecl(void)> > [0x590B498A+58] STDERR: base::internal::Invoker<base::internal::BindState<void (__cdecl*)(WTF::CrossThreadFunction<void __cdecl(void)>),WTF::CrossThreadFunction<void __cdecl(void)> >,void __cdecl(void)>::RunImpl<void (__cdecl*)(WTF::CrossThreadFunction<void __cdecl(void)>),std:: [0x590B490A+74] STDERR: base::internal::Invoker<base::internal::BindState<void (__cdecl*)(WTF::CrossThreadFunction<void __cdecl(void)>),WTF::CrossThreadFunction<void __cdecl(void)> >,void __cdecl(void)>::RunOnce [0x590B47D4+84] STDERR: base::OnceCallback<void __cdecl(void)>::Run [0x6E4CC720+80] STDERR: base::debug::TaskAnnotator::RunTask [0x6E52E123+1075] STDERR: base::sequence_manager::internal::ThreadControllerImpl::DoWork [0x59264F87+1239] STDERR: base::internal::FunctorTraits<void (__thiscall base::sequence_manager::internal::ThreadControllerImpl::*)(enum base::sequence_manager::internal::ThreadControllerImpl::WorkType),void>::Invoke<void (__thiscall base::sequence_manager::internal::ThreadControl [0x59267D91+81] STDERR: base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall base::sequence_manager::internal::ThreadControllerImpl::*const &)(enum base::sequence_manager::internal::ThreadControllerImpl::WorkType),base::WeakPtr<base::sequence_manager::internal::Thread [0x59267C42+146] STDERR: base::internal::Invoker<base::internal::BindState<void (__thiscall base::sequence_manager::internal::ThreadControllerImpl::*)(enum base::sequence_manager::internal::ThreadControllerImpl::WorkType),base::WeakPtr<base::sequence_manager::internal::ThreadCont [0x59267B9F+111] STDERR: base::internal::Invoker<base::internal::BindState<void (__thiscall base::sequence_manager::internal::ThreadControllerImpl::*)(enum base::sequence_manager::internal::ThreadControllerImpl::WorkType),base::WeakPtr<base::sequence_manager::internal::ThreadCont [0x592679FF+63] STDERR: base::OnceCallback<void __cdecl(void)>::Run [0x6E4CC720+80] STDERR: base::debug::TaskAnnotator::RunTask [0x6E52E123+1075] STDERR: base::internal::IncomingTaskQueue::RunTask [0x6E5B8698+232] STDERR: base::MessageLoop::RunTask [0x6E5C244B+875] STDERR: base::MessageLoop::DeferOrRunPendingTask [0x6E5C2C09+73] STDERR: base::MessageLoop::DoWork [0x6E5C2E8A+442] STDERR: base::MessagePumpDefault::Run [0x6E5CD861+81] STDERR: base::MessageLoop::Run [0x6E5C1D56+486] STDERR: base::RunLoop::Run [0x6E689648+488] STDERR: base::Thread::Run [0x6E750E47+375] STDERR: base::Thread::ThreadMain [0x6E751655+1221] STDERR: base::PlatformThread::GetCurrentThreadPriority [0x6E743ED6+934] STDERR: BaseThreadInitThunk [0x767E336A+18] STDERR: RtlInitializeExceptionChain [0x77109902+99] STDERR: RtlInitializeExceptionChain [0x771098D5+54] STDERR:
,
Jun 5 2018
This also seems to flakily timeout, probably due to issue 789111. But I'm not sure if the timeouts and crashes are due to the same cause.
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffa607a4bcb2d291da13b01547c391904eabd56e commit ffa607a4bcb2d291da13b01547c391904eabd56e Author: Matt Falkenhagen <falken@chromium.org> Date: Wed Jun 06 00:25:32 2018 Gardening: Widen expectation for service-worker-v8-cache.js failures. It's also failing on ASAN which I guess isn't part of [ Debug ]. Bug: 849670 , 789111 Change-Id: I93ceceb4c4c84390dc2253132a29c1cccde722fc NOTRY: true TBR: horo Reviewed-on: https://chromium-review.googlesource.com/1087195 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#564729} [modify] https://crrev.com/ffa607a4bcb2d291da13b01547c391904eabd56e/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0385223775bcb0c8451af0450b8c2d1fed3b07ee commit 0385223775bcb0c8451af0450b8c2d1fed3b07ee Author: Chong Zhang <chongz@chromium.org> Date: Wed Jun 06 18:59:12 2018 Disable http/tests/devtools/service-workers/service-worker-v8-cache.js on Mojo Linux It's failing consistently on the Network Service bot, probably due to DCHECK. Sample Build: https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20Linux/14273 TBR=falken@chromium.org,horo@chromium.org Bug: 849670 , 789111 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3d9da983aa3ba2006a75c27639da8e6fe716875c Reviewed-on: https://chromium-review.googlesource.com/1089356 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#564987} [modify] https://crrev.com/0385223775bcb0c8451af0450b8c2d1fed3b07ee/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Jun 8 2018
The error on NetworkService is text failing, not a timeout or DCHECK failure. This seems to mean there's a diff between NetworkService and non-NS.
So there are three ways this test fails:
- Timeout on non-NetworkService
- DCHECK on Debug
- Text failure on NetworkService
horo: As the test author, any chance you can look at this? We should proritize the text failure on NetworkService as soon it will ship.
--- /b/s/w/ioYmbWbN/layout-test-results/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
+++ /b/s/w/ioYmbWbN/layout-test-results/http/tests/devtools/service-workers/service-worker-v8-cache-actual.txt
@@ -34,11 +34,23 @@
v8.compile Properties:
{
data : {
- cacheConsumeOptions : "code"
- cacheRejected : false
columnNumber : 0
- consumedCacheSize : <number>
lineNumber : 0
+ streamed : <boolean>
+ url : .../devtools/resources/v8-cache-script.js
+ }
+ endTime : <number>
+ startTime : <number>
+ type : "v8.compile"
+}
+Text details for v8.compile: v8-cache-script.js:1
+v8.compile Properties:
+{
+ data : {
+ cacheProduceOptions : "code"
+ columnNumber : 0
+ lineNumber : 0
+ producedCacheSize : <number>
streamed : <boolean>
url : .../devtools/resources/v8-cache-script.js
}
,
Jun 8 2018
,
Jun 8 2018
Actually let me split this bug into NetworkService on and off. The NS failures are deterministic it seems.
,
Jun 19 2018
,
Aug 28
Re c#5: I scanned the flakiness dashboard and found a Text failure on a non-NetworkService bot. https://test-results.appspot.com/data/layout_results/Mac10_13_Tests__dbg_/4905/layout-test-results/results.html I'm not sure if this is blocking servicification. Also, there seems to be another DCHECK failure: https://test-results.appspot.com/data/layout_results/Win7_Tests__dbg__1_/71113/layout-test-results/results.html https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/71113 == failure log == [5524:8988:0825/232850.660:FATAL:script_promise_resolver.h(57)] Check failed: state_ == kDetached || !is_promise_called_ || !GetScriptState()->ContextIsValid() || !GetExecutionContext() || GetExecutionContext()->IsContextDestroyed(). Backtrace: base::debug::StackTrace::StackTrace [0x6F73BDF6+102] base::debug::StackTrace::StackTrace [0x6F73AE9B+27] logging::LogMessage::~LogMessage [0x6F7A1054+148] blink::ScriptPromiseResolver::~ScriptPromiseResolver [0x572A71D8+280] blink::ScriptPromiseResolver::`scalar deleting destructor' [0x572B34A5+37] blink::GarbageCollectedFinalized<blink::ScriptPromiseResolver>::FinalizeGarbageCollectedObject [0x572D543B+43] blink::FinalizerTraitImpl<blink::ScriptPromiseResolver,1>::Finalize [0x572D5405+21] blink::FinalizerTrait<blink::ScriptPromiseResolver>::Finalize [0x572D53C7+23] blink::HeapObjectHeader::Finalize [0x526E0E3B+107] blink::NormalPage::Sweep [0x526E7783+755] blink::BaseArena::SweepUnsweptPage [0x526E1FEF+31] blink::BaseArena::CompleteSweep [0x526E2610+544] blink::ThreadState::EagerSweep [0x526FA41E+446] blink::ThreadState::AtomicPauseEpilogue [0x526F9E6C+668] blink::ThreadState::RunAtomicPause [0x526FF104+548] blink::ThreadState::CollectGarbage [0x526F30CA+954] blink::ThreadState::RunScheduledGC [0x526F96EE+334] blink::ThreadState::SafePoint [0x526FD6ED+205] blink::GCTaskObserver::DidProcessTask [0x5212F0AE+78] blink::scheduler::WebThreadBase::TaskObserverAdapter::DidProcessTask [0x527F9DFA+26] base::sequence_manager::internal::SequenceManagerImpl::NotifyDidProcessTask [0x6F921BEE+1550] base::sequence_manager::internal::SequenceManagerImpl::DidRunTask [0x6F92159B+379] base::sequence_manager::internal::ThreadControllerImpl::DoWork [0x6F95010A+1626] base::internal::FunctorTraits<void (__thiscall base::sequence_manager::internal::ThreadControllerImpl::*)(enum base::sequence_manager::internal::ThreadControllerImpl::WorkType),void>::Invoke<void (__thiscall base::sequence_manager::internal::ThreadControl [0x6F952BF1+81] base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall base::sequence_manager::internal::ThreadControllerImpl::*const &)(enum base::sequence_manager::internal::ThreadControllerImpl::WorkType),base::WeakPtr<base::sequence_manager::internal::Thread [0x6F952AA2+146]
,
Oct 23
FYI, also saw a failure in this test: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/75233 It's already marked Pass/Crash/Timeout, so I'll add Failure.
,
Oct 23
Looks like the failure was related to a specific patch, which was reverted. So never mind.
,
Oct 23
The author of the specific test pointed out that the test was failing before their patch, so I'm disabling it after all. Sorry for the confusion...
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62396dd247b8f5d069706ddfd561148ef2f6d27b commit 62396dd247b8f5d069706ddfd561148ef2f6d27b Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Oct 23 22:05:55 2018 Mark .../service-workers/service-worker-v8-cache.js as failing. TBR=dgozman@chromium.org,chenwilliam@chromium.org Bug: 849670 Change-Id: Ida277f1d6dcfa07502ee3e97227a7fd4a891de38 Reviewed-on: https://chromium-review.googlesource.com/c/1297232 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#602124} [modify] https://crrev.com/62396dd247b8f5d069706ddfd561148ef2f6d27b/third_party/WebKit/LayoutTests/TestExpectations
,
Nov 27
This no longer crashes, but it flakily times out on Window debug.
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2dcfce74b00f2f9a53fead321d7b993a6ee457cf commit 2dcfce74b00f2f9a53fead321d7b993a6ee457cf Author: Matt Falkenhagen <falken@chromium.org> Date: Wed Nov 28 02:25:53 2018 Gardening: service-worker-v8-cache.js only flakily times out. Remove the failing and crashing expectations. It seems to only pass or timeout these days. Also it no longer fails on NetworkService. Bug: 849670 Change-Id: Ie5d67c154e06bcd32d77f32648d31bfebb8466fb Reviewed-on: https://chromium-review.googlesource.com/c/1352081 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#611523} [modify] https://crrev.com/2dcfce74b00f2f9a53fead321d7b993a6ee457cf/third_party/blink/web_tests/FlagExpectations/enable-features=NetworkService [modify] https://crrev.com/2dcfce74b00f2f9a53fead321d7b993a6ee457cf/third_party/blink/web_tests/TestExpectations
,
Dec 4
Is addressed with the test triage. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jun 5 2018