New issue
Advanced search Search tips

Issue 849667 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-20
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Content background color needs adjustment

Project Member Reported by pschaffner@chromium.org, Jun 5 2018

Issue description

Currently the background color of the horizontal section scrollview is different from the background of the parent view (or some other view behind). See attached screenshot.

The two should be the same, and should be what was originally specced by Khalil, which I believe was #222.
 
IMG_0699.PNG
233 KB View Download
 Issue 849668  has been merged into this issue.

Comment 2 by marq@chromium.org, Jun 5 2018

Labels: MS-Tab-Grid Q2
Status: Assigned (was: Untriaged)

Comment 3 by marq@chromium.org, Jun 5 2018

Labels: S-Polish
Owner: edchin@chromium.org
NextAction: 2018-06-20
Status: Started (was: Assigned)
Labels: small
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e41995ed5309353dc619e4a55f13c82870eff47f

commit e41995ed5309353dc619e4a55f13c82870eff47f
Author: edchin <edchin@chromium.org>
Date: Thu Jun 07 16:39:18 2018

[ios] Update tab grid background color

Bug:  849667 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I37bbca1646f3de0534331903b555417ef75fd448
Reviewed-on: https://chromium-review.googlesource.com/1090570
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565293}
[modify] https://crrev.com/e41995ed5309353dc619e4a55f13c82870eff47f/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Comment 7 by edchin@chromium.org, Jun 13 2018

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-06-20

Sign in to add a comment