New issue
Advanced search Search tips

Issue 849664 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in gpu::raster::RasterDecoderImpl::DoTexStorage2D

Project Member Reported by ClusterFuzz, Jun 5 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6695614205919232

Fuzzer: libFuzzer_gpu_raster_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  gpu::raster::RasterDecoderImpl::DoTexStorage2D
  gpu::raster::RasterDecoderImpl::HandleTexStorage2D
  gpu::error::Error gpu::raster::RasterDecoderImpl::DoCommandsImpl<false>
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=559054:559074

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6695614205919232

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 5 2018

Components: Internals>GPU>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 5 2018

Cc: piman@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Jun 5 2018

Labels: Test-Predator-Auto-Owner
Owner: backer@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/a210e801d2389b72e762a446be8651700a71b330 (Cluster fuzz RasterDecoder).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0d16cea8468950f0107b95c09050300bbcd651e

commit e0d16cea8468950f0107b95c09050300bbcd651e
Author: Jonathan Backer <backer@chromium.org>
Date: Tue Jun 05 20:06:01 2018

Check for integer overflow on mult

Fixes an issue that the fuzzer found.

Bug:  849664 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1180b9d0eced6709b1a3245c2f96deca123a71b3
Reviewed-on: https://chromium-review.googlesource.com/1087530
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564628}
[modify] https://crrev.com/e0d16cea8468950f0107b95c09050300bbcd651e/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/e0d16cea8468950f0107b95c09050300bbcd651e/gpu/command_buffer/service/raster_decoder_unittest.cc

Project Member

Comment 5 by ClusterFuzz, Jun 6 2018

ClusterFuzz has detected this issue as fixed in range 564529:564591.

Detailed report: https://clusterfuzz.com/testcase?key=6695614205919232

Fuzzer: libFuzzer_gpu_raster_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  gpu::raster::RasterDecoderImpl::DoTexStorage2D
  gpu::raster::RasterDecoderImpl::HandleTexStorage2D
  gpu::error::Error gpu::raster::RasterDecoderImpl::DoCommandsImpl<false>
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=559054:559074
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=564529:564591

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6695614205919232

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Jun 6 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6695614205919232 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment