Issue metadata
Sign in to add a comment
|
DCHECK failure in x <= INT_MAX in conversions.h |
||||||||||||||||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=6553622855548928 Fuzzer: v8_builtins_generator Job Type: windows_asan_d8_dbg Platform Id: windows Crash Type: DCHECK failure Crash Address: Crash State: x <= INT_MAX in conversions.h v8::platform::PrintStackTrace v8::internal::MakeDay Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=53515:53516 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6553622855548928 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Jun 5 2018
,
Jun 5 2018
,
Jun 5 2018
This is my bad. The first patchset [0] which used DoubleToInteger was correct. I didn't realize `year` and `month` were guarded by range checks above, unlike `data`. I'm uploading a CL to fix it. [0] https://chromium-review.googlesource.com/c/v8/v8/+/1080110/1/src/builtins/builtins-date.cc#83
,
Jun 5 2018
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/eca6c5bbb9586af40a33209dd2aa2ba6b9cde7f8 commit eca6c5bbb9586af40a33209dd2aa2ba6b9cde7f8 Author: jgruber <jgruber@chromium.org> Date: Tue Jun 05 16:15:20 2018 [date] Fix double-to-int conversion in MakeDay `date` could be outside the int32_t range and thus FastD2I may not be used. Bug: chromium:849663 Change-Id: I96a012b40d35ec8f80e449e4e687b0ce7b572d5e Reviewed-on: https://chromium-review.googlesource.com/1087063 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53526} [modify] https://crrev.com/eca6c5bbb9586af40a33209dd2aa2ba6b9cde7f8/src/builtins/builtins-date.cc [add] https://crrev.com/eca6c5bbb9586af40a33209dd2aa2ba6b9cde7f8/test/mjsunit/regress/regress-849663.js
,
Jun 5 2018
,
Jun 6 2018
ClusterFuzz has detected this issue as fixed in range 53525:53526. Detailed report: https://clusterfuzz.com/testcase?key=6553622855548928 Fuzzer: v8_builtins_generator Job Type: windows_asan_d8_dbg Platform Id: windows Crash Type: DCHECK failure Crash Address: Crash State: x <= INT_MAX in conversions.h v8::platform::PrintStackTrace v8::internal::MakeDay Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=53515:53516 Fixed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=53525:53526 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6553622855548928 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Jun 6 2018
ClusterFuzz testcase 6553622855548928 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Jun 6 2018
,
Sep 12
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ClusterFuzz
, Jun 5 2018Labels: Test-Predator-Auto-CC