New issue
Advanced search Search tips

Issue 849663 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in x <= INT_MAX in conversions.h

Project Member Reported by ClusterFuzz, Jun 5 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6553622855548928

Fuzzer: v8_builtins_generator
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  x <= INT_MAX in conversions.h
  v8::platform::PrintStackTrace
  v8::internal::MakeDay
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=53515:53516

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6553622855548928

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 5 2018

Cc: eui-sang.lim@samsung.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

[builtins] Convert double to integer in Date.prototype.setDate by eui-sang.lim@samsung.com - https://chromium.googlesource.com/v8/v8/+/10cfe818bd3e6fff08a4e5d17be11a94021b2d9d

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 5 2018

Labels: Pri-1
Owner: jgruber@chromium.org
Status: Assigned (was: Untriaged)
This is my bad. The first patchset [0] which used DoubleToInteger was correct. I didn't realize `year` and `month` were guarded by range checks above, unlike `data`.

I'm uploading a CL to fix it.

[0] https://chromium-review.googlesource.com/c/v8/v8/+/1080110/1/src/builtins/builtins-date.cc#83
Cc: cbruni@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/eca6c5bbb9586af40a33209dd2aa2ba6b9cde7f8

commit eca6c5bbb9586af40a33209dd2aa2ba6b9cde7f8
Author: jgruber <jgruber@chromium.org>
Date: Tue Jun 05 16:15:20 2018

[date] Fix double-to-int conversion in MakeDay

`date` could be outside the int32_t range and thus FastD2I may not be
used.

Bug:  chromium:849663 
Change-Id: I96a012b40d35ec8f80e449e4e687b0ce7b572d5e
Reviewed-on: https://chromium-review.googlesource.com/1087063
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53526}
[modify] https://crrev.com/eca6c5bbb9586af40a33209dd2aa2ba6b9cde7f8/src/builtins/builtins-date.cc
[add] https://crrev.com/eca6c5bbb9586af40a33209dd2aa2ba6b9cde7f8/test/mjsunit/regress/regress-849663.js

Status: Fixed (was: Assigned)
Project Member

Comment 8 by ClusterFuzz, Jun 6 2018

ClusterFuzz has detected this issue as fixed in range 53525:53526.

Detailed report: https://clusterfuzz.com/testcase?key=6553622855548928

Fuzzer: v8_builtins_generator
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  x <= INT_MAX in conversions.h
  v8::platform::PrintStackTrace
  v8::internal::MakeDay
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=53515:53516
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=53525:53526

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6553622855548928

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jun 6 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6553622855548928 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 6 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 11 by sheriffbot@chromium.org, Sep 12

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment