Issue metadata
Sign in to add a comment
|
Empty-state views need new positioning logic |
||||||||||||||||||||||
Issue descriptionAll empty state views – meaning any collection of labels and/or buttons that appear in any of the tab switcher sections when no tabs are present – should follow these layout rules: - The container view of the empty state subviews should be horizontally centered - All label subviews should have center alignment and be centered horizontally - Button subviews should be horizontally centered - [Compact x Any] (which means there are two toolbars) The container view should be centered vertically in the safe area - [Any x Compact; Regular x Any] (which means one toolbar) The container view should be centered vertically with a constant of -20
,
Jun 5 2018
,
Jun 7 2018
I certainly can see that empty-state logic is broken currently. However, I had thought that the container view was on the bottom next to the new tab button as in the link below. Is this link out of date? https://docs.google.com/presentation/d/1PmopKVCKBfkngGTw7oiIVTEDflnC-cdXW0ZzkahaMVY/edit#slide=id.g2f7914b925_19_0
,
Jun 7 2018
Yeah sorry for not clarifying, Ed. I saw what was proposed and don't like it/think it creates layout logic that is far too complex for what it is (once you factor in all size classes and variant empty-state states). I will update the deck accordingly.
,
Jun 13 2018
,
Jun 20 2018
The NextAction date has arrived: 2018-06-20
,
Jun 22 2018
,
Jun 22 2018
,
Jun 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a063b14577341f530f89ad1756ae64d36336d96b commit a063b14577341f530f89ad1756ae64d36336d96b Author: edchin <edchin@chromium.org> Date: Sat Jun 23 00:42:39 2018 [ios] Update tab grid empty state styling This CL updates the tab grid styling according to the instructions in the bug. Screenshot: https://drive.google.com/open?id=1jgVr-Ma3T7A6VW86TJvIr82xgWwsH130 https://drive.google.com/open?id=1U_gBJM4AmO4YzI-uml2AuKtVHlfsuXSz Bug: 849661 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I349909ce37e31eaca208b9836f86376a49cd2327 Reviewed-on: https://chromium-review.googlesource.com/1112068 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569862} [modify] https://crrev.com/a063b14577341f530f89ad1756ae64d36336d96b/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm [modify] https://crrev.com/a063b14577341f530f89ad1756ae64d36336d96b/ios/chrome/browser/ui/tab_grid/tab_grid_constants.h [modify] https://crrev.com/a063b14577341f530f89ad1756ae64d36336d96b/ios/chrome/browser/ui/tab_grid/tab_grid_constants.mm [modify] https://crrev.com/a063b14577341f530f89ad1756ae64d36336d96b/ios/chrome/browser/ui/tab_grid/tab_grid_empty_state_view.mm [modify] https://crrev.com/a063b14577341f530f89ad1756ae64d36336d96b/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Jun 25 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by marq@chromium.org
, Jun 5 2018Status: Assigned (was: Untriaged)