New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849658 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Autofill] Autocomplete attribute warnings should not fire for unrecognized values

Project Member Reported by ma...@chromium.org, Jun 5 2018

Issue description

We should not have console warnings for unrecognized values of autocomplete. 
 

Comment 2 by ma...@chromium.org, Jun 5 2018

Labels: Merge-Request-68
Status: Fixed (was: Assigned)
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 6 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 11 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 15 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by gov...@chromium.org, Jun 18 2018

Cc: abdulsyed@chromium.org
Pls merge you change to M68 branch 3440 ASAP so we can pick it up for this week Beta release. Merge has to happen latest by 1:00 PM PT tomorrow, Tuesday (06/19), so we can pick it up for Wednesday Beta release.




Project Member

Comment 7 by bugdroid1@chromium.org, Jun 26 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01b993f9fed83f587543e8a8b56e9a3e19b0a433

commit 01b993f9fed83f587543e8a8b56e9a3e19b0a433
Author: Mathieu Perreault <mathp@chromium.org>
Date: Tue Jun 26 16:17:49 2018

[Autofill] Only show autocomplete console warnings if we recognize the type.

TBR=mathp@chromium.org

(cherry picked from commit 7f47dadcb89ffe5da2c1520ccb94f9872b108fde)

Bug:  849658 
Test: FormCacheTest
Change-Id: I5b32002958179b18491269aea874ec462266c0d9
Reviewed-on: https://chromium-review.googlesource.com/1086984
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564615}
Reviewed-on: https://chromium-review.googlesource.com/1115201
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#528}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/01b993f9fed83f587543e8a8b56e9a3e19b0a433/components/autofill/content/renderer/BUILD.gn
[modify] https://crrev.com/01b993f9fed83f587543e8a8b56e9a3e19b0a433/components/autofill/content/renderer/form_cache.cc
[modify] https://crrev.com/01b993f9fed83f587543e8a8b56e9a3e19b0a433/components/autofill/content/renderer/form_cache.h
[add] https://crrev.com/01b993f9fed83f587543e8a8b56e9a3e19b0a433/components/autofill/content/renderer/form_cache_unittest.cc
[modify] https://crrev.com/01b993f9fed83f587543e8a8b56e9a3e19b0a433/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/01b993f9fed83f587543e8a8b56e9a3e19b0a433/components/autofill/core/common/autofill_features.h

Sign in to add a comment