Issue metadata
Sign in to add a comment
|
Blue selection ring intermittently flickers when scrolling |
||||||||||||||||||||||
Issue descriptionThis is hard to repro and seems to correspond to the quickness of the gesture, but I'm lead to believe it has to do with competing gesture recognizers: one which listens for taps that indicate a selection and to open a given tab, and another that listens for scrolling. I believe fixing Issue 849642 will resolve this.
,
Jun 5 2018
,
Jun 13 2018
,
Jun 15 2018
,
Jun 20 2018
The NextAction date has arrived: 2018-06-20
,
Jun 21 2018
,
Jun 27 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59c36319f9c18bbbdde9bb36fb75eb96f7cd2a9e commit 59c36319f9c18bbbdde9bb36fb75eb96f7cd2a9e Author: edchin <edchin@chromium.org> Date: Wed Jun 27 05:37:55 2018 [ios] Fix selection bug in tab grid A single selection collection view's default behavior is to momentarily deselect the selected cell on touch down then select the new cell on touch up. In this tab grid, the selection ring should stay visible on the selected cell on touch down. Multiple selection disables the deselection behavior. Multiple selection will not actually be possible since |-collectionView:shouldSelectItemAtIndexPath:| returns NO. Bug: 849653 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia9913f1ce7edae83398474f94890c5f4c6afab69 Reviewed-on: https://chromium-review.googlesource.com/1115998 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570669} [modify] https://crrev.com/59c36319f9c18bbbdde9bb36fb75eb96f7cd2a9e/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
,
Jul 3
Tested on 69.0.3480.0 Canary, iPhone X iOS 11.4, iPad Air iOS11.4 The blue selection ring does not flicker, but also does not change when we select by long press the tab. Is this WAI? https://drive.google.com/file/d/1YY86sPPOdT-BSZhjJSo1KfpL4BCczfHx/view
,
Jul 5
Yes, I didn't want the ring to jump when selecting a new tab to open as there is already enough animation/change happening on screen.
,
Jul 6
Verified on 69.0.3480.0 Canary, iPhone X iOS 11.4, iPad Air iOS11.4 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by marq@chromium.org
, Jun 5 2018Status: Assigned (was: Untriaged)