Issue metadata
Sign in to add a comment
|
Make segmented control draggable |
||||||||||||||||||||||
Issue descriptionThe ability to drag the content area to change sections leads one to believe the same capability would exist for the segmented control. I don't consider this required for m69.
,
Jun 5 2018
,
Jun 8 2018
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9182d78ce86694ac31b5cc3a8532ee0d556a8e83 commit 9182d78ce86694ac31b5cc3a8532ee0d556a8e83 Author: Mark Cogan <marq@google.com> Date: Tue Jun 12 10:05:30 2018 [iOS] Add drag support to tab grid page control. This CL adds drag support to the tab grid page control using the standard UIControl touch-tracking methods. It updates the behavior of the control to call ValueChanged actions when the control is dragged, and TouchUpInside actions when a new segment is selected. Bug: 849649 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I365c8447f4e6ef215a7558bdab2522867154be38 Reviewed-on: https://chromium-review.googlesource.com/1093470 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566371} [modify] https://crrev.com/9182d78ce86694ac31b5cc3a8532ee0d556a8e83/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.h [modify] https://crrev.com/9182d78ce86694ac31b5cc3a8532ee0d556a8e83/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.mm [modify] https://crrev.com/9182d78ce86694ac31b5cc3a8532ee0d556a8e83/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Jun 12 2018
,
Jun 19 2018
Verified in 69.0.3465.0 Canary, iPhone X iOS 11.4 User is able to drag any tab. Looks good
,
Jun 20 2018
The NextAction date has arrived: 2018-06-20 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by marq@chromium.org
, Jun 5 2018Status: Assigned (was: Untriaged)