New issue
Advanced search Search tips

Issue 849648 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Segmented control regular tab label color needs adjustment

Project Member Reported by pschaffner@chromium.org, Jun 5 2018

Issue description

The label color for the regular tabs section should match the icon's selected state tint color. Right now it appears the label is 100% black, while the icon is a dark grey.
 

Comment 1 by marq@chromium.org, Jun 5 2018

Labels: MS-Tab-Grid Q2
Status: Assigned (was: Untriaged)

Comment 2 by marq@chromium.org, Jun 5 2018

Labels: S-Polish small

Comment 3 by marq@chromium.org, Jun 8 2018

Status: Started (was: Assigned)
New color value will be #3C4043.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/813949bcf24ca197a0a8888ae402bde76a799cb4

commit 813949bcf24ca197a0a8888ae402bde76a799cb4
Author: Mark Cogan <marq@google.com>
Date: Mon Jun 11 15:33:30 2018

[iOS] Match segmented control text color to icon color.

Bug:  849648 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7544bfb35f53a4e0c7bfbc687d3f5a10d2629cd1
Reviewed-on: https://chromium-review.googlesource.com/1093435
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566009}
[modify] https://crrev.com/813949bcf24ca197a0a8888ae402bde76a799cb4/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.mm

Comment 5 by marq@chromium.org, Jun 11 2018

Status: Fixed (was: Started)

Sign in to add a comment