New issue
Advanced search Search tips

Issue 849646 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Background color of segmented control needs adjustment

Project Member Reported by pschaffner@chromium.org, Jun 5 2018

Issue description

Right now it is an opaque grey, which doesn't look good atop a semi-translucent toolbar with content scrolled beneath it.

I would recommend a white value with a very low alpha (e.g. white @ 0.3 alpha).
 
Status: Assigned (was: Untriaged)

Comment 2 by marq@chromium.org, Jun 7 2018

Labels: MS-Tab-Grid Q2 S-Tab-Grid-Polish
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f95184bf7091b20b7ea491d9fbb29ce0f520171

commit 9f95184bf7091b20b7ea491d9fbb29ce0f520171
Author: Mark Cogan <marq@google.com>
Date: Thu Jun 07 23:48:56 2018

[iOS] Tweak tab grid segmented control backgrounds.

This CL makes the background separators for the segmented control
transparent (by making the background view itself transparent). It also
adds an alpha parameter for the background color in anticipation of
making the background itself somewhat transparent.

Bug:  849647 ,  849646 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia17c32297a73de9de2a4903a84829f6c5f4dae75
Reviewed-on: https://chromium-review.googlesource.com/1091536
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565469}
[modify] https://crrev.com/9f95184bf7091b20b7ea491d9fbb29ce0f520171/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.mm

Comment 4 by marq@chromium.org, Jun 26 2018

Martijn, please review the current state of the segmented control separators and background and mark this as Fixed if they look good, or supply details of desired changes and reassign to me.
Owner: marq@chromium.org
The separators look good, but the background color is the same as before. I peaked at your CL, and I would just change kBackgroundColor = 0xFFFFFF and kBackgroundAlpha = 0.3. That should do the trick :)
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d3890ca5a91f12f74021147e45a687a95839632

commit 1d3890ca5a91f12f74021147e45a687a95839632
Author: Mark Cogan <marq@google.com>
Date: Wed Jul 04 17:22:26 2018

[iOS] Tweak tab grid page control background.

Per design recommendation, this CL adjusts the color and alpha of the
tab grid page control.

Bug:  849646 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia2fe6c4709994f8c763e76c1960afe096305b460
Reviewed-on: https://chromium-review.googlesource.com/1122117
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572611}
[modify] https://crrev.com/1d3890ca5a91f12f74021147e45a687a95839632/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.mm

Labels: small
Status: Fixed (was: Started)

Sign in to add a comment