New issue
Advanced search Search tips

Issue 849645 link

Starred by 1 user
Status: Fixed
Owner:
marq@chromium.org
Closed: Jun 2018
Cc:
mard...@chromium.org
marq@chromium.org
pschaffner@chromium.org
martijnb@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-06-20
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Create scaled assets for tab switcher segmented control

Project Member Reported by pschaffner@chromium.org, Jun 5 2018 
The selected state of the icons in the segmented control should be slightly scaled, therefore we need a second set of assets.

Also, both sets of icons should be appropriately hinted for @3x screens (currently it would appear things fall on 0.5pt bounds which is fine for @2x screens, but needs adjusted to integers for @3x).

Comment 1 by mard...@chromium.org, Jun 6 2018

Status: Assigned (was: Untriaged)

Comment 2 by martijnb@chromium.org, Jun 13 2018

Owner: marq@chromium.org
I've updated the assets here:
https://drive.google.com/corp/drive/folders/1aiZNckPquXL1dwiWNmncraDJ1WN6W01N

Note that the unscaled assets are also updated. 

Note that the unscaled segmented control icons are now exported as black and need to be tinted programmatically.

Also note that for the page_controls_regular_tabs_selected, we will also increase the label size from 13pt to 14pt.

Comment 3 by marq@chromium.org, Jun 13 2018

Labels: Q2

Comment 4 by marq@chromium.org, Jun 13 2018

Status: Started (was: Assigned)
Prior to this change the label size for the regular tabs was 20 points when not selected and 23 when selected, so changing from 13 to 14 doesn't make much sense. Please advise if the the 20/23 point sizes should change.

The tints I'm using are:

Selected assets/text : #3C4043
Unselected assets/text : #F8F9FA

Comment 5 by pschaffner@chromium.org, Jun 13 2018 

23 is really big. I thought the metrics for this icon + label would be pretty much the same as the tab switcher button (icon + label) in the toolbar?
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a7691975e99b74c57941f2415a25a4fa88f63a4

commit 1a7691975e99b74c57941f2415a25a4fa88f63a4
Author: Mark Cogan <marq@google.com>
Date: Thu Jun 14 08:48:21 2018

[iOS] Update tab grid control assets.

This CL updates the tab grid selector control assets, and removes the
programatic scaling effect now that the assets are scaled. Tinting is
also now done in code.

Bug:  849645 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I48e9a3e72cad8609ad14a2940733a02140d89005
Reviewed-on: https://chromium-review.googlesource.com/1099070
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567194}
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_incognito_tabs.imageset/page_control_incognito_tabs.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_incognito_tabs.imageset/page_control_incognito_tabs@2x.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_incognito_tabs.imageset/page_control_incognito_tabs@3x.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_incognito_tabs_selected.imageset/page_control_incognito_tabs_selected.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_incognito_tabs_selected.imageset/page_control_incognito_tabs_selected@2x.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_incognito_tabs_selected.imageset/page_control_incognito_tabs_selected@3x.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_regular_tabs.imageset/page_control_regular_tabs.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_regular_tabs.imageset/page_control_regular_tabs@2x.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_regular_tabs.imageset/page_control_regular_tabs@3x.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_regular_tabs_selected.imageset/page_control_regular_tabs_selected.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_regular_tabs_selected.imageset/page_control_regular_tabs_selected@2x.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_regular_tabs_selected.imageset/page_control_regular_tabs_selected@3x.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_remote_tabs.imageset/page_control_remote_tabs.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_remote_tabs.imageset/page_control_remote_tabs@2x.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_remote_tabs.imageset/page_control_remote_tabs@3x.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_remote_tabs_selected.imageset/page_control_remote_tabs_selected.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_remote_tabs_selected.imageset/page_control_remote_tabs_selected@2x.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/resources/page_control_remote_tabs_selected.imageset/page_control_remote_tabs_selected@3x.png
[modify] https://crrev.com/1a7691975e99b74c57941f2415a25a4fa88f63a4/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.mm

Comment 7 by marq@chromium.org, Jun 14 2018

Labels: MS-Tab-Grid S-Tab-Grid-Polish small
NextAction: 2018-06-20
Status: Fixed (was: Started)

Comment 8 by monor...@bugs.chromium.org, Jun 20 2018 

The NextAction date has arrived: 2018-06-20
►

Sign in to add a comment