New issue
Advanced search Search tips

Issue 849642 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Don't reposition selection ring after selecting a tab from the grid

Project Member Reported by pschaffner@chromium.org, Jun 5 2018

Issue description

There is already plenty of things happening animation wise and this just gets lost and causes more noise.
 

Comment 1 by marq@chromium.org, Jun 5 2018

Labels: MS-Tab-Grid Q2
Status: Assigned (was: Untriaged)

Comment 2 by marq@chromium.org, Jun 5 2018

Labels: S-Polish

Comment 3 by marq@chromium.org, Jun 8 2018

Labels: small
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/040c114de8817d1a6f9495e95949f3ee9bf40e66

commit 040c114de8817d1a6f9495e95949f3ee9bf40e66
Author: Mark Cogan <marq@google.com>
Date: Thu Jun 14 08:35:08 2018

[iOS] Don't show selection change when leaving tab grid.

Per the attached bug, this CL changes the tab grid to not show the changed selection state when leaving the tab grid via a tap on a cell.

Cell selection actually happened twice when a cell was tapped; once directly from the collection view, and a second time after the selection had round-tripped through the mediator. This CL cleans that up, and has the collection view decline all selection events, allowing them only to happen as a result of consumer calls.

This CL adds a |showSelectionState| property to the grid view controller; when set to NO, the grid view controller will not update the selection state of the cells when the -selectWithItemID: consumer call is received. The ID of the selected item is maintained, however.

This Cl also doesn't show the selection ring on the proxy cells animated for the transition.

Bug:  849642 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibf8d2c91dc80c42dea55c7e457efe7232d234267
Reviewed-on: https://chromium-review.googlesource.com/1096763
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567192}
[modify] https://crrev.com/040c114de8817d1a6f9495e95949f3ee9bf40e66/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.h
[modify] https://crrev.com/040c114de8817d1a6f9495e95949f3ee9bf40e66/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
[modify] https://crrev.com/040c114de8817d1a6f9495e95949f3ee9bf40e66/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/040c114de8817d1a6f9495e95949f3ee9bf40e66/ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.mm

Comment 5 by marq@chromium.org, Jun 14 2018

Status: Fixed (was: Started)

Sign in to add a comment