New issue
Advanced search Search tips

Issue 849641 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Goma compile fails with MSVC 2017 15.7.2

Project Member Reported by kkinnu...@nvidia.com, Jun 5 2018

Issue description

OS: Win10

What steps will reproduce the problem?
(1) gn gen out/Debug
(2) gn gen --args=is_debug=false out/Release
(3) ninja -C out/Debug && ninja -C out/Release

What is the expected result?

Succeeding compile

What happens instead?

Various failures

 
There are few commits reachable from here:
https://chromium-review.googlesource.com/c/infra/goma/client/+/1086946/1

Feel free to look through them if some of them are such that they could be merged.
I'm unsure who to add as a reviewer, they have cc: goma review address.
I'm now merging the internal changes to the external.
https://chromium-review.googlesource.com/c/infra/goma/client/+/1088332/

Note that we now support only clang-cl.exe build on Win. Probably it can still build with cl.exe, but we mainly use clang-cl.exe
Status: WontFix (was: Untriaged)

Sign in to add a comment