New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 849618 link

Starred by 2 users
Status: Fixed
Owner:
sa...@chromium.org
Closed: Nov 20
Cc:
ajha@chromium.org
fukino@chromium.org
█ brajkumar@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Non-Regression :Tab focus is seen missing on 'Clear Search' (close) icon at search box of Files App

Project Member Reported by mmanchala@chromium.org, Jun 5 2018 
Chrome Version: 68.0.3440.15/10718.13.0 dev-channel  Kip,Daisy and Reks
OS: Chrome

What steps will reproduce the problem?
1.Sign in to user ->Open Files app -> Now click on Search icon
2.Type in search box -> observe 'Clear Search' (close) icon is seen
3.Now press 'Tab' button and observe focus is seen missing on 'Clear Search' (close) icon 
(Please refer Video)

Expected: On pressing tab focus should be seen on 'Clear Search' (close) icon 
Actual: Instead Tab focus is seen missing on 'Clear Search' (close) icon 

This is Non-Regression Issue seen from M-62

@fukino: Please confirm the issue.
Actual_NoTabFpcusOnCloseIcon.webm
948 KB View Download
Expected_TabFocusOnCloseIcon.webm
832 KB View Download
Expected_TabFocusOnCloseIcon.jpg
111 KB View Download

Comment 1 by mmanchala@chromium.org, Jun 5 2018

Summary: Non-Regression :Tab focus is seen missing on 'Clear Search' (close) icon at search box of Files App (was: Non-Regression : Tab focus is seen missing on 'Clear Search' (close) icon at search box of Files App)

Comment 2 by weifangsun@chromium.org, Jun 21 2018

Cc: fukino@chromium.org
Labels: -Pri-2 -M-68 CrOSFilesCategory-UI Pri-3
Owner: ----
Status: Available (was: Assigned)

Comment 3 by weifangsun@chromium.org, Nov 7

Labels: Files-Fixit-2018

Comment 4 by sa...@chromium.org, Nov 20

Owner: sa...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0d7e8b0f4eb51d3c8a4d7146fa55b25572e4cca

commit f0d7e8b0f4eb51d3c8a4d7146fa55b25572e4cca
Author: Sam McNally <sammc@chromium.org>
Date: Tue Nov 20 09:25:29 2018

Set tabindex on the files app search box clear button.

Bug:  849618 
Change-Id: I768ea72228e4fb2c322eeb0e04d00075c677a826
Reviewed-on: https://chromium-review.googlesource.com/c/1343874
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609641}
[modify] https://crrev.com/f0d7e8b0f4eb51d3c8a4d7146fa55b25572e4cca/ui/file_manager/file_manager/main.html

Comment 6 by sa...@chromium.org, Nov 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment