New issue
Advanced search Search tips

Issue 849607 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Task



Sign in to add a comment

Moves ExceptionState into platform/.

Project Member Reported by yukishiino@chromium.org, Jun 5 2018

Issue description

Exception handling (throwing and catching) is one of fundamental things of ECMAScript bindings in Web IDL.  ExceptionState is designed to be a part of bindings interface like ScriptState is.  A typical use case is:

    void webExposedApi(ScriptState*, ExceptionState&);

So, let's move ExceptionState into platform/.  This allows code in platform/ report an error by throwing an exception.

DOMException is defined in Web IDL, however, it's pretty exceptional (maybe only one instance of actual IDL interface definition in Web IDL).  DOMException is implemented with ScriptWrappable and support of generated bindings code, so we don't move DOMException and leave it in core/.

Having said that, an ability to throw an arbitrary exception is pretty important and convenient for ExceptionState, so we allow ExceptionState to throw a DOMException by dependency injection.

Also note that Web IDL defines "perform a security check" that is injected from HTML, and HTML throws a SecurityError that is an instance of DOMException.  So, the definition of DOMException code will be moved to platform/ so that ExceptionState can handle SecurityError specifically.

The final state will be:

    in platform/
    - ExceptionCode
      - V8ErrorType (will be renamed to ESErrorType)
      - DOMException code
    - ExceptionState

    in core/
    - DOMException (ScriptWrappable + generated bindings)

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19b6f8060fb08b2b74eb4fe1723658b80108b906

commit 19b6f8060fb08b2b74eb4fe1723658b80108b906
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Tue Jun 05 09:38:10 2018

v8binding: Moves ExceptionCode into platform/.

As part of effort to move ExceptionState into platform/, this patch
moves ExceptionCode into platform/.

Bug:  849607 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I015f91037dab37c5c3bc83e77ed6e68a2b6251fd
Reviewed-on: https://chromium-review.googlesource.com/1084576
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564422}
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/bindings/core/v8/exception_state.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/bindings/core/v8/exception_state.h
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/bindings/core/v8/v8_throw_dom_exception.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/animation/animation_input_helpers_test.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/animation/effect_input_test.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/css/cssom/css_math_max.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/css/cssom/css_math_min.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/css/cssom/css_math_product.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/css/cssom/css_math_sum.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/css/cssom/css_numeric_value.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/dom/exception_code.h
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/dom/node_iterator_base.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/html/canvas/image_data.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/html/canvas/image_data_test.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/svg/svg_animation_element.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/modules/background_fetch/background_fetch_manager_test.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/modules/bluetooth/bluetooth_uuid.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_api_test.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/modules/credentialmanager/password_credential_test.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/modules/crypto/crypto_result_impl.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/modules/encryptedmedia/content_decryption_module_result_promise.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/modules/payments/payment_request_details_test.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/modules/payments/payment_request_test.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/modules/peerconnection/rtc_error_util.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/modules/webaudio/panner_node.cc
[modify] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/platform/BUILD.gn
[add] https://crrev.com/19b6f8060fb08b2b74eb4fe1723658b80108b906/third_party/blink/renderer/platform/bindings/exception_code.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d032ec2c92941a7613823b181f353b464e340067

commit d032ec2c92941a7613823b181f353b464e340067
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Wed Jun 06 08:34:03 2018

v8binding: Decouples DOMException code from DOMException implementation.

As a preparation to move DOMException's exception code into platform/,
this patch decouples the definition of exception code from the
implementation of DOMException class (especially data table).

Also makes the value of exception code match the legacy error code
of DOMException defined in Web IDL.

Bug:  849607 
Change-Id: I3044c1ebac8ddb344b3c1d380a08482c57225b30
Reviewed-on: https://chromium-review.googlesource.com/1086955
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564823}
[modify] https://crrev.com/d032ec2c92941a7613823b181f353b464e340067/third_party/blink/public/mojom/quota/quota_types.mojom
[modify] https://crrev.com/d032ec2c92941a7613823b181f353b464e340067/third_party/blink/public/platform/modules/indexeddb/web_idb_database_exception.h
[modify] https://crrev.com/d032ec2c92941a7613823b181f353b464e340067/third_party/blink/renderer/core/dom/dom_exception.cc
[modify] https://crrev.com/d032ec2c92941a7613823b181f353b464e340067/third_party/blink/renderer/core/dom/dom_exception.h
[modify] https://crrev.com/d032ec2c92941a7613823b181f353b464e340067/third_party/blink/renderer/core/dom/exception_code.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dc91e9639ed05f3b4bab27a3745269920ab605c

commit 6dc91e9639ed05f3b4bab27a3745269920ab605c
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Thu Jun 07 12:10:07 2018

v8binding: Moves DOMException code into a scope in platform/.

Moves existing DOMException's exception codes in core/ to platform/
enclosing them in a scope named DOMExceptionCode.  For example,

    blink::kSecurityError => blink::DOMExceptionCode::kSecurityError

core/dom/exception_code.h is merged into
platform/bindings/exception_code.h

Mostly there are mechanical changes only, except for the followings
in platform/bindings/exception_code.h .
- kDOMExceptionCodeLegacyCode{Min,Max} are renamed to
  DOMExceptionCode::kLegacyErrorCode{Min,Max}.
- kSecurityError has a new comment.
- ESErrorType's entries' comments are updated.

Bug:  849607 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib639165e403fa44da70ebf80dcd3ec03dedb27e5
Reviewed-on: https://chromium-review.googlesource.com/1088720
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565235}
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/bindings/core/v8/exception_state.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/bindings/core/v8/script_custom_element_definition_builder.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/bindings/core/v8/script_promise_test.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_deserializer.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/bindings/core/v8/v8_html_constructor.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/bindings/core/v8/v8_throw_dom_exception.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/bindings/core/v8/v8_throw_dom_exception.h
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/animation/animation.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/animation/animation_input_helpers_test.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/animation/animation_test.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/animation/effect_input.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/animation/effect_input_test.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/animation/keyframe_effect.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/animation/scroll_timeline.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/clipboard/data_transfer_item_list.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/css_computed_style_declaration.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/css_grouping_rule.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/css_keyframe_rule.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/css_style_sheet.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/cssom/css_math_max.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/cssom/css_math_min.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/cssom/css_math_product.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/cssom/css_math_sum.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/cssom/css_numeric_value.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/font_face.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/font_face_set.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/media_list.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/media_list.h
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/property_registration.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/css/selector_query.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/BUILD.gn
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/accessible_node.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/character_data.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/container_node.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/dataset_dom_string_map.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/dom_exception.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/dom_exception.h
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/dom_token_list.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/events/event_target.cc
[delete] https://crrev.com/fbdd17fbdbafd9979da60c0f898c548109fae0e7/third_party/blink/renderer/core/dom/exception_code.h
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/named_node_map.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/node.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/node_iterator_base.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/range.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/dom/text.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/editing/commands/document_exec_command.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/editing/dom_selection.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/editing/serializers/serialization.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/fetch/body.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/fetch/body_stream_buffer.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/fetch/fetch_manager.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/fileapi/blob.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/fileapi/file.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/fileapi/file_error.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/fileapi/file_reader.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/frame/dom_window.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/frame/dom_window_base64.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/frame/history.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/frame/location.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/geometry/dom_matrix_read_only.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/canvas/image_data.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/canvas/image_data_test.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/canvas/image_element_base.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/custom/custom_element_definition.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/custom/custom_element_registry.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/custom/v0_custom_element_exception.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/forms/html_text_area_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/forms/input_type.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/forms/text_control_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/html_dialog_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/html_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/html_marquee_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/html_table_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/html_table_row_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/html_table_section_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/media/autoplay_policy.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/media/autoplay_policy.h
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/time_ranges.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/track/text_track.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/track/vtt/vtt_cue.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/html/track/vtt/vtt_region.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/imagebitmap/image_bitmap_factories.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/imagebitmap/image_bitmap_source.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/imagebitmap/image_bitmap_source.h
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/inspector/inspector_style_sheet.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/intersection_observer/intersection_observer.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/loader/appcache/application_cache.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/loader/image_loader.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/messaging/message_port.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/mojo/test/mojo_interface_interceptor.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/page/create_window.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/page/scrolling/scroll_state.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/script/script_module_resolver_impl_test.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/svg/properties/svg_list_property_helper.h
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/svg/properties/svg_property_tear_off.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/svg/svg_angle_tear_off.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/svg/svg_animation_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/svg/svg_length_tear_off.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/svg/svg_matrix_tear_off.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/svg/svg_preserve_aspect_ratio_tear_off.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/svg/svg_string_list.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/svg/svg_text_content_element.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/testing/internal_settings.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/testing/origin_trials_test.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/timing/performance.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/timing/performance_user_timing.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/url/dom_url.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/workers/abstract_worker.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/workers/worker_global_scope.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/workers/worklet.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/workers/worklet_pending_tasks.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/xml/xpath_evaluator.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/xml/xpath_expression.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/xml/xpath_parser.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/xml/xpath_result.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.h
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/app_banner/before_install_prompt_event.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/audio_output_devices/html_media_element_audio_output_device.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/audio_output_devices/html_media_element_audio_output_device.h
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/audio_output_devices/set_sink_id_callbacks.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/background_fetch/background_fetch_manager_test.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/background_fetch/background_fetched_event.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/background_sync/sync_manager.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/beacon/navigator_beacon.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/bluetooth/bluetooth.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/bluetooth/bluetooth_error.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_characteristic.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_descriptor.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_server.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_service.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/bluetooth/bluetooth_uuid.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/broadcastchannel/broadcast_channel.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/budget/budget_service.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/cache_storage/cache.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/cache_storage/cache_storage.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/cache_storage/cache_storage_error.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/canvas/canvas2d/canvas_gradient.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/canvas/canvas2d/canvas_path.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/canvas/canvas2d/canvas_pattern.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/canvas/htmlcanvas/html_canvas_element_module.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/canvas/offscreencanvas/offscreen_canvas_module.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/cookie_store/cookie_store.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/credentialmanager/credential.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/credentialmanager/credentials_container.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/credentialmanager/password_credential_test.cc
[modify] https://crrev.com/6dc91e9639ed05f3b4bab27a3745269920ab605c/third_party/blink/renderer/modules/credentialmanager/public_key_credential.cc
[modify] https://crrev.com/6d
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6c233e78e998b1344209a9b1d60218f85da4cce

commit d6c233e78e998b1344209a9b1d60218f85da4cce
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Wed Jun 13 07:59:48 2018

v8binding: Moves ExceptionMessages from core/ to platform/.

As a preparation to move ExceptionState into platform/, moves
ExceptionMessages into platform/.  This should be the last
dependency of ExceptionState to core/.

NOPRESUBMIT=true

Bug:  849607 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3d66e9ee6cce7ff2df138e2ab975b7fad3f733d3
Reviewed-on: https://chromium-review.googlesource.com/1097236
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566754}
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/bindings/bindings.gni
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/bindings/core/v8/custom/v8_window_custom.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/bindings/core/v8/custom/v8_xml_http_request_custom.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/bindings/core/v8/dictionary_helper_for_core.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/bindings/core/v8/exception_state.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/bindings/core/v8/generated_code_helper.h
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/bindings/core/v8/script_promise.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/css/cssom/css_math_invert.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/css/cssom/css_math_max.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/css/cssom/css_math_min.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/css/cssom/css_math_negate.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/css/cssom/css_math_product.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/css/cssom/css_math_sum.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/css/cssom/css_transform_value.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/css/cssom/css_unit_value.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/css/cssom/css_unparsed_value.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/dom/document_test.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/dom/tree_walker.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/editing/dom_selection.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/events/message_event.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/html/forms/html_options_collection.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/html/forms/html_select_element.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/html/forms/input_type.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/html/forms/text_control_element.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/html/html_meter_element.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/html/html_progress_element.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/html/time_ranges.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/html/track/text_track_cue.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/html/track/vtt/vtt_cue.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/html/track/vtt/vtt_region.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/inspector/dev_tools_host.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/svg/properties/svg_list_property_helper.h
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/svg/properties/svg_property_tear_off.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/svg/svg_string_list.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/svg/svg_text_content_element.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/testing/dictionary_test.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/timing/performance_observer.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/url/dom_url.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/core/url/url_search_params.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/filesystem/directory_entry_sync.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/filesystem/entry_sync.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/mediasource/media_source.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/mediasource/source_buffer.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/mediastream/media_stream_track.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/mediastream/user_media_request.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/peerconnection/rtc_dtmf_sender.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/peerconnection/rtc_ice_candidate.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/analyser_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/audio_buffer.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/audio_buffer_source_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/audio_context.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/audio_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/audio_param_timeline.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/audio_scheduled_source_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/audio_worklet_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/base_audio_context.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/biquad_filter_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/channel_merger_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/channel_splitter_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/constant_source_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/default_audio_destination_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/delay_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/dynamics_compressor_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/iir_filter_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/offline_audio_context.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/oscillator_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/panner_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/periodic_wave.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/stereo_panner_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webaudio/wave_shaper_node.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webdatabase/database_manager.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webdatabase/sql_result_set_row_list.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/modules/xr/xr_webgl_layer.cc
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/platform/bindings/DEPS
[rename] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/platform/bindings/exception_messages.cc
[rename] https://crrev.com/d6c233e78e998b1344209a9b1d60218f85da4cce/third_party/blink/renderer/platform/bindings/exception_messages.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c

commit e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Fri Jun 15 13:28:49 2018

v8binding: Moves ExceptionState from core/ into platform/.

ExceptionState is a fundamental utility to throw an exception.
Moving ExceptionState into platform/ enables us to implement
utilities in platform/ that need to throw exceptions.

Bug:  849607 
TBR: jbroman@chromium.org
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic3b3e5ad09e80510049399a70b7d9e5de0b81a9f
Reviewed-on: https://chromium-review.googlesource.com/1100732
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567624}
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/bindings.gni
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/binding_security.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/custom/v8_element_custom.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/custom/v8_message_event_custom.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/custom/v8_promise_rejection_event_custom.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/custom/v8_shadow_root_custom.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/custom/v8_window_custom.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/custom/v8_xml_http_request_custom.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/dictionary.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/dictionary_helper_for_core.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/generated_code_helper.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/iterable.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/native_value_traits_impl_test.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/script_custom_element_definition_builder.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/script_iterator.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/script_module.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/script_promise.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value_test.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value_threaded_test.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer_test.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/v0_custom_element_constructor_builder.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/v8_binding_for_testing.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/v8_gc_controller.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/v8_html_constructor.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/v8_object_parser.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/v8_string_resource.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/v8_throw_dom_exception.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/core/v8/v8_wasm_response_extensions.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/modules/v8/custom/v8_extendable_message_event_custom.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules_test.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/scripts/v8_callback_function.py
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/scripts/v8_callback_interface.py
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/scripts/v8_dictionary.py
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/scripts/v8_interface.py
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/scripts/v8_union.py
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/array_buffer_or_array_buffer_view_or_dictionary.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/boolean_or_element_sequence.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/boolean_or_string_or_unrestricted_double.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/boolean_or_test_callback_interface.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/byte_string_or_node_list.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/byte_string_sequence_sequence_or_byte_string_byte_string_record.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/double_or_double_or_null_sequence.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/double_or_double_sequence.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/double_or_long_or_boolean_sequence.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/double_or_string.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/double_or_string_or_double_or_string_sequence.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/element_sequence_or_byte_string_double_or_string_record.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/float_or_boolean.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/long_or_boolean.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/long_or_test_dictionary.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/long_sequence_or_event.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/nested_union_type.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/node_or_node_list.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/string_or_array_buffer_or_array_buffer_view.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/string_or_double.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/string_or_string_sequence.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_double.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_or_null_sequence.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_sequence.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/test_interface_2_or_uint8_array.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/test_interface_garbage_collected_or_string.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/test_interface_or_long.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/test_interface_or_test_interface_empty.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/unrestricted_double_or_string.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/unsigned_long_long_or_boolean_or_test_callback_interface.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer_view.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_data_view.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_svg_test_interface.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_attributes.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_functions.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_interface.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_constants.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary_derived.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_global.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_primary_global.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_2.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_3.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_check_security.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_conditional_secure_context.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_2.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_3.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_4.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_custom_constructor.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_document.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_empty.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init_constructor.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_target.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_garbage_collected.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor_2.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_node.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_origin_trial_enabled.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_secure_context.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_legacy_callback_interface.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_node.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_permissive_dictionary.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations_not_enumerable.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_typedefs.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_test_variadic_constructor_arguments.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_uint8_clamped_array.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_dictionary_arg.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_enum_arg.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_interface_arg.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_test_interface_sequence_arg.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_typedef.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/core/xml_http_request_or_string.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/modules/boolean_or_string.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/modules/v8_test_inherited_legacy_unenumerable_named_properties.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_2_partial.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_5.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_partial.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/modules/v8_test_not_enumerable_named_getter.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/modules/v8_test_sub_object.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/bindings/tests/results/modules/v8_void_callback_function_modules.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/animation/animation.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/animation/animation_effect.h
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/animation/animation_input_helpers.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/animation/effect_model.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/animation/element_animation.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/animation/keyframe_effect.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/animation/scroll_timeline_test.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/animation/timing_input.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/clipboard/data_transfer_item_list.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/css_computed_style_declaration.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/css_grouping_rule.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/css_keyframe_rule.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/css_style_declaration.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/css_style_sheet.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/css_test_helper.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/cssom/css_keyword_value.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/cssom/css_numeric_value.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/cssom/css_perspective.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/cssom/css_position_value.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/cssom/css_rotate.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/cssom/css_skew.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/cssom/css_skew_x.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/cssom/css_skew_y.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/cssom/css_style_value.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/cssom/css_translate.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/cssom/css_unit_value.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/cssom/css_url_image_value.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/third_party/blink/renderer/core/css/cssom/style_property_map.cc
[modify] https://crrev.com/e51ec048e8a5b676f9ba02a8216bb5eedc7ce87c/t
Status: Fixed (was: Started)

Sign in to add a comment