[ozone/wayland] Crashed on right-clicking on the window decoration bar |
||
Issue descriptionChrome Version: 69.0.3449.0 (Developer Build) OS: Linux What steps will reproduce the problem? (1) Chrome should be compiled with ozone configuration, 'use_ozone = true' and 'ozone_platform_wayland = true'. (2) Launch Chromium with '--ozone-platform=wayland --in-process-gpu' (3) Right Click on window decoration area. What is the expected result? It's supposed to open context menu. What happens instead? Crashed. [21394:21394:0605/164253.766513:FATAL:pref_service.cc(121)] Check failed: false. Trying to read an unregistered pref: browser.custom_chrome_frame #0 0x7f05f4dc06dc base::debug::StackTrace::StackTrace() #1 0x7f05f4d086db logging::LogMessage::~LogMessage() #2 0x7f05f0252d24 PrefService::GetBoolean() #3 0x55ae96db919d SystemMenuModelDelegate::IsCommandIdChecked() #4 0x7f05ef7b926d views::MenuModelAdapter::IsItemChecked() #5 0x7f05ef7b2e52 views::MenuItemView::Init() #6 0x7f05ef7b3f05 views::MenuItemView::AddMenuItemAt() #7 0x7f05ef7b8a3b views::MenuModelAdapter::AddMenuItemFromModelAt() #8 0x7f05ef7b8519 views::MenuModelAdapter::BuildMenuImpl() #9 0x7f05ef7b8440 views::MenuModelAdapter::BuildMenu() #10 0x7f05ef7b8871 views::MenuModelAdapter::CreateMenu() #11 0x7f05ef7ba1d7 views::internal::MenuRunnerImplAdapter::MenuRunnerImplAdapter() #12 0x7f05ef7b979b views::internal::MenuRunnerImplInterface::Create() #13 0x7f05ef7b9568 views::MenuRunner::MenuRunner() #14 0x55ae96d76ada BrowserFrame::ShowContextMenuForView() #15 0x7f05ef831bab views::WindowEventFilter::OnClickedCaption() #16 0x7f05ef8319e8 views::WindowEventFilter::OnMouseEvent()
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac76759cde3d2ca7ce73e10a74e28db5ac64c201 commit ac76759cde3d2ca7ce73e10a74e28db5ac64c201 Author: Maksim Sisov <msisov@igalia.com> Date: Fri Aug 10 08:00:15 2018 [ozone/wayland] Fix crash when right-clicking on the window decoration area. On chrome/x11, right-clicking on the window decoration bar toggles a context menu whose one of the menu items allows switching between builtin and system/native window decorations. Today, chrome/ozone/wayland crashes when building the menu because it tried to read a preference only registered in use_x11: kUseCustomChromeFrame. So this CL does two things: - registers the preference [1] based on PlatformProperties in case of USE_OZONE. - checks whether using system title bar[2] is supported by underlying ozone platform. By default, ozone platforms have this feature disabled. [1] kUseCustomChromeFrame [2] IDC_USE_SYSTEM_TITLE_BAR Based on tonikitoo@igalia.com's patch. Bug: 578890, 849596 Change-Id: Ib05d2057f1193a9e41580d0133e35dff4bc2ea77 Reviewed-on: https://chromium-review.googlesource.com/1167045 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582087} [modify] https://crrev.com/ac76759cde3d2ca7ce73e10a74e28db5ac64c201/chrome/browser/DEPS [modify] https://crrev.com/ac76759cde3d2ca7ce73e10a74e28db5ac64c201/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/ac76759cde3d2ca7ce73e10a74e28db5ac64c201/chrome/browser/ui/browser_command_controller.cc [modify] https://crrev.com/ac76759cde3d2ca7ce73e10a74e28db5ac64c201/chrome/browser/ui/browser_view_prefs.cc [modify] https://crrev.com/ac76759cde3d2ca7ce73e10a74e28db5ac64c201/ui/ozone/platform/wayland/ozone_platform_wayland.cc [modify] https://crrev.com/ac76759cde3d2ca7ce73e10a74e28db5ac64c201/ui/ozone/public/ozone_platform.cc [modify] https://crrev.com/ac76759cde3d2ca7ce73e10a74e28db5ac64c201/ui/ozone/public/ozone_platform.h
,
Aug 10
|
||
►
Sign in to add a comment |
||
Comment 1 by je_julie.kim@chromium.org
, Jun 5 2018