New issue
Advanced search Search tips

Issue 849591 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 796544



Sign in to add a comment

Some ARC browser tests don't configure the identity manager correctly

Project Member Reported by jochen@chromium.org, Jun 5 2018

Issue description

The following tests:

ArcAuthServiceTest.SuccessfulBackgroundFetch
ArcSessionManagerTest.ManagedChromeAccount
ArcSessionManagerTest.WellKnownConsumerAccount
ArcAuthServiceChildAccountTest.ChildAccountFetch
ArcSessionManagerTest.ManagedAndroidAccount
ArcSessionManagerTest.ConsumerAccount

create TestingProfiles with fake oauth2 token services, assuming that no identity manager exists for those profiles.

If one is created, the tests will crash as the identity manager will see the token for the fake account, but wasn't aware of the fake account in the first place.

Those tests should probably be rewritten to use identity_test_utils.h
 
Blocking: 796544
Status: Available (was: Untriaged)
Note: To see these failures in action, change FeedbackUploaderChrome to take in an IdentityManager pointer as illustrated in https://chromium-review.googlesource.com/c/chromium/src/+/1078848/3. That change pushes IdentityManagerFactory::GetForProfile() into the flow of the above-mentioned tests.

Sign in to add a comment