Some ARC browser tests don't configure the identity manager correctly |
|
Issue descriptionThe following tests: ArcAuthServiceTest.SuccessfulBackgroundFetch ArcSessionManagerTest.ManagedChromeAccount ArcSessionManagerTest.WellKnownConsumerAccount ArcAuthServiceChildAccountTest.ChildAccountFetch ArcSessionManagerTest.ManagedAndroidAccount ArcSessionManagerTest.ConsumerAccount create TestingProfiles with fake oauth2 token services, assuming that no identity manager exists for those profiles. If one is created, the tests will crash as the identity manager will see the token for the fake account, but wasn't aware of the fake account in the first place. Those tests should probably be rewritten to use identity_test_utils.h
,
Jun 6 2018
Note: To see these failures in action, change FeedbackUploaderChrome to take in an IdentityManager pointer as illustrated in https://chromium-review.googlesource.com/c/chromium/src/+/1078848/3. That change pushes IdentityManagerFactory::GetForProfile() into the flow of the above-mentioned tests. |
|
►
Sign in to add a comment |
|
Comment 1 by blundell@chromium.org
, Jun 6 2018Status: Available (was: Untriaged)