DevTools: only install bindings into the given execution context |
||
Issue descriptionThere should be a way to only grant binding into isolated world.
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0634da76faf7574eb599a1303e427b820ffa0994 commit 0634da76faf7574eb599a1303e427b820ffa0994 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Mon Jun 11 16:00:48 2018 [DevTools] added Runtime.addBinding test for specific context R=pfeldman@chromium.org Bug: chromium:849552 Change-Id: Ib403617014272d1e9091504049ecb650b4b309af Reviewed-on: https://chromium-review.googlesource.com/1087502 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#566021} [modify] https://crrev.com/0634da76faf7574eb599a1303e427b820ffa0994/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-install-binding-expected.txt [modify] https://crrev.com/0634da76faf7574eb599a1303e427b820ffa0994/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-install-binding.js
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/881b0199d9e91b0b79d5044366ebcfef7135d8c3 commit 881b0199d9e91b0b79d5044366ebcfef7135d8c3 Author: Samuel Huang <huangs@chromium.org> Date: Mon Jun 11 17:48:29 2018 Revert "[DevTools] added Runtime.addBinding test for specific context" This reverts commit 0634da76faf7574eb599a1303e427b820ffa0994. Reason for revert: The test is failing on WebKit Mac10.11 (dbg), with "text diff". Original change's description: > [DevTools] added Runtime.addBinding test for specific context > > R=pfeldman@chromium.org > > Bug: chromium:849552 > Change-Id: Ib403617014272d1e9091504049ecb650b4b309af > Reviewed-on: https://chromium-review.googlesource.com/1087502 > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566021} TBR=pfeldman@chromium.org,kozyatinskiy@chromium.org Change-Id: Idc59c583c06fd1be9aa0e34c7eeb22730e1c7e05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:849552 Reviewed-on: https://chromium-review.googlesource.com/1095685 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#566047} [modify] https://crrev.com/881b0199d9e91b0b79d5044366ebcfef7135d8c3/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-install-binding-expected.txt [modify] https://crrev.com/881b0199d9e91b0b79d5044366ebcfef7135d8c3/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-install-binding.js
,
Aug 21
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 5 2018