Before/after screenshots.

The main differences are:
- New dialog is always on top
- New dialog has no taskbar presence
- Close button is a System Dialog close button rather than a HTML close button

Deleted: M0oNbvpHgUi.png 236 KB

	M0oNbvpHgUi.png 236 KB View Download

Deleted: eADmfb9E8Bz.png 235 KB

	eADmfb9E8Bz.png 235 KB View Download

kuscher - can you have a quick look and / or find a PM to help coordinate this?

I think in the medium term we'll need to give the app control of the behavioral things (launcher icon, always on top), but would be good to check what the desired behavior for this one is.

We should also get UI advice about the close button.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3541993ba86d057da51ddcdd494c070a66a6c3b4

commit 3541993ba86d057da51ddcdd494c070a66a6c3b4
Author: Christopher Lam <calamity@chromium.org>
Date: Wed Jun 06 01:59:23 2018

[first-run] Fix force-first-run-ui flag.

This CL fixes an issue where the First Run Dialog didn't show up with
the switch enabled because the user was not considered new, which skips
the First Run UI.

Bug: 849551
Change-Id: Ibef80187dada0a2b99f932bf8f1256b1bf6034c2
Reviewed-on: https://chromium-review.googlesource.com/1086684
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564767}
[modify] https://crrev.com/3541993ba86d057da51ddcdd494c070a66a6c3b4/chrome/browser/chromeos/login/users/chrome_user_manager.cc
[modify] https://crrev.com/3541993ba86d057da51ddcdd494c070a66a6c3b4/chrome/browser/chromeos/login/users/chrome_user_manager.h

Looks okay to me at a glance - is there a way to try it out myself?

Not yet unfortunately!

I'll have to land everything before it can be played with, but I'm going to take this as a go-ahead for starting to make these changes.

I'll ping you directly once it's ready for a closer look by UI/PMs and we can refine things from there.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6417bc1fce3a1ab4db80e9b9905a8b9e6beaf24

commit d6417bc1fce3a1ab4db80e9b9905a8b9e6beaf24
Author: Christopher Lam <calamity@chromium.org>
Date: Thu Jul 19 07:17:39 2018

[Webview] Refactor AutoResize handling into Webview.

This CL moves WebContents AutoResizing behavior into Webview rather than
handling it in subclasses of Webview. This will enable the addition of
other AutoResizing Webviews without the need for a custom subclass.

Bug: 849551
Change-Id: I2a31a57180ff43b6cda9827ba9d19dcddcd1db24
Reviewed-on: https://chromium-review.googlesource.com/1127216
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576404}
[modify] https://crrev.com/d6417bc1fce3a1ab4db80e9b9905a8b9e6beaf24/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc
[modify] https://crrev.com/d6417bc1fce3a1ab4db80e9b9905a8b9e6beaf24/chrome/browser/ui/views/extensions/extension_view_views.cc
[modify] https://crrev.com/d6417bc1fce3a1ab4db80e9b9905a8b9e6beaf24/ui/views/controls/webview/webview.cc
[modify] https://crrev.com/d6417bc1fce3a1ab4db80e9b9905a8b9e6beaf24/ui/views/controls/webview/webview.h