Chrome dialogs on Chrome OS should have affirmative actions on the right |
|||||||
Issue descriptionChrome Version: 68.0.3431.0 (Official Build) canary (64-bit) OS: Chrome OS What steps will reproduce the problem? (1) Open Chrome browser (2) Invoke a dialog (Add page... Add folder...Create a shortcut...save page as...） (3) Notice that primary actions are on the left What is the expected result? What happens instead? Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jun 19 2018
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Aug 30
,
Sep 18
,
Nov 13
Hi folks. I'm finally getting around to this (sorry it took so long!), but I need some clarification on a few items on this work order... 1. Is this for all Chrome OS dialogs? The slide deck seems to suggest so, but the title is "Chrome dialogs on Chrome OS", repro step (1) is "Open Chrome browser", and no OS is specified in the bug, so I wanted to be sure. So is this change for all dialogs that appear on a Chromebook, both from the browser and from the system? 2. Do we *not* want to implement this change on desktop Chrome (non-Chrome OS)? 3. I can (I believe) make the change easily enough in the dialog template code, which should fix all the dialogs that use it. However, I suspect that not all Chrome / OS dialogs use this template. Do we have a way of auditing all dialogs? Should I just go through the lists in the Harmony tracking bugs (Issue 630357 / browser and Issue 783540 / OS)? 4. The parent bug (Issue 849574) has a couple of metrics listed. Is implementing those metrics part of this work order? Thanks!
,
Nov 13
Hi Greg, 1. Yes it is intended for all Chrome OS dialogs. I have filed these bugs in order to cover all dialogs. I was under the impression that this is how work are separated but feel free to ignore my made-up technicality. We should change all dialogs on Chrome OS. https://bugs.chromium.org/p/chromium/issues/detail?id=844168&desc=3 https://bugs.chromium.org/p/chromium/issues/detail?id=844167&desc=2 https://bugs.chromium.org/p/chromium/issues/detail?id=849549 2. Correct, this should only impact Chrome OS. Chrome on non-Chrome OS should follow native OS convention. 3. I'm not sure. My effort was splitting the coverage into above bugs. 4. I'll let Omri speak to this but I think we should implement those. Part of the hurdle to this change was it will confuse people or impact performance. The metrics can help capture if any negative impact.
,
Nov 13
3. my guess is that harmony is the best approach, +zork@ previously looked into getting a list of all dialogs and might have more info. 4. it would be good to collect the metric to see that we are actually doing better for the users as we think we are.
,
Nov 19
The Harmony list is the right place to start. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by omrilio@chromium.org
, Jun 5 2018