Issue metadata
Sign in to add a comment
|
Not Secure chip animation is stuttery and shows "..." state |
||||||||||||||||||||||||
Issue descriptionAs of M69 with #views-browser-windows and #top-chrome-md flipped, the Not Secure omnibox chip animation is stuttery and shows an intermediate "..." state. See https://docs.google.com/document/d/1WpdSVOC4r97kghn2p66Cgn11X3UoJRQV2HbZRoJRgso/edit?ts=5b0692be#bookmark=id.qezg99a066l9 (internal link).
,
Jun 22 2018
,
Jul 2
,
Jul 10
Sending to ellyjones@ to route to enamel or omnibox.
,
Jul 11
We ameliorated this somewhat on the Views side, but ultimately this:
void LocationBarView::Layout() {
...
location_icon_view_->SetLabel(base::string16());
...
location_icon_view_->SetLabel(GetLocationIconText());
}
causes the entire browser window layout to get re-invalidated upwards, since changing the text of a label invalidates its layout and layout invalidation propagates up. The practical result of this is that laying out the LocationBar guarantees that the entire browser window's layout is dirty afterwards.
We probably need someone (perhaps palmer@, who last touched this) to restructure this logic to not change the label text unless necessary.
,
Jul 11
Sarah, maybe you can take a look at this as part of your Enamel rotation?
,
Jul 12
,
Jul 12
,
Jul 25
Issue 867674 has been merged into this issue.
,
Aug 13
,
Sep 5
,
Sep 6
Reassigning as this is still relevant to Enamel.
,
Oct 1
,
Oct 1
mac triage: over to lgrey@
,
Oct 1
,
Oct 1
Slowed down the animation in Quicktime and it looks pretty reasonable to me on 71.0.3564.0. I don't see any stuttering or "..." |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ellyjo...@chromium.org
, Jun 15 2018Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)