New issue
Advanced search Search tips

Issue 849537 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Not Secure chip animates in from center rather than left

Project Member Reported by est...@chromium.org, Jun 5 2018

Issue description

Max noticed that in M66, the Not Secure chip animates in from the center rather than the left as it's supposed to. You can see this by clicking on "expired" on badssl.com. This regressed sometime since M56 when the chip properly animated in from the left.
 

Comment 1 by est...@chromium.org, Jun 30 2018

Cc: spqc...@chromium.org
Status: Available (was: Untriaged)
Cc: -spqc...@chromium.org
Owner: livvielin@chromium.org
Status: Assigned (was: Available)
Cc: carlosil@chromium.org
I increased the kSlideDurationTimeMs (https://cs.chromium.org/chromium/src/chrome/browser/ui/views/location_bar/location_icon_view.cc?l=200), and at slower speeds you can see that the chip animates in from the left as expected. I haven't actually confirmed whether there is some weird logic that compares slide duration to some other number that actually changes the animation behavior, or whether the animation is just at the speed where it appears to be animating from the center, but it looks like a possible fix is to just increase the animation duration.

carlosil@ landed https://chromium-review.googlesource.com/c/chromium/src/+/1187658, which perhaps changed the animation speed? Carlos, is there a reason you chose 150 ms?
(though I wouldn't say that CL changed the behavior since it came after the regression, but mainly curious about where the number comes from)
Prior to that CL it was using kOpenTimeMS, which is defined to 150 in icon_label_bubble_view.h (https://cs.chromium.org/chromium/src/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h?rcl=29b31dd7fb3edad406e77b963d09b296d6133a12&l=92), so I got the 150 from there, and it shouldn't change the behavior.
Adding a video of the behavior slowed down, which shows chip animating from left. felt@ noticed the divider overlays the text, so it looks like there might be an optical illusion resulting from that behavior when the animation is sped up.

maxwalker@: Any advice on what we should do here? How much of an issue is this UI bug?
Omnibox Not Secure chip UI bug.mov
1.7 MB View Download

Sign in to add a comment