New issue
Advanced search Search tips

Issue 849490 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 906190



Sign in to add a comment

[LayoutNG] Quirks mode tracking bug

Project Member Reported by atotic@chromium.org, Jun 5 2018

Issue description

Make quirks mode work in LayoutNG
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a558107e39ada9bc73bd1227e75d741c4636c7de

commit a558107e39ada9bc73bd1227e75d741c4636c7de
Author: Aleks Totic <atotic@chromium.org>
Date: Tue Jun 05 20:07:11 2018

[LayoutNG] Fix flex BODY in quirks mode

We were not updating margins correctly inside NGBlockNode::RunOldLayout.
Symptom was that BODY(flex) block size was too big when HTML had margins
inside quirks mode.

Another side effect of this fix is two crashes have gone away.

Added explicit test case for BODY(flex) in quirks mode.

Bug: 849490
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Id0ce0910144c81fc254646110424f36c898f9ebd
Reviewed-on: https://chromium-review.googlesource.com/1086381
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564629}
[modify] https://crrev.com/a558107e39ada9bc73bd1227e75d741c4636c7de/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/a558107e39ada9bc73bd1227e75d741c4636c7de/third_party/WebKit/LayoutTests/external/wpt/css/css-flexbox/flexbox_quirks_body.html
[add] https://crrev.com/a558107e39ada9bc73bd1227e75d741c4636c7de/third_party/WebKit/LayoutTests/external/wpt/css/css-flexbox/reference/flexbox_quirks_body-ref.html
[modify] https://crrev.com/a558107e39ada9bc73bd1227e75d741c4636c7de/third_party/blink/renderer/core/layout/ng/ng_block_node.cc

Blockedon: 906190

Sign in to add a comment