Recurrent interstitial: corner radius does not match spec |
|||||||
Issue descriptionCorner radius on the recurrent interstitial UI should be 4dp per specs.
,
Jun 5 2018
Screenshot as of https://chromium-review.googlesource.com/c/chromium/src/+/1086414 attached
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64dc4d950678b4067910beeb89dc420a462d419a commit 64dc4d950678b4067910beeb89dc420a462d419a Author: Emily Stark <estark@google.com> Date: Tue Jun 05 17:19:25 2018 Fix border radius on recurrent interstitial UI Bug: 849487 Change-Id: Id41df3e1c1473a5925667f3b5e8aa214fbb46833 Reviewed-on: https://chromium-review.googlesource.com/1086414 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#564552} [modify] https://crrev.com/64dc4d950678b4067910beeb89dc420a462d419a/components/security_interstitials/core/common/resources/interstitial_common.css
,
Jun 5 2018
,
Jun 6 2018
Requesting a merge for this one-line CSS change; have verified on canary.
,
Jun 6 2018
Approved - branch:3440
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e8359df5319ce1f2b02662d39017eb4c69619df commit 3e8359df5319ce1f2b02662d39017eb4c69619df Author: Emily Stark <estark@google.com> Date: Wed Jun 06 21:11:52 2018 Fix border radius on recurrent interstitial UI Bug: 849487 Change-Id: Id41df3e1c1473a5925667f3b5e8aa214fbb46833 Reviewed-on: https://chromium-review.googlesource.com/1086414 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by: Edward Jung <edwardjung@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#564552}(cherry picked from commit 64dc4d950678b4067910beeb89dc420a462d419a) Reviewed-on: https://chromium-review.googlesource.com/1089810 Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#221} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/3e8359df5319ce1f2b02662d39017eb4c69619df/components/security_interstitials/core/common/resources/interstitial_common.css
,
Jun 7 2018
@Emily Stark : As we are not very sure about the steps to be followed, expected and actual behaviour in order to verify the issue, could you please help us by providing the required info for verifying this from our end. Thanks!
,
Jun 7 2018
++ checked the issue using www.badssl.com in 68.0.3434.0 (...assuming this version without fix) and 68.0.3440.17 (...where issue is fixed) we haven't seen any difference in both versions. Attaching the screen shots of the same. Please help us in verifying the fix. Thanks!
,
Jun 7 2018
Instructions for testing this feature are in https://bugs.chromium.org/p/chromium/issues/detail?id=840575#c5. For this issue, the border corners on the message should be rounded as shown in #2 instead of straight as in https://bugs.chromium.org/p/chromium/issues/detail?id=839969#c3.
,
Jun 7 2018
estark@, Thank you for the update. I've verified the above fix on M68 Beta RC# 68.0.3440.17 for Win, Mac & Linux platforms and it's working as intended. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by est...@chromium.org
, Jun 5 2018