sdy@: Please take a look, or find a suitable owner for this?

Looks like it just failed once, with nothing obviously suspect in the blame list, and the next run passed.

If you check the flakiness dashboard, you see that this test fails quite frequently and should be disabled:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=DownloadShelfControllerTest.AddAndRemoveDownload

Tests seem to only fail on Mac10.13 (not 10.12/10.11), and on Mac ASAN.

Here is the captured log from https://chromium-swarm.appspot.com/task?id=3de5ca204a88ce10&refresh=10&show_raw=1

[ RUN      ] DownloadShelfControllerTest.AddAndRemoveDownload
2018-06-04 15:47:21.996 unit_tests[25438:3319990] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug.
Backtrace from -dealloc:
0   libzombies.dylib                    0x000000014cdf4b7c (anonymous namespace)::ZombieDealloc(objc_object*, objc_selector*) + 588
1   libbase.dylib                       0x000000013452192d base::internal::ScopedNSProtocolTraitsRelease(objc_object*) + 29
2   unit_tests                          0x000000010dd28fe5 base::internal::ScopedNSProtocolTraits<ViewResizerPong*>::Release(ViewResizerPong*) + 21
3   unit_tests                          0x000000010dd290ca base::ScopedTypeRef<ViewResizerPong*, base::internal::ScopedNSProtocolTraits<ViewResizerPong*> >::~ScopedTypeRef() + 42
4   unit_tests                          0x000000010dd29095 base::scoped_nsprotocol<ViewResizerPong*>::~scoped_nsprotocol() + 21
5   unit_tests                          0x000000010dd29075 base::scoped_nsobject<ViewResizerPong>::~scoped_nsobject() + 21
6   unit_tests                          0x000000010dd28c45 base::scoped_nsobject<ViewResizerPong>::~scoped_nsobject() + 21
7   unit_tests                          0x000000010dee8113 (anonymous namespace)::DownloadShelfControllerTest::~DownloadShelfControllerTest() + 51
8   unit_tests                          0x000000010dee9555 (anonymous namespace)::DownloadShelfControllerTest_AddAndRemoveDownload_Test::~DownloadShelfControllerTest_AddAndRemoveDownload_Test() + 21
9   unit_tests                          0x000000010dee8625 (anonymous namespace)::DownloadShelfControllerTest_AddAndRemoveDownload_Test::~DownloadShelfControllerTest_AddAndRemoveDownload_Test() + 21
10  unit_tests                          0x000000010dee8649 (anonymous namespace)::DownloadShelfControllerTest_AddAndRemoveDownload_Test::~DownloadShelfControllerTest_AddAndRemoveDownload_Test() + 25
11  unit_tests                          0x000000010e7c407b testing::Test::DeleteSelf_() + 43
12  unit_tests                          0x000000010e7eedee void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 126
13  unit_tests                          0x000000010e7c2f42 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 114
14  unit_tests                          0x000000010e7c3ed8 testing::TestInfo::Run() + 296
15  unit_tests                          0x000000010e7c525f testing::TestCase::Run() + 239
16  unit_tests                          0x000000010e7d9886 testing::internal::UnitTestImpl::RunAllTests() + 886
17  unit_tests                          0x000000010e7f1e4e bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 126
18  unit_tests                          0x000000010e7d9492 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 114
19  unit_tests                          0x000000010e7d936b testing::UnitTest::Run() + 395
[25438:775:0604/154722.259637:35881249000301:FATAL:objc_zombie.mm(228)] Zombie <ViewResizerPong: 0x7f9893603560> received -resizeView:newHeight:
0   libbase.dylib                       0x000000013485b02e base::debug::StackTrace::StackTrace(unsigned long) + 174
1   libbase.dylib                       0x000000013485b0ed base::debug::StackTrace::StackTrace(unsigned long) + 29
2   libbase.dylib                       0x000000013448373c base::debug::StackTrace::StackTrace() + 28
3   libbase.dylib                       0x00000001345024ac logging::LogMessage::~LogMessage() + 460
4   libbase.dylib                       0x0000000134500215 logging::LogMessage::~LogMessage() + 21
5   libzombies.dylib                    0x000000014cdf3bef (anonymous namespace)::ZombieObjectCrash(objc_object*, objc_selector*, objc_selector*) + 1327
6   libzombies.dylib                    0x000000014cdf36ab -[CrZombie forwardingTargetForSelector:] + 43
7   CoreFoundation                      0x00007fff2fa9ba1c ___forwarding___ + 188
8   CoreFoundation                      0x00007fff2fa9b8d8 _CF_forwarding_prep_0 + 120
9   unit_tests                          0x0000000117793a08 -[AnimatableView setHeight:] + 88
10  unit_tests                          0x0000000117793867 -[HeightAnimation setCurrentProgress:] + 167
11  AppKit                              0x00007fff2d486f10 __55-[NSAnimation(NSInternal) _advanceTimeWithDisplayLink:]_block_invoke + 31
12  AppKit                              0x00007fff2d19d018 NSPerformVisuallyAtomicChange + 146
13  AppKit                              0x00007fff2d22d1a6 -[NSAnimation(NSInternal) _advanceTimeWithDisplayLink:] + 199
14  AppKit                              0x00007fff2d22d04c -[NSScreenDisplayLink _fire] + 298
15  CoreFoundation                      0x00007fff2faa9454 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
16  CoreFoundation                      0x00007fff2faa90d4 __CFRunLoopDoTimer + 1108
17  CoreFoundation                      0x00007fff2faa8bca __CFRunLoopDoTimers + 346
18  CoreFoundation                      0x00007fff2faa039b __CFRunLoopRun + 2427
19  CoreFoundation                      0x00007fff2fa9f787 CFRunLoopRunSpecific + 487
20  HIToolbox                           0x00007fff2edace26 RunCurrentEventLoopInMode + 286
21  HIToolbox                           0x00007fff2edaca9f ReceiveNextEventCommon + 366
22  HIToolbox                           0x00007fff2edac914 _BlockUntilNextEventMatchingListInModeWithFilter + 64
23  AppKit                              0x00007fff2d077f5f _DPSNextEvent + 2085
24  AppKit                              0x00007fff2d80db4c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044
25  unit_tests                          0x0000000112439eaa __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 106
26  libbase.dylib                       0x00000001345079da base::mac::CallWithEHFrame(void () block_pointer) + 10
27  unit_tests                          0x0000000112439d48 -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 248
28  AppKit                              0x00007fff2d06cd6d -[NSApplication run] + 764
29  libbase.dylib                       0x000000013456a3fc base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 348
30  libbase.dylib                       0x0000000134567285 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 101
31  libbase.dylib                       0x000000013455ab2c base::MessageLoop::Run(bool) + 556
32  libbase.dylib                       0x00000001346516fe base::RunLoop::Run() + 606
33  libbase.dylib                       0x00000001346524f2 base::RunLoop::RunUntilIdle() + 210
34  unit_tests                          0x000000010e102500 CocoaProfileTest::~CocoaProfileTest() + 320
35  unit_tests                          0x000000010dee8131 (anonymous namespace)::DownloadShelfControllerTest::~DownloadShelfControllerTest() + 81
36  unit_tests                          0x000000010dee9555 (anonymous namespace)::DownloadShelfControllerTest_AddAndRemoveDownload_Test::~DownloadShelfControllerTest_AddAndRemoveDownload_Test() + 21
37  unit_tests                          0x000000010dee8625 (anonymous namespace)::DownloadShelfControllerTest_AddAndRemoveDownload_Test::~DownloadShelfControllerTest_AddAndRemoveDownload_Test() + 21
38  unit_tests                          0x000000010dee8649 (anonymous namespace)::DownloadShelfControllerTest_AddAndRemoveDownload_Test::~DownloadShelfControllerTest_AddAndRemoveDownload_Test() + 25
39  unit_tests                          0x000000010e7c407b testing::Test::DeleteSelf_() + 43
40  unit_tests                          0x000000010e7eedee void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 126
41  unit_tests                          0x000000010e7c2f42 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 114
42  unit_tests                          0x000000010e7c3ed8 testing::TestInfo::Run() + 296
43  unit_tests                          0x000000010e7c525f testing::TestCase::Run() + 239
44  unit_tests                          0x000000010e7d9886 testing::internal::UnitTestImpl::RunAllTests() + 886
45  unit_tests                          0x000000010e7f1e4e bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 126
46  unit_tests                          0x000000010e7d9492 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 114
47  unit_tests                          0x000000010e7d936b testing::UnitTest::Run() + 395
48  unit_tests                          0x00000001113d2841 RUN_ALL_TESTS() + 17
49  unit_tests                          0x00000001113d1b8b base::TestSuite::Run() + 363
50  unit_tests                          0x00000001116890b0 content::UnitTestTestSuite::Run() + 48
51  unit_tests                          0x000000011139bacd int base::internal::FunctorTraits<int (content::UnitTestTestSuite::*)(), void>::Invoke<int (content::UnitTestTestSuite::*)(), content::UnitTestTestSuite*>(int (content::UnitTestTestSuite::*)(), content::UnitTestTestSuite*&&) + 125
52  unit_tests                          0x000000011139ba14 int base::internal::InvokeHelper<false, int>::MakeItSo<int (content::UnitTestTestSuite::* const&)(), content::UnitTestTestSuite*>(int (content::UnitTestTestSuite::* const&&&)(), content::UnitTestTestSuite*&&) + 68
53  unit_tests                          0x000000011139b9a3 int base::internal::Invoker<base::internal::BindState<int (content::UnitTestTestSuite::*)(), base::internal::UnretainedWrapper<content::UnitTestTestSuite> >, int ()>::RunImpl<int (content::UnitTestTestSuite::* const&)(), std::__1::tuple<base::internal::UnretainedWrapper<content::UnitTestTestSuite> > const&, 0ul>(int (content::UnitTestTestSuite::* const&&&)(), std::__1::tuple<base::internal::UnretainedWrapper<content::UnitTestTestSuite> > const&&&, std::__1::integer_sequence<unsigned long, 0ul>) + 99
54  unit_tests                          0x000000011139b8dc base::internal::Invoker<base::internal::BindState<int (content::UnitTestTestSuite::*)(), base::internal::UnretainedWrapper<content::UnitTestTestSuite> >, int ()>::Run(base::internal::BindStateBase*) + 44
55  unit_tests                          0x000000010f32e84c base::OnceCallback<int ()>::Run() && + 92
56  unit_tests                          0x0000000111414906 base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) + 390
57  unit_tests                          0x0000000111414733 base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) + 179
58  unit_tests                          0x000000011139b6aa main + 378
59  libdyld.dylib                       0x00007fff57459115 start + 1
60  ???                                 0x0000000000000008 0x0 + 8

[7122/9032] DownloadShelfControllerTest.AddAndRemoveDownload (CRASHED)

Further inspection of the flakiness dashboard reveals that also other tests are EXTREMELY flaky.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=DownloadShelfControllerTest

DownloadShelfControllerTest.AutoCloseAfterOpenWithMouseOffShelf passes on first run in ~10% of cases.

CL to disable the tests is in the CQ. As such an owner is assigned, I am taking this out of the sheriff queue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0b6ba68ee13d27129bad15ca711691177f5aab0

commit f0b6ba68ee13d27129bad15ca711691177f5aab0
Author: Dominic Battre <battre@chromium.org>
Date: Tue Jun 05 11:30:28 2018

Disable several flaky DownloadShelfControllerTest tests

This CL disables the last remaning DownloadShelfControllerTest tests as they
are severly flaky.

TBR=sdy@chromium.org,benwells@chromium.org

Bug:  849477 
Change-Id: If7d05d8478096293e7bc164fdb6d96e7f99d8365
Reviewed-on: https://chromium-review.googlesource.com/1086939
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564445}
[modify] https://crrev.com/f0b6ba68ee13d27129bad15ca711691177f5aab0/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

I thought I had checked the Flakiness dash and it showed green? But I see from your links that it is showing some black and grey blobs, which perhaps I misinterpreted as missing runs or something? I've been having a lot of trouble figuring out the Flakiness tool yesterday. Sorry for not spotting the problem sooner!

If you hover over the squares you get the meaning.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcc23e2e982bc8dae707662197b7f058ddae4c66

commit fcc23e2e982bc8dae707662197b7f058ddae4c66
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Fri Aug 17 10:20:05 2018

[Flaky][Mac] Disable flaky DownloadShelfControllerTest test

Disabling AutoCloseAfterOpenWithMouseOffShelf which wasn't for some
reason disabled yet although it's similar flaky as all others.

Latest recorded failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/4744

The flakiness dashboard supports this action:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=unit_tests&tests=DownloadShelfControllerTest.AutoCloseAfterOpenWithMouseOffShelf

TBR=sdy@chromium.org,benwells@chromium.org

Bug:  849477 
Change-Id: Ic793f6f0139c5d56148383caf9ff2890cdfe2420
Reviewed-on: https://chromium-review.googlesource.com/1179674
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584013}
[modify] https://crrev.com/fcc23e2e982bc8dae707662197b7f058ddae4c66/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

This issue only affected the Cocoa UI, which is no longer supported and is being deleted in  issue 832676 .