New issue
Advanced search Search tips

Issue 849476 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 739532



Sign in to add a comment

[Polymer2] Modify PDF viewer to work with polymer2

Project Member Reported by rbpotter@chromium.org, Jun 5 2018

Issue description

PDF viewer generates a number of console errors when Polymer 2 is substituted for Polymer 1. Fix these errors while remaining compatible with Polymer 1.
 
Blocking: 739532
Cc: hnakashima@chromium.org dsinclair@chromium.org
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/134406bd7210dab977ae9d29bf2e0c1cb0a2e467

commit 134406bd7210dab977ae9d29bf2e0c1cb0a2e467
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jun 06 04:13:40 2018

Fix PDF viewer console errors for Polymer2 migration

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I09abc82ecd2ab71850a70c65a9a2decfcc011fe3
Bug:  849476 
Reviewed-on: https://chromium-review.googlesource.com/1086236
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564787}
[modify] https://crrev.com/134406bd7210dab977ae9d29bf2e0c1cb0a2e467/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js
[modify] https://crrev.com/134406bd7210dab977ae9d29bf2e0c1cb0a2e467/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.js
[modify] https://crrev.com/134406bd7210dab977ae9d29bf2e0c1cb0a2e467/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-button.js

Comment 3 by dpa...@chromium.org, Jun 14 2018

FYI, CL to fix PDFExtensionTest.* tests at https://chromium-review.googlesource.com/c/chromium/src/+/1100304.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbeecf950285ac5623c4399da5c517ca393d0922

commit dbeecf950285ac5623c4399da5c517ca393d0922
Author: dpapad <dpapad@chromium.org>
Date: Thu Jun 14 17:01:21 2018

WebUI Polymer 2 migration: Fix PDFViewer tests.

Tests affected:
PDFExtensionTest.Basic
PDFExtensionTest.Bookmark
PDFExtensionTest.Elements
PDFExtensionTest.ToolbarManager

Most of the fixes involve adding Custom Elements to be tested in the document,
otherwise their local DOM is not populated (unlike Polymer 1).

Bug:  849476 
Change-Id: Id953179142174cb5922bf53bcaa139011ea76ca9
Reviewed-on: https://chromium-review.googlesource.com/1100304
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567312}
[modify] https://crrev.com/dbeecf950285ac5623c4399da5c517ca393d0922/chrome/test/data/pdf/basic_test.js
[modify] https://crrev.com/dbeecf950285ac5623c4399da5c517ca393d0922/chrome/test/data/pdf/bookmarks_test.js
[modify] https://crrev.com/dbeecf950285ac5623c4399da5c517ca393d0922/chrome/test/data/pdf/material_elements_test.js
[modify] https://crrev.com/dbeecf950285ac5623c4399da5c517ca393d0922/chrome/test/data/pdf/toolbar_manager_test.js

Status: Fixed (was: Started)

Sign in to add a comment