WebUI: Ensure cr-drawer 'close' event is bubbling in Shadow DOM v1. |
||
Issue descriptionSimilar to issue 848518 . Clients of cr-drawer rely on a bubbling 'close' event, for example see [1]. In Shadow DOM v1, the 'close' event (which originates in the underlying native <dialog>), is no longer bubbling. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/md_extensions/manager.html?l=71,72
,
Jun 4 2018
Candidate fix at https://chromium-review.googlesource.com/c/chromium/src/+/1086267.
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cffc8328447b48bcea183d5c07724408a82748d commit 7cffc8328447b48bcea183d5c07724408a82748d Author: dpapad <dpapad@chromium.org> Date: Tue Jun 05 01:20:19 2018 WebUI Polymer 2: Update cr-drawer to work with Shadow DOM v1. - Ensure 'close' event is bubbling. - Change event target for 'transitionend' to be the underlying <dialog> directly, since 'transitionend' no longer bubbles across shadow roots. Bug: 849465 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I66028eca97595df32637adc94fa48dfdb6510cec Reviewed-on: https://chromium-review.googlesource.com/1086267 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#564328} [modify] https://crrev.com/7cffc8328447b48bcea183d5c07724408a82748d/chrome/test/data/webui/cr_elements/cr_drawer_tests.js [modify] https://crrev.com/7cffc8328447b48bcea183d5c07724408a82748d/ui/webui/resources/cr_elements/cr_drawer/cr_drawer.html [modify] https://crrev.com/7cffc8328447b48bcea183d5c07724408a82748d/ui/webui/resources/cr_elements/cr_drawer/cr_drawer.js
,
Jun 5 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by dpa...@chromium.org
, Jun 4 2018