New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849462 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 845581



Sign in to add a comment

Re-evaluate the Flake data model

Project Member Reported by liaoyuke@chromium.org, Jun 4 2018

Issue description

https://chromium-review.googlesource.com/c/infra/infra/+/1079313/3/appengine/findit/model/flake/detection/flake.py#48

There is a comment:
As discussed, one open question here: do we want to group flake occurrences per platform and with/without patch?

And the reply is:
ACK. Will go with this for now, and will re-evaluate this choice once I have more practice and information.

It's probably a good time to come back and re-evaluate when the bug filing for staging is done.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/712b4e71a9d6072ea9688b4c11fc3e5758120f3a

commit 712b4e71a9d6072ea9688b4c11fc3e5758120f3a
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jun 07 16:25:16 2018

[Findit] Adjust flake detection data models.

This CL makes the following changes to the data models:
1. Move the step_name and test_name to the flake occurrence model, and
   make step_name, test_name, build_id the key of the flake occurrence
   model.
2. Make luci_project, normalized_step_name and normalized_test_name the
   key of the flake model.

The main reason for this change is that it makes it easier to map a
Flake entity to a monorail issue. In the old design, multiple Flake
entities map to one monorail issue, so when decide whether to
create/update bugs, it requires quering mutiple Flake entities and
aggregating the information from all of their children Flake Occurrence
entities, which is expensive and complicate.

In the new design, it's a one-on-one mapping between Flake entity and
monorail issue.

The reason why I didn't go with this approach at first place is that I
thought it's hard to query the ocurrences of a specific pair of
step_name, test_name. After moving step_name and test_name to the
flake occurrence model, it turns out it's easy to do, and it even
allows querying flake occurrences grouping by step_name and test_name.

Bug:  849462 ,  845581 
Change-Id: I91ce0ea3f45a4f23ab073edbe3b90adf5619216c
Reviewed-on: https://chromium-review.googlesource.com/1089115
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/712b4e71a9d6072ea9688b4c11fc3e5758120f3a/appengine/findit/model/flake/detection/test/flake_occurrence_test.py
[modify] https://crrev.com/712b4e71a9d6072ea9688b4c11fc3e5758120f3a/appengine/findit/model/flake/detection/flake.py
[modify] https://crrev.com/712b4e71a9d6072ea9688b4c11fc3e5758120f3a/appengine/findit/model/flake/detection/flake_occurrence.py
[modify] https://crrev.com/712b4e71a9d6072ea9688b4c11fc3e5758120f3a/appengine/findit/model/flake/detection/test/flake_test.py

Status: Fixed (was: Assigned)

Sign in to add a comment