New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849455 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit 15 days ago
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

fizz is failing cheets_ContainerMount

Project Member Reported by lhchavez@chromium.org, Jun 4 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/atrusctl/+/0853cc78d0a39aa6c457c61aecaf9a4bc614cb78

commit 0853cc78d0a39aa6c457c61aecaf9a4bc614cb78
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Wed Jun 06 04:28:44 2018

Use pivot_root(2) instead of chroot(2)

This change calls pivot_root(2) instead of chroot(2) to enter the
container. This prevents the container from accidentally grabbing
references to undesired mounts in the init namespace.

BUG=b:65450844
BUG= chromium:849455 
TEST=fizz tryjob

Change-Id: I6e79016c142e2c773fe13616c0eb1e89082b9cf0
Reviewed-on: https://chromium-review.googlesource.com/1087680
Commit-Ready: Luis Hector Chavez <lhchavez@chromium.org>
Tested-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/0853cc78d0a39aa6c457c61aecaf9a4bc614cb78/init/atrusd.conf

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/cfm-device-monitor/+/66548622ec053e942931ff23132da8b1211eea87

commit 66548622ec053e942931ff23132da8b1211eea87
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Wed Jun 06 04:28:47 2018

Use pivot_root(2) for the service's container

This change restricts the mounts that both mimo-monitor and huddly-monitor are
allowed to inherit to:

* /sys
* /dev
* /proc
* /run/dbus

This prevents the containers from accidentally grabbing references to undesired
mounts in the init namespace.

BUG=b:65450844
BUG= chromium:849455 
TEST=fizz tryjob

Change-Id: Ia60adb321e81157646bd87c2b6d9d930de1c0f60
Reviewed-on: https://chromium-review.googlesource.com/1087356
Commit-Ready: Luis Hector Chavez <lhchavez@chromium.org>
Tested-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/66548622ec053e942931ff23132da8b1211eea87/init/huddly-monitor.conf
[modify] https://crrev.com/66548622ec053e942931ff23132da8b1211eea87/init/mimo-monitor.conf
[modify] https://crrev.com/66548622ec053e942931ff23132da8b1211eea87/mimo-monitor/main.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/95cd066fa8398849cf1d3f8b0f64838ccd7ee978

commit 95cd066fa8398849cf1d3f8b0f64838ccd7ee978
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Wed Jun 06 04:28:37 2018

cecservice: Use pivot_root(2) instead of chroot(2)

This change calls pivot_root(2) instead of chroot(2) to enter the
container. This prevents the container from accidentally grabbing
references to undesired mounts in the init namespace.

BUG=b:65450844
BUG= chromium:849455 
TEST=fizz tryjob

Change-Id: I3090d8bf665369022e0b38707ac49582a1ab174c
Reviewed-on: https://chromium-review.googlesource.com/1087708
Commit-Ready: Luis Hector Chavez <lhchavez@chromium.org>
Tested-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/95cd066fa8398849cf1d3f8b0f64838ccd7ee978/cecservice/share/cecservice.conf

Owner: lhchavez@chromium.org
Status: Fixed (was: Assigned)
I believe all the pending work has been done.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1541d0248bb3f7a8a2d247c608d1ad24840a567d

commit 1541d0248bb3f7a8a2d247c608d1ad24840a567d
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Fri Jun 08 06:33:36 2018

cecservice: Clean up the minijail0 invocation

This change uses /var/empty as the chroot to match the way we invoke the
rest of the services. It also stops creating/deleting the chroot
directory.

BUG=b:65450844
BUG= chromium:849455 
TEST=fizz tryjob

Change-Id: I243e4e4ae6392f0ae257249a401518362097b60a
Reviewed-on: https://chromium-review.googlesource.com/1087709
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Felix Ekblom <felixe@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/1541d0248bb3f7a8a2d247c608d1ad24840a567d/cecservice/share/cecservice.conf

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/atrusctl/+/f2f9d8df9f307aea2f0c269c81ab7f104b8a4a20

commit f2f9d8df9f307aea2f0c269c81ab7f104b8a4a20
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Thu Jul 12 18:35:40 2018

Clean up the minijail0 invocation

This change uses /var/empty as the chroot to match the way we invoke the
rest of the services. It also stops creating/deleting the chroot
directory.

BUG=b:65450844
BUG= chromium:849455 
BUG= chromium:861994 
TEST=fizz tryjob

Change-Id: I6a76cc92d93bdb8f7edf2990cb0cf219ac20f4ff
Reviewed-on: https://chromium-review.googlesource.com/1087681
Commit-Ready: Luis Hector Chavez <lhchavez@chromium.org>
Tested-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Emil Lundmark <lndmrk@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/f2f9d8df9f307aea2f0c269c81ab7f104b8a4a20/init/atrusd.conf

Sign in to add a comment