New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849443 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Left Chrome team
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Clean up instant apps UMA

Project Member Reported by mariakho...@chromium.org, Jun 4 2018

Issue description

Make sure all the instant apps UMA is in good shape.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f72b1c20517c96291c1e9509e7dc01bbbc88cc7

commit 4f72b1c20517c96291c1e9509e7dc01bbbc88cc7
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Tue Jun 05 18:31:56 2018

Remove obsolete histogram recording call.

The function recording the metric has not been used by any code for a
long time now.

Bug:  849443 
Change-Id: I9b53a7801a99df7a1b92d32c614d1c79c13c47fa
Reviewed-on: https://chromium-review.googlesource.com/1086214
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564589}
[modify] https://crrev.com/4f72b1c20517c96291c1e9509e7dc01bbbc88cc7/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java
[modify] https://crrev.com/4f72b1c20517c96291c1e9509e7dc01bbbc88cc7/tools/metrics/histograms/histograms.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4323fb59cf23a74ffc8a68064fdab0e45583df8f

commit 4323fb59cf23a74ffc8a68064fdab0e45583df8f
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Mon Jun 11 19:09:03 2018

Add new owners for histograms and actions I currently own.

Add extra descriptions to make it more obvious when and how things get
recorded.

There are a few things that still have me as an owner, they are pending
either deletion or clean-up before I find new owners for them.

Bug:  849443 
Change-Id: I93bd347c009239b735caaaa36cd753e42fec989e
Reviewed-on: https://chromium-review.googlesource.com/1093699
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566095}
[modify] https://crrev.com/4323fb59cf23a74ffc8a68064fdab0e45583df8f/tools/metrics/actions/actions.xml
[modify] https://crrev.com/4323fb59cf23a74ffc8a68064fdab0e45583df8f/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/673b60c96b00adfc2ebe17d9ca33e53e4e7ee9d1

commit 673b60c96b00adfc2ebe17d9ca33e53e4e7ee9d1
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Mon Jun 11 20:05:09 2018

Switch from user action to histogram.

We record page load eligibility on every page load in a user action
today. Switch to a more compact histogram representation, there's no
need for us to have a user action for this.

Bug:  849443 
Change-Id: Ib3a1dfc6e324126e8780a2771fb823ec93607612
Reviewed-on: https://chromium-review.googlesource.com/1093635
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566118}
[modify] https://crrev.com/673b60c96b00adfc2ebe17d9ca33e53e4e7ee9d1/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java
[modify] https://crrev.com/673b60c96b00adfc2ebe17d9ca33e53e4e7ee9d1/tools/metrics/actions/actions.xml
[modify] https://crrev.com/673b60c96b00adfc2ebe17d9ca33e53e4e7ee9d1/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment