New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 849442 link

Starred by 2 users
Status: Fixed
Owner:
lijeffrey@chromium.org
Closed: Jun 2018
Cc:
lijeffrey@chromium.org
█ robert...@chromium.org
chanli@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Valid builds need commit position to be valid

Project Member Reported by lijeffrey@chromium.org, Jun 4 2018 
Some BuildInfo instances are returned without commit_position set, which may happen if some exception occurred during the build. These builds should not count as valid
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/434d46fa3e20f4bec0e1276bd99715324e006a91

commit 434d46fa3e20f4bec0e1276bd99715324e006a91
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Wed Jun 06 00:38:34 2018

[Findit] Flake Analyzer - Implementing function to search for nearby valid build

1. Increase criteria for determining whether a build is valid by also checking
   that it has commit_position set
2. Add search of 10 builds in either direction when estimating a starting lower
   bound build point for flake analysis

Bug:  849442 
Change-Id: I10d9a5e8f0ccfc09197baa2a68c8ac57697160b9
Reviewed-on: https://chromium-review.googlesource.com/1086215
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/434d46fa3e20f4bec0e1276bd99715324e006a91/appengine/findit/services/step_util.py
[modify] https://crrev.com/434d46fa3e20f4bec0e1276bd99715324e006a91/appengine/findit/services/test/step_util_test.py

Comment 2 by lijeffrey@chromium.org, Jun 6 2018

Status: Fixed (was: Assigned)

Comment 3 by lijeffrey@chromium.org, Jun 6 2018

Cc: lijeffrey@chromium.org
 Issue 829957  has been merged into this issue.
►

Sign in to add a comment