add end-to-end UI testing for crostini |
||||||||||||||
Issue descriptionSee issue 849028 for context. tl;dr multiple changes got through the CQ that broke crostini due to the lack of end-to-end testing. We should be able to test: 1) Turning on "Linux apps" from settings works and setup finishes 2) The Terminal app starts 3) (later) Launcher icons work I think we do this kind of testing for ARC++, so we should also be able to do it for crostini.
,
Jun 6 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6761727765a4eace19fce00f3272ba1a609f08b commit e6761727765a4eace19fce00f3272ba1a609f08b Author: Nicholas Verne <nverne@chromium.org> Date: Wed Jun 13 08:22:56 2018 Fixes bugs in CrostiniRemover and CrostiniUninstallerView. Also adds a browsertest for CrostiniUninstallerView. Bug: 849438 Change-Id: I13ff94ec9324be0c01757f3094d76403c1d3b30f Reviewed-on: https://chromium-review.googlesource.com/1092397 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#566758} [modify] https://crrev.com/e6761727765a4eace19fce00f3272ba1a609f08b/chrome/browser/chromeos/crostini/crostini_remover.cc [modify] https://crrev.com/e6761727765a4eace19fce00f3272ba1a609f08b/chrome/browser/ui/views/crostini/crostini_uninstaller_view.cc [modify] https://crrev.com/e6761727765a4eace19fce00f3272ba1a609f08b/chrome/browser/ui/views/crostini/crostini_uninstaller_view.h [add] https://crrev.com/e6761727765a4eace19fce00f3272ba1a609f08b/chrome/browser/ui/views/crostini/crostini_uninstaller_view_browsertest.cc [modify] https://crrev.com/e6761727765a4eace19fce00f3272ba1a609f08b/chrome/test/BUILD.gn
,
Jun 19 2018
,
Jul 27
<triage>Is this done, or should it be moved to M70?</triage>
,
Aug 1
,
Sep 5
,
Sep 7
This will cover more than the original bug now...I'll be putting all my changes for Crostini tast-tests stuff in this one.
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/7c053eb630f50823b0984b2c4c41576471eb5c75 commit 7c053eb630f50823b0984b2c4c41576471eb5c75 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Tue Sep 11 00:17:52 2018 vm: Consolidate webserver and start_termina_vm tests This consolidates the webserver and start_termina_vm into one test so the VM/container do not need to be created. Going forward we will add all Crostini tests into this one to avoid the overhead of that recreation for each test. BUG= chromium:849438 TEST=vm.CrostiniMultitest Change-Id: I6153b56f821dab2dafa3513d86ec533327fd6a3b Reviewed-on: https://chromium-review.googlesource.com/1213777 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [delete] https://crrev.com/c297d477c8c0e98009cfa0aec7e981ee3b6f268d/src/chromiumos/tast/local/bundles/cros/vm/webserver.go [add] https://crrev.com/7c053eb630f50823b0984b2c4c41576471eb5c75/src/chromiumos/tast/local/bundles/cros/vm/subtest/webserver.go [add] https://crrev.com/7c053eb630f50823b0984b2c4c41576471eb5c75/src/chromiumos/tast/local/bundles/cros/vm/crostini_start_everything.go [delete] https://crrev.com/c297d477c8c0e98009cfa0aec7e981ee3b6f268d/src/chromiumos/tast/local/bundles/cros/vm/start_termina_vm.go
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/1445bfbf98f10f4bd36dae6a75fde64b362c9890 commit 1445bfbf98f10f4bd36dae6a75fde64b362c9890 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Tue Sep 11 00:18:00 2018 vm_tools: sommelier: Add demo apps for tast-tests This adds executables for an x11 and wayland test, called x11_demo and wayland_demo. Each of them can take a single parameter which for clarity should be a color in hex format (e.g. 0xabcdef). One uses X11 for display and the other uses Wayland. They just create a full screen window which then draws the specified color as its background color. They each will terminate on any keypress event. The intention is to use these in the tast-tests to verify that both X11 and Wayland apps both can render themselves to the screen. BUG= chromium:849438 TEST=Executed on eve and verified functionality Change-Id: I7e91ef9c64304eef9b95075b8262fe18c66dd528 Reviewed-on: https://chromium-review.googlesource.com/1214115 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [add] https://crrev.com/1445bfbf98f10f4bd36dae6a75fde64b362c9890/vm_tools/sommelier/demos/wayland_demo.cc [modify] https://crrev.com/1445bfbf98f10f4bd36dae6a75fde64b362c9890/vm_tools/sommelier/sommelier.gyp [add] https://crrev.com/1445bfbf98f10f4bd36dae6a75fde64b362c9890/vm_tools/sommelier/demos/x11_demo.cc
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5c9c28aa7b600f67dba33b4d2f0c7d9f952f5a80 commit 5c9c28aa7b600f67dba33b4d2f0c7d9f952f5a80 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Tue Sep 11 04:16:58 2018 Add x11_demo and wayland_demo to ebuilds These executables are used in automated testing to verify graphics functionality in Crostini. BUG= chromium:849438 TEST=Builds CQ-DEPEND=CL:1214115 Change-Id: If83299bedc9b6a297830682df84bb6755f5130be Reviewed-on: https://chromium-review.googlesource.com/1217143 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [rename] https://crrev.com/5c9c28aa7b600f67dba33b4d2f0c7d9f952f5a80/chromeos-base/termina_container_tools/termina_container_tools-0.0.1-r11.ebuild [modify] https://crrev.com/5c9c28aa7b600f67dba33b4d2f0c7d9f952f5a80/chromeos-base/vm_guest_tools/vm_guest_tools-9999.ebuild [modify] https://crrev.com/5c9c28aa7b600f67dba33b4d2f0c7d9f952f5a80/chromeos-base/termina_container_tools/termina_container_tools-0.0.1.ebuild
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9b78f71666284a5ad5a632763043349ead0eecf commit f9b78f71666284a5ad5a632763043349ead0eecf Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Wed Sep 12 05:11:38 2018 Increase Start/CreateLxdContainer timeouts to match cicerone The timeout values in Chrome were lower than those in cicerone so this increases the Chrome values to match what is in cicerone. Automated tests are failing on these timeouts currently due to this. BUG= chromium:849438 TEST=None Change-Id: I223ab4d6c11db32233704514c8b0711f43b5f031 Reviewed-on: https://chromium-review.googlesource.com/1220466 Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#590601} [modify] https://crrev.com/f9b78f71666284a5ad5a632763043349ead0eecf/chromeos/dbus/cicerone_client.cc
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/57487fc7da27848fcbc3ce7cbeb550ef22dd6ec3 commit 57487fc7da27848fcbc3ce7cbeb550ef22dd6ec3 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Thu Sep 13 13:14:11 2018 tast-tests: screenshot: Extract screenshot check into its own package This extracts the functionality that takes a screenshot, creates a histogram of the pixels and then checks if the dominant color matches a target color and covers a certain ratio of the screen. This is only used by the Screenshot test right now, but new tests will be added soon that also use this functionality. BUG= chromium:849438 TEST=tast run eve graphics.Screenshot Change-Id: Ic39282305f9673fe0266c9b8156d9e8578635a5f Reviewed-on: https://chromium-review.googlesource.com/1216505 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> [modify] https://crrev.com/57487fc7da27848fcbc3ce7cbeb550ef22dd6ec3/src/chromiumos/tast/local/bundles/cros/graphics/screenshot.go [add] https://crrev.com/57487fc7da27848fcbc3ce7cbeb550ef22dd6ec3/src/chromiumos/tast/local/screenshot/screenshot.go
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/14baae6a5be863a5c4c9f1224983489dfaee04f5 commit 14baae6a5be863a5c4c9f1224983489dfaee04f5 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Thu Sep 13 13:14:05 2018 vm_tools: sommelier: Fix wayland_demo app full screen issue This fixes a bug where the wayland_demo app wasn't going full screen because the right version wasn't being passed to wl_registry_bind for the wl_output callback. It also fixes the keypress listener so that it only exits on keypress events rather than also keyrelease (which would happen if running this from the command line sometimes manually). BUG= chromium:849438 TEST=tast run eve vm.CrostiniStartEverything (with other pending tests) Change-Id: If2ae59ee434bfd677531146bcab81a027d4fadf4 Reviewed-on: https://chromium-review.googlesource.com/1219980 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: David Reveman <reveman@chromium.org> [modify] https://crrev.com/14baae6a5be863a5c4c9f1224983489dfaee04f5/vm_tools/sommelier/demos/wayland_demo.cc
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/3733c12dac1f655a2a5456dff67433dd287f3af4 commit 3733c12dac1f655a2a5456dff67433dd287f3af4 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Fri Sep 14 19:08:28 2018 tast-tests: Add Crostini tests for X11 and Wayland display This adds 2 tests which execute simple X11 and Wayland test applications that are included in the VM image. These apps just go full screen and draw a solid color. We then take a screenshot and check it to verify the app does actually render. BUG= chromium:849438 TEST=tast run eve vm.CrostiniStartEverything CQ-DEPEND=CL:1219980,CL:1216505 Change-Id: I8f63f7bca4c735c2f39dead80d5b937a383bc09b Reviewed-on: https://chromium-review.googlesource.com/1220810 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Dan Erat <derat@chromium.org> [add] https://crrev.com/3733c12dac1f655a2a5456dff67433dd287f3af4/src/chromiumos/tast/local/bundles/cros/vm/subtest/verify_app_from_terminal.go [modify] https://crrev.com/3733c12dac1f655a2a5456dff67433dd287f3af4/src/chromiumos/tast/local/bundles/cros/vm/crostini_start_everything.go
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/cd6a465d30258d3a945e09543060875e57cdca75 commit cd6a465d30258d3a945e09543060875e57cdca75 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Fri Sep 14 19:08:27 2018 tast-tests: Wait for python webserver startup This fixes an issue where we could test connections to the python webserver running in Crostini before it has actually completed startup which would cause a test failure. BUG= chromium:849438 TEST=tast run kevin vm.CrostiniStartEverything Change-Id: I6a8447b4827878ed7a0b405f87d7cddfe51b9b6b Reviewed-on: https://chromium-review.googlesource.com/1225370 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/cd6a465d30258d3a945e09543060875e57cdca75/src/chromiumos/tast/local/bundles/cros/vm/subtest/webserver.go
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/containers/cros-container-guest-tools/+/ba08799ba349d38f8d09e8ec56abfe99a4e477a5 commit ba08799ba349d38f8d09e8ec56abfe99a4e477a5 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Fri Sep 14 19:08:35 2018 cros-tast-tests: Add test Debian package This Debian package will be used in automated tast tests to verify various functionality relating to Debian package info, install and uninstall. BUG= chromium:849438 TEST=Builds, package info succeeds Change-Id: Ica441beb43a75029c16ec89d4942239f1572d09a Reviewed-on: https://chromium-review.googlesource.com/1224993 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [add] https://crrev.com/ba08799ba349d38f8d09e8ec56abfe99a4e477a5/cros-tast-tests/deb-description [add] https://crrev.com/ba08799ba349d38f8d09e8ec56abfe99a4e477a5/cros-tast-tests/wayland_demo.desktop [add] https://crrev.com/ba08799ba349d38f8d09e8ec56abfe99a4e477a5/cros-tast-tests/BUILD [add] https://crrev.com/ba08799ba349d38f8d09e8ec56abfe99a4e477a5/cros-tast-tests/x11_demo.desktop
,
Sep 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/01cf2e8009ebdbc1d212c9789be6066aacd5800d commit 01cf2e8009ebdbc1d212c9789be6066aacd5800d Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Sun Sep 16 11:04:38 2018 tast-tests: Add test for launching browser from Crostini This launches the Chrome browser from the terminal by using the 3 different methods we have configured. The x-www-browser alternative, the BROWSER env variable and via xdg-open. BUG= chromium:849438 TEST=tast run eve vm.CrostiniStartEverything Change-Id: Icb997ca7725187648004c0a5d03acfc846fb0422 Reviewed-on: https://chromium-review.googlesource.com/1225110 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> [modify] https://crrev.com/01cf2e8009ebdbc1d212c9789be6066aacd5800d/src/chromiumos/tast/local/bundles/cros/vm/crostini_start_everything.go [add] https://crrev.com/01cf2e8009ebdbc1d212c9789be6066aacd5800d/src/chromiumos/tast/local/bundles/cros/vm/subtest/launch_browser.go
,
Sep 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a571707a92788b3ef0738a3d702d4203baa16efa commit a571707a92788b3ef0738a3d702d4203baa16efa Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Sun Sep 16 11:04:33 2018 vm_tools: sommelier: Add window classes to x11/wayland demos This sets the window class for the demo apps so they will correlate properly to the .desktop entries and show up on the shelf. BUG= chromium:849438 TEST=Verified on eve launching the apps shows them on the shelf Change-Id: Ib8d0f2ecfa3ce76f116465d64c6b75a012e02159 Reviewed-on: https://chromium-review.googlesource.com/1226469 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/a571707a92788b3ef0738a3d702d4203baa16efa/vm_tools/sommelier/demos/wayland_demo.cc [modify] https://crrev.com/a571707a92788b3ef0738a3d702d4203baa16efa/vm_tools/sommelier/demos/x11_demo.cc
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28792284fb6ac2c5b439c5657d086dfaa25ee350 commit 28792284fb6ac2c5b439c5657d086dfaa25ee350 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Tue Sep 18 03:03:06 2018 Set skip Crostini restart when enabling Crostini for testing This modifies the private autotest API so that when it sets Crostini to be enabled that it also notifies the CrostiniRestarter that it should skip its restart phases. This will enable testing of features that integrate into the Chrome launcher without having to invoke the slower Crostini startup process that Chrome uses. BUG= chromium:849438 TEST=Verified on eve that launcher apps can start after this Change-Id: Ieaf9f8d41b8e077fc0ae44bae5ec12da9dcfcf92 Reviewed-on: https://chromium-review.googlesource.com/1227185 Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#591924} [modify] https://crrev.com/28792284fb6ac2c5b439c5657d086dfaa25ee350/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/containers/cros-container-guest-tools/+/7b50e19ff1d193e4592fb19b6c836a77a7724e14 commit 7b50e19ff1d193e4592fb19b6c836a77a7724e14 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Tue Sep 18 21:04:04 2018 cros-tast-tests: Add StartupWMClass properties and icons for demo apps This adds icons which are just solid color 32x32 pngs with the fill color matching the painting color we are using for the tests. These won't be evaluated graphically but will be checked for existence in the container as well as being fetched properly by Chrome. It also sets the StartupWMClass so Chrome can link it to the window properly. BUG= chromium:849438 TEST=Verified apps link to shelf icons on eve Change-Id: I0800e4ef3001586fe2f0aa9854a3fec6a0473eee Reviewed-on: https://chromium-review.googlesource.com/1228268 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [add] https://crrev.com/7b50e19ff1d193e4592fb19b6c836a77a7724e14/cros-tast-tests/x11_demo.png [modify] https://crrev.com/7b50e19ff1d193e4592fb19b6c836a77a7724e14/cros-tast-tests/wayland_demo.desktop [add] https://crrev.com/7b50e19ff1d193e4592fb19b6c836a77a7724e14/cros-tast-tests/wayland_demo.png [modify] https://crrev.com/7b50e19ff1d193e4592fb19b6c836a77a7724e14/cros-tast-tests/BUILD [modify] https://crrev.com/7b50e19ff1d193e4592fb19b6c836a77a7724e14/cros-tast-tests/x11_demo.desktop
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aebfdc01a4a6406a7b086640967add4670dd73ec commit aebfdc01a4a6406a7b086640967add4670dd73ec Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Thu Sep 20 22:28:28 2018 Add autotest API for launching an app from the launcher BUG= chromium:849438 TEST=tast run vm.CrostiniStartEverything Change-Id: I51963c9f4fe7b5aa9fd42e2c040410a974376f58 Reviewed-on: https://chromium-review.googlesource.com/1235199 Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#592972} [modify] https://crrev.com/aebfdc01a4a6406a7b086640967add4670dd73ec/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc [modify] https://crrev.com/aebfdc01a4a6406a7b086640967add4670dd73ec/chrome/browser/extensions/api/autotest_private/autotest_private_api.h [modify] https://crrev.com/aebfdc01a4a6406a7b086640967add4670dd73ec/chrome/common/extensions/api/autotest_private.idl [modify] https://crrev.com/aebfdc01a4a6406a7b086640967add4670dd73ec/chrome/test/data/extensions/api_test/autotest_private/test.js [modify] https://crrev.com/aebfdc01a4a6406a7b086640967add4670dd73ec/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/aebfdc01a4a6406a7b086640967add4670dd73ec/tools/metrics/histograms/enums.xml
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1b616221a6e5a16184f7c23c6974c59324b286f commit f1b616221a6e5a16184f7c23c6974c59324b286f Author: Joel Hockey <joelhockey@chromium.org> Date: Fri Sep 21 02:30:35 2018 Crostini: Allow any observers of RemoveCrostini This will be used at least in tast tests where the UI is used to uninstall crostini, but the test must wait until uninstall completes and receives result. Bug: 849438 Change-Id: Ia44dfa80cae957082bc1641bc5540f69b0ba3b40 Reviewed-on: https://chromium-review.googlesource.com/1236616 Reviewed-by: Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#593056} [modify] https://crrev.com/f1b616221a6e5a16184f7c23c6974c59324b286f/chrome/browser/chromeos/crostini/crostini_manager.cc [modify] https://crrev.com/f1b616221a6e5a16184f7c23c6974c59324b286f/chrome/browser/chromeos/crostini/crostini_manager.h
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/containers/cros-container-guest-tools/+/49729a1cf43f58bc670bd360362747380ad62936 commit 49729a1cf43f58bc670bd360362747380ad62936 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Fri Sep 21 07:51:17 2018 Remove gnome-mahjongg and gimp from test container image We don't need these for testing and they will cause other packages to be installed which we don't want to accidentally have dependencies on by having tests succeed that have shared dependencies. We instead created bare minimum X11 and Wayland apps for the purposes of testing graphical applications. BUG= chromium:849438 TEST=None Change-Id: I3de01ef3f573c59501a92befd97e3e1af27dbdec Reviewed-on: https://chromium-review.googlesource.com/1236935 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/49729a1cf43f58bc670bd360362747380ad62936/lxd/lxd_test_setup.sh
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/b7d7b1d61ce8fac97c637025c54d058adccd6cc7 commit b7d7b1d61ce8fac97c637025c54d058adccd6cc7 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Fri Sep 21 10:38:22 2018 tast-tests: Add launcher integration tests for Crostini This adds tests which verify that the package installed in prior CLs actually ends up with the items integrated into the Chrome launcher, that their icons are in the filesystem, the apps can be launched, they draw to the screen, their shelf items are present and then in a later CL we will close them and verify their shelf items disappear. NOTE: The screenshot tests from the launcher currently fail for the x11 app due to https://crbug.com/887016 . BUG= chromium:849438 TEST=tast run vm.CrostiniStartEverything CQ-DEPEND=CL:1235199 Change-Id: Ic65c1cf3ed4f0bbb115c5a9bc425ca842eb16a7c Reviewed-on: https://chromium-review.googlesource.com/1234304 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> [modify] https://crrev.com/b7d7b1d61ce8fac97c637025c54d058adccd6cc7/src/chromiumos/tast/local/bundles/cros/vm/subtest/verify_app_from_terminal.go [modify] https://crrev.com/b7d7b1d61ce8fac97c637025c54d058adccd6cc7/src/chromiumos/tast/local/bundles/cros/vm/crostini_start_everything.go [add] https://crrev.com/b7d7b1d61ce8fac97c637025c54d058adccd6cc7/src/chromiumos/tast/local/bundles/cros/vm/subtest/verify_launcher_app.go [modify] https://crrev.com/b7d7b1d61ce8fac97c637025c54d058adccd6cc7/src/chromiumos/tast/local/vm/concierge.go
,
Sep 22
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/4fbd3561d7c36161d9b074efeff9554bea1e3746 commit 4fbd3561d7c36161d9b074efeff9554bea1e3746 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Sat Sep 22 05:25:51 2018 tast-tests: Fix command for invoking python webserver I'm guessing that when we removed gimp & gnome-majhongg from the test container image yesterday that it ended up also removing python2. We are installing python2.7 explicitly into the test container so the command just needs to be changed to reflect that. BUG= chromium:849438 TEST=tast run vm.CrostiniStartEverything Change-Id: I6ece29630b725070928ec026f462396f4ecddef3 Reviewed-on: https://chromium-review.googlesource.com/1239193 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/4fbd3561d7c36161d9b074efeff9554bea1e3746/src/chromiumos/tast/local/bundles/cros/vm/subtest/webserver.go
,
Sep 22
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/f4e4f2bf781517f49b1ff9ef2dfdaf03e660b9dc commit f4e4f2bf781517f49b1ff9ef2dfdaf03e660b9dc Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Sat Sep 22 05:25:53 2018 tast-tests: Remove vm.StopConcierge call I always comment this out during development because it's very helpful to leave the VM/container up for introspection after a test fails. Since we aren't actually checking the result of it, we are not actually testing anything with this call. Changes I've made to the CrostiniFiles test now do uninstall which will verify we can stop the VM successfully, so we do have coverage of that aspect in that test which should make it safe to remove from here. BUG= chromium:849438 TEST=tast run vm.CrostiniStartEverything Change-Id: I216f601e79b077dd4cc7103d8324adf42a3052ee Reviewed-on: https://chromium-review.googlesource.com/1239195 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/f4e4f2bf781517f49b1ff9ef2dfdaf03e660b9dc/src/chromiumos/tast/local/bundles/cros/vm/crostini_start_everything.go
,
Sep 22
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c1a17c5cc4d21d529b94d00dee080fb742ae30a5 commit c1a17c5cc4d21d529b94d00dee080fb742ae30a5 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Sat Sep 22 15:30:06 2018 vm_tools: Increase timeouts for container operations We've seen various test failures due to timeouts being too low so set them to a much larger value (1 or 2 minutes) to account for corner cases where there's other things going on which may get in the way. BUG= chromium:849438 TEST=Builds Change-Id: I22017e6f56e359d9e7d17ae11f4ca6305cf61d7e Reviewed-on: https://chromium-review.googlesource.com/1239245 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/c1a17c5cc4d21d529b94d00dee080fb742ae30a5/vm_tools/cicerone/client.cc [modify] https://crrev.com/c1a17c5cc4d21d529b94d00dee080fb742ae30a5/vm_tools/cicerone/virtual_machine.cc [modify] https://crrev.com/c1a17c5cc4d21d529b94d00dee080fb742ae30a5/vm_tools/cicerone/container.cc [modify] https://crrev.com/c1a17c5cc4d21d529b94d00dee080fb742ae30a5/vm_tools/garcon/package_kit_proxy.cc
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddd692c849fa4627ab1858e29bbf895020c84147 commit ddd692c849fa4627ab1858e29bbf895020c84147 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Mon Sep 24 20:16:40 2018 Add autotest API for uninstalling Crostini This will execute the uninstall operation via the UI and the callback will be invoked upon completion. BUG= chromium:849438 TEST=tast run vm.CrostiniFiles Change-Id: I854b0563cea082a325c3c52a00e2c357cb62a295 Reviewed-on: https://chromium-review.googlesource.com/1237387 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#593657} [modify] https://crrev.com/ddd692c849fa4627ab1858e29bbf895020c84147/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc [modify] https://crrev.com/ddd692c849fa4627ab1858e29bbf895020c84147/chrome/browser/extensions/api/autotest_private/autotest_private_api.h [modify] https://crrev.com/ddd692c849fa4627ab1858e29bbf895020c84147/chrome/common/extensions/api/autotest_private.idl [modify] https://crrev.com/ddd692c849fa4627ab1858e29bbf895020c84147/chrome/test/data/extensions/api_test/autotest_private/test.js [modify] https://crrev.com/ddd692c849fa4627ab1858e29bbf895020c84147/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/ddd692c849fa4627ab1858e29bbf895020c84147/tools/metrics/histograms/enums.xml
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/ffae46dc4e5955534051e82b16c68b59a5a0337f commit ffae46dc4e5955534051e82b16c68b59a5a0337f Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Wed Sep 26 17:32:47 2018 tast-tests: Add uninstall to the CrostiniFiles test This does an uninstall after we verify the sshfs mount and then verifies the mount is longer there after that. This then also serves the purpose of testing the complete install/uninstall flow from the Chrome UI. BUG= chromium:849438 TEST=tast run vm.CrostiniFiles CQ-DEPEND=CL:1237387 Change-Id: I74403e90afe8d59713f360047f5b37dfe5d66fc8 Reviewed-on: https://chromium-review.googlesource.com/1236520 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> [modify] https://crrev.com/ffae46dc4e5955534051e82b16c68b59a5a0337f/src/chromiumos/tast/local/bundles/cros/vm/crostini_files.go
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/0299121a9f5f6dcaf3b068e6d085d498be55c4ba commit 0299121a9f5f6dcaf3b068e6d085d498be55c4ba Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Wed Sep 26 17:32:12 2018 tast-tests: Add dumping of the container log to an output file This adds a call in Container which will execute journalctl in the container to extract the container's log file and save it to an output file so it is available for analysis. This is then used in the CrostiniStartEverything test. BUG= chromium:849438 TEST=tast run vm.CrostiniStartEverything Change-Id: Id87f0a7ddfddc0cd65cf6cc5716dfb56b86d77d8 Reviewed-on: https://chromium-review.googlesource.com/1239361 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/0299121a9f5f6dcaf3b068e6d085d498be55c4ba/src/chromiumos/tast/local/vm/container.go [modify] https://crrev.com/0299121a9f5f6dcaf3b068e6d085d498be55c4ba/src/chromiumos/tast/local/bundles/cros/vm/crostini_start_everything.go
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/c4372efdc65319dc360b130db334c36525c25fac commit c4372efdc65319dc360b130db334c36525c25fac Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Wed Sep 26 17:32:13 2018 tast-tests: Fix incorrect log statement for Crostini test BUG= chromium:849438 TEST=None Change-Id: I4bab78be8fff2f1452f56064aac9f0019695ea87 Reviewed-on: https://chromium-review.googlesource.com/1244408 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/c4372efdc65319dc360b130db334c36525c25fac/src/chromiumos/tast/local/bundles/cros/vm/subtest/verify_launcher_app.go
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e1a680428104562b8417b0b4d1b1a4cc04a59c3 commit 2e1a680428104562b8417b0b4d1b1a4cc04a59c3 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Wed Sep 26 21:00:00 2018 Update cicerone_client timeouts to match cicerone Recently we updated all timeouts in cicerone to be longer because we were running into too many failures relating to timeouts and we should be much more lenient with that for now. We also avoid using the D-Bus default timeout now as well in here so the values are well known. BUG= chromium:849438 TEST=Builds Change-Id: I6fef4a25c1056d91fc4059146fa2a67094ad9a5d Reviewed-on: https://chromium-review.googlesource.com/1246784 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#594469} [modify] https://crrev.com/2e1a680428104562b8417b0b4d1b1a4cc04a59c3/chromeos/dbus/cicerone_client.cc
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/347b47cbb0c6dc3da04f452fcb888d6fba2d2eb3 commit 347b47cbb0c6dc3da04f452fcb888d6fba2d2eb3 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Fri Sep 28 02:44:35 2018 tast-tests: Wait for ComponentUpdater for the StartCrosvm test This test was failing because example.DBus was restarting the ui job as part of its test, which caused the ComponentLoader service to not be found when running this test. Now we wait for that to be started up before running this test. BUG= chromium:849438 TEST=tast run eve example.DBus vm.StartCrosvm Change-Id: I626636fc3fa477b9f998abb56a642198ede80bd9 Reviewed-on: https://chromium-review.googlesource.com/1246276 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/347b47cbb0c6dc3da04f452fcb888d6fba2d2eb3/src/chromiumos/tast/local/bundles/cros/vm/start_crosvm.go
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b323e1e757bfbc5f62bea7bad11744fd688eacc commit 2b323e1e757bfbc5f62bea7bad11744fd688eacc Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Fri Sep 28 19:12:09 2018 Add autotest private API for taking a screenshot This is a temporary solution to taking screenshots for tast-tests that will work properly on ARM devices as well as deal with hardware overlays. Longer term the plan is to implement this via the DRM API with a write-back connector and then use that from the CLI screenshot program. BUG= chromium:849438 ,chromium:880597, chromium:887016 TEST=tast run graphics.Screenshot (after updating it to use this) Change-Id: I3919822599338e4786c715d7b0419742417b83c2 Reviewed-on: https://chromium-review.googlesource.com/1247181 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#595173} [modify] https://crrev.com/2b323e1e757bfbc5f62bea7bad11744fd688eacc/chrome/browser/chromeos/extensions/autotest_private/DEPS [modify] https://crrev.com/2b323e1e757bfbc5f62bea7bad11744fd688eacc/chrome/browser/chromeos/extensions/autotest_private/autotest_private_api.cc [modify] https://crrev.com/2b323e1e757bfbc5f62bea7bad11744fd688eacc/chrome/browser/chromeos/extensions/autotest_private/autotest_private_api.h [modify] https://crrev.com/2b323e1e757bfbc5f62bea7bad11744fd688eacc/chrome/common/extensions/api/autotest_private.idl [modify] https://crrev.com/2b323e1e757bfbc5f62bea7bad11744fd688eacc/chrome/test/data/extensions/api_test/autotest_private/test.js [modify] https://crrev.com/2b323e1e757bfbc5f62bea7bad11744fd688eacc/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/2b323e1e757bfbc5f62bea7bad11744fd688eacc/tools/metrics/histograms/enums.xml
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/7938385ddbb8683775b47fb2c6efc4f6696c4706 commit 7938385ddbb8683775b47fb2c6efc4f6696c4706 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Tue Oct 02 12:19:19 2018 tast-tests: Use autotest API for screenshots This is a temporary solution until the CLI screenshot program is updated to work with ARM devices and also handle hardware overlays. BUG= chromium:849438 ,chromium:880597, chromium:887016 TEST=tast run graphics.ScreenshotChrome graphics.ScreenshotCLI vm.CrostiniStartEverything Change-Id: Idb908b55097370158a45737a425a896414ea4e93 Reviewed-on: https://chromium-review.googlesource.com/1246690 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> [modify] https://crrev.com/7938385ddbb8683775b47fb2c6efc4f6696c4706/src/chromiumos/tast/local/bundles/cros/vm/crostini_start_everything.go [modify] https://crrev.com/7938385ddbb8683775b47fb2c6efc4f6696c4706/src/chromiumos/tast/local/bundles/cros/vm/subtest/verify_launcher_app.go [modify] https://crrev.com/7938385ddbb8683775b47fb2c6efc4f6696c4706/src/chromiumos/tast/local/bundles/cros/vm/subtest/verify_app_from_terminal.go [modify] https://crrev.com/7938385ddbb8683775b47fb2c6efc4f6696c4706/src/chromiumos/tast/local/screenshot/screenshot.go [add] https://crrev.com/7938385ddbb8683775b47fb2c6efc4f6696c4706/src/chromiumos/tast/local/bundles/cros/graphics/screenshot_cli.go [rename] https://crrev.com/7938385ddbb8683775b47fb2c6efc4f6696c4706/src/chromiumos/tast/local/bundles/cros/graphics/sshot/sshot.go [add] https://crrev.com/7938385ddbb8683775b47fb2c6efc4f6696c4706/src/chromiumos/tast/local/bundles/cros/graphics/screenshot_chrome.go
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/7b9b277aa0981f7636ed4e837b62bbe0be50ed7e commit 7b9b277aa0981f7636ed4e837b62bbe0be50ed7e Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Tue Oct 02 12:19:20 2018 tast-tests: Increase vm.CrostiniStartEverything timeout We're seeing timeouts in this test during the last parts of it on some boards, we would likely be ok with just increasing it by a minute...but let's increase it to 10 minutes to cover any additional slowdowns that might occur due to other reasons as well. BUG= chromium:849438 TEST=tast run vm.CrostiniStartEverything Change-Id: I95b5574c5478ee635e950e2115bb028f24e1d83e Reviewed-on: https://chromium-review.googlesource.com/1255443 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/7b9b277aa0981f7636ed4e837b62bbe0be50ed7e/src/chromiumos/tast/local/bundles/cros/vm/crostini_start_everything.go
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/cc11cdc88238c537306d077c7662c962c594c104 commit cc11cdc88238c537306d077c7662c962c594c104 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Tue Oct 02 16:17:41 2018 tast-tests: Disable stdin related test in StartCrosvm We currently don't have a working stdin for the VM on ARM, so disable the part of the vm.StartCrosvm test which relies on that. It will still be able to validate VM startup occur properly though. BUG= chromium:849438 , chromium:890956 TEST=tast run vm.StartCrosvm Change-Id: I30b4bf4640c2b9a64cf24879395107ed4e9424e8 Reviewed-on: https://chromium-review.googlesource.com/1255448 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/cc11cdc88238c537306d077c7662c962c594c104/src/chromiumos/tast/local/bundles/cros/vm/start_crosvm.go
,
Oct 5
Marking Fixed as the tests have been added and various related issues fixed. Not solid green yet, but those are different issues and have their own bugs.
,
Oct 5
Requesting merge of changes in comments 28 & 33. These are respectively: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1239245 https://chromium-review.googlesource.com/c/chromium/src/+/1246784
,
Oct 5
This bug requires manual review: We are only 10 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 8
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15a09fb6f555da13a1fd9118b57697f7d004cf98 commit 15a09fb6f555da13a1fd9118b57697f7d004cf98 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Mon Oct 08 22:14:52 2018 Update cicerone_client timeouts to match cicerone Recently we updated all timeouts in cicerone to be longer because we were running into too many failures relating to timeouts and we should be much more lenient with that for now. We also avoid using the D-Bus default timeout now as well in here so the values are well known. BUG= chromium:849438 TEST=Builds TBR=jkardatzke@google.com (cherry picked from commit 2e1a680428104562b8417b0b4d1b1a4cc04a59c3) Change-Id: I6fef4a25c1056d91fc4059146fa2a67094ad9a5d Reviewed-on: https://chromium-review.googlesource.com/1246784 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Original-Commit-Position: refs/heads/master@{#594469} Reviewed-on: https://chromium-review.googlesource.com/c/1269715 Cr-Commit-Position: refs/branch-heads/3538@{#905} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/15a09fb6f555da13a1fd9118b57697f7d004cf98/chromeos/dbus/cicerone_client.cc
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15a09fb6f555da13a1fd9118b57697f7d004cf98 Commit: 15a09fb6f555da13a1fd9118b57697f7d004cf98 Author: jkardatzke@google.com Commiter: derat@chromium.org Date: 2018-10-08 22:14:52 +0000 UTC Update cicerone_client timeouts to match cicerone Recently we updated all timeouts in cicerone to be longer because we were running into too many failures relating to timeouts and we should be much more lenient with that for now. We also avoid using the D-Bus default timeout now as well in here so the values are well known. BUG= chromium:849438 TEST=Builds TBR=jkardatzke@google.com (cherry picked from commit 2e1a680428104562b8417b0b4d1b1a4cc04a59c3) Change-Id: I6fef4a25c1056d91fc4059146fa2a67094ad9a5d Reviewed-on: https://chromium-review.googlesource.com/1246784 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Original-Commit-Position: refs/heads/master@{#594469} Reviewed-on: https://chromium-review.googlesource.com/c/1269715 Cr-Commit-Position: refs/branch-heads/3538@{#905} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c4e5bb583fe516a5c8753bde0c5acb6a00d4268d commit c4e5bb583fe516a5c8753bde0c5acb6a00d4268d Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Mon Oct 08 22:24:03 2018 vm_tools: Increase timeouts for container operations We've seen various test failures due to timeouts being too low so set them to a much larger value (1 or 2 minutes) to account for corner cases where there's other things going on which may get in the way. BUG= chromium:849438 TEST=Builds Change-Id: I70948d7a8114c6766df8dd8dd9174473e7aafa38 Reviewed-on: https://chromium-review.googlesource.com/c/1269678 Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> [modify] https://crrev.com/c4e5bb583fe516a5c8753bde0c5acb6a00d4268d/vm_tools/cicerone/client.cc [modify] https://crrev.com/c4e5bb583fe516a5c8753bde0c5acb6a00d4268d/vm_tools/cicerone/virtual_machine.cc [modify] https://crrev.com/c4e5bb583fe516a5c8753bde0c5acb6a00d4268d/vm_tools/cicerone/container.cc [modify] https://crrev.com/c4e5bb583fe516a5c8753bde0c5acb6a00d4268d/vm_tools/garcon/package_kit_proxy.cc
,
Oct 8
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/a3ba55d3b965da260ee57b10ed007da64e645f8f commit a3ba55d3b965da260ee57b10ed007da64e645f8f Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Mon Oct 15 23:01:52 2018 tast-tests: Close Crostini launcher apps with enter This sends the Enter keyboard command after launching the Crostini demo apps from the launcher. This will close the app and then we can verify it has removed itself from the shelf at that point in time. BUG= chromium:849438 TEST=tast run vm.CrostiniStartEverything Change-Id: I9672eb3746e4a08f555f43b19971e4f9ab065384 Reviewed-on: https://chromium-review.googlesource.com/1277207 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> [modify] https://crrev.com/a3ba55d3b965da260ee57b10ed007da64e645f8f/src/chromiumos/tast/local/bundles/cros/vm/subtest/verify_launcher_app.go
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/9ea5ce383c09d8643a6ea29faf17c7057d1be765 commit 9ea5ce383c09d8643a6ea29faf17c7057d1be765 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Thu Nov 01 04:59:33 2018 vm_tools: sommelier: Add demo app flags for setting width/height This also adds a bgcolor flag and defaults the value to what we expect in the tests in order to maintain backwards compatibility. The width and the height arguments are in screen pixels. For wayland we reduce that by the scale factor, which wayland then scales up by the scale factor. This then results in both x11 and wayland demo apps giving the same size window if each is given the same width/height parameters. BUG= chromium:849438 TEST=Manually verified on eve Change-Id: Ia770b7d4c63128f65402a50c621f785eff3b0abc Reviewed-on: https://chromium-review.googlesource.com/1308692 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/9ea5ce383c09d8643a6ea29faf17c7057d1be765/vm_tools/sommelier/demos/wayland_demo.cc [modify] https://crrev.com/9ea5ce383c09d8643a6ea29faf17c7057d1be765/vm_tools/sommelier/demos/x11_demo.cc |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by benwells@chromium.org
, Jun 5 2018Status: Assigned (was: Untriaged)