New issue
Advanced search Search tips

Issue 849434 link

Starred by 1 user
Status: Fixed
Owner:
weifangsun@chromium.org
Closed: Aug 7
Cc:
noel@chromium.org
lucmult@chromium.org
weifangsun@chromium.org
mkarkada@chromium.org
dhadd...@chromium.org
abod...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Files app: Cloud backup button is not aligned with other buttons on top bar

Project Member Reported by sdantul...@chromium.org, Jun 4 2018 
Google Chrome	68.0.3440.14 (Official Build) dev (64-bit)
Revision	6a244aa6611e57d2f3adff0409099923be1d5fe9-refs/branch-heads/3440@{#125}
Platform	10718.12.0 (Official Build) dev-channel caroline

What steps will reproduce the problem?
(1) Open File Manager app
(2) Insert USB drive containing DCIM folder with some images
(3) Open the DCIM folder and observe cloud backup and other buttons in top bar.

What is the expected result?
Cloud backup button should be aligned with other buttons in top bar

What happens instead?
Cloud backup button is not aligned. 

Attached screenshot.
Screenshot 2018-06-04 at 2.39.22 PM.png
2.1 MB View Download

Comment 1 by sashab@chromium.org, Jun 7 2018

Labels: -Pri-2 Pri-1
Owner: noel@chromium.org
Status: Assigned (was: Untriaged)
Noel, PTAL at this regression :)

Comment 2 by slangley@chromium.org, Jun 21 2018

Labels: CrOSFilesCategory-UI
Noel - Any updates to share?

Comment 3 by lucmult@chromium.org, Jul 9

Owner: lucmult@chromium.org
Status: Started (was: Assigned)
Talked to noel@ offline and I'm fixing this.

Comment 4 by noel@chromium.org, Jul 9 

Thanks, I found https://chromium-review.googlesource.com/c/chromium/src/+/979876 was the cause here, FTR.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a68c520f46c039b617e62a764d0dea4acc30c68

commit 4a68c520f46c039b617e62a764d0dea4acc30c68
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Mon Jul 09 11:29:32 2018

Fix cloud import button alignment

Bug:  849434 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id76dc55dd34c6ed907a6301040ecc627b9b48a0f
Reviewed-on: https://chromium-review.googlesource.com/1128819
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573271}
[modify] https://crrev.com/4a68c520f46c039b617e62a764d0dea4acc30c68/ui/file_manager/file_manager/foreground/css/file_manager.css

Comment 6 by noel@chromium.org, Jul 9

Cc: noel@chromium.org

Comment 7 by lucmult@chromium.org, Jul 16

Cc: lucmult@chromium.org
Owner: weifangsun@chromium.org
Weifang, 

This is fixed on main branch, do you think we need to merge on M-68?

I think this can wait to M-69, since we're close to M-69 branch point.

WDYT?

Comment 8 by weifangsun@chromium.org, Jul 16

Labels: -M-68 M-69
Thanks lucmult@! This is a minor enough issue such that there is no need to merge this back to M68. I've updated the milestone target.

Comment 9 by lucmult@google.com, Aug 7

Status: Fixed (was: Started)
Just marking as fixed because this is already fixed for M-69.
►

Sign in to add a comment