InfobarContainerView is placed under the SecondaryToolbarView |
||||
Issue descriptionCauses the SaveCardInfobarView to be partially blocked by the toolbar. This does not seem to affect the existing iOS infobars that use ConfirmInfobarView as it does not use AutoLayout.
,
Jun 12 2018
,
Jun 14 2018
Issue 852925 has been merged into this issue.
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/491991368d587eabc3a4d98ae1d965b103a2e1b8 commit 491991368d587eabc3a4d98ae1d965b103a2e1b8 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Jun 20 16:39:38 2018 [AF][IOS] Takes secondary toolbar into account in credit card save infobar Bug: 849433 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ief1cca17a562786a6d838b9bdf27778918232dff Reviewed-on: https://chromium-review.googlesource.com/1104969 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#568873} [modify] https://crrev.com/491991368d587eabc3a4d98ae1d965b103a2e1b8/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
,
Jun 20 2018
,
Jun 26 2018
Inforbar is displayed correctly with the bottom toolbar. https://drive.google.com/file/d/1sFaY7XZWX_8Fv0iB7Ml3_iKcLfijz7PT/view Verified on iPhoneX, iPhone6s. M69.0.3473.0 canary iOS: 11.4, 12
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df5e2cc33a579c47e6242a808195437092b2f344 commit df5e2cc33a579c47e6242a808195437092b2f344 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Jul 11 19:53:45 2018 [AF][IOS] Takes secondary toolbar into account in CC save infobar (Part 2) This CL moves the logic to set the infobar's bottom margin from |-layoutSubviews| to |-sizeThatFits:|. The former method doesn't always get called after the secondary toolbar disappears in landscape mode. The latter does get called more reliably in both portrait and landscape modes. Also provides comments on why |-setFrame:| is overridden. Bug: 849433 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3ce410378d60535178a0c0c9d0f12f11948772ba Reviewed-on: https://chromium-review.googlesource.com/1112303 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574291} [modify] https://crrev.com/df5e2cc33a579c47e6242a808195437092b2f344/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm |
||||
►
Sign in to add a comment |
||||
Comment 1 by mahmadi@chromium.org
, Jun 8 2018