New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 849427 link

Starred by 1 user
Status: Fixed
Owner:
chanli@chromium.org
Closed: Jun 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Got the wrong first failure when analyzing a webkit_layout_test failure

Project Member Reported by chanli@chromium.org, Jun 4 2018 
sample link: https://findit-for-me.appspot.com/waterfall/build-failure?url=https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Win10/35829

Test 'virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-custom-bg.html' started to fail at build 35826 (first occurrence was 35823 but it didn't fail at 35824 and 35825) but Findit thought 35828 was last pass.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0609c0b2d8bd05d691e33e99e0c328a4d7417171

commit 0609c0b2d8bd05d691e33e99e0c328a4d7417171
Author: Chan <chanli@chromium.org>
Date: Tue Jun 05 01:13:52 2018

[Findit] Store failed tests in failure_log even there is no actual log for failures

Findit looks for tests in failure log from previous builds to determine each test's first failure. So now although Findit doesn't have failure log for webkit_layout_tests, still store failed tests as keys in failure log to make sure Findit can find first failures correctly.

Bug:  849427 
Change-Id: Ie593aa4032b006ba3b4ab686914a8bfe5069369c
Reviewed-on: https://chromium-review.googlesource.com/1086162
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/0609c0b2d8bd05d691e33e99e0c328a4d7417171/appengine/findit/libs/test_results/test/webkit_layout_test_results_test.py
[modify] https://crrev.com/0609c0b2d8bd05d691e33e99e0c328a4d7417171/appengine/findit/libs/test_results/webkit_layout_test_results.py

Comment 2 by chanli@chromium.org, Jun 14 2018

Status: Fixed (was: Started)
►

Sign in to add a comment