New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 849424 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
petewil@chromium.org
█ harringtond@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Improve OfflinePageArchiver and OfflinePageMHTMLArchiver

Project Member Reported by carlosk@chromium.org, Jun 4 2018 
OfflinePageArchiver defines a interface to be implemented by the embedder to create offline page archives. It currently contain also "publish" related methods which are not implemented by the embedder and so should be moved somewhere else to simplify the contract it defines.

Its Chrome implementation, OfflinePageMHTMLArchiver, should also be updated to become fully stateless (probably a singleton) so that when the offline page component receives its instance as a OfflinePageArchiver, it doesn't have to take care of owning it.

Comment 1 by carlosk@chromium.org, Jun 4 2018

Cc: petewil@chromium.org harringtond@chromium.org
Components: UI>Browser>Offline
Labels: OS-Android

Comment 2 by petewil@chromium.org, Jul 16

Labels: Hotlist-Fixit
Status: Available (was: Untriaged)
Requires some design work before we start the fixit (potentially including "won't fix")

Comment 3 by chili@chromium.org, Aug 31 

Should create new interface for OfflinePageArchivePublisher that only contains the publish methods. Need to make sure the test archiver in unit test will follow suite
►

Sign in to add a comment