New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849415 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 853312
Owner:
Closed: Jul 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

deps2submodules is using its own DEPS parser.

Project Member Reported by ehmaldonado@chromium.org, Jun 4 2018

Issue description

deps2submodules is using its own DEPS parser:

https://cs.chromium.org/chromium/infra/recipes/recipe_modules/sync_submodules/resources/deps_utils.py

This caused the builder for infra codesearch to fail, since it doesn't support the same features gclient does:

https://build.chromium.org/deprecated/chromium.infra.codesearch/builders/codesearch-submodules-infra/builds/5412/steps/deps2submodules/logs/stdio

We should migrate it to use gclient.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/18b7ad465b6b7eca5528d4dd8a1c3f069aa38f66

commit 18b7ad465b6b7eca5528d4dd8a1c3f069aa38f66
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Wed Jun 06 22:54:12 2018

Support vars in deps2gitsubmodules.

Brace vars (i.e. '{var_name}/something') were not supported in this custom
parser.

Fix that while we figure out how to use gclient instead.

Tbr: agable@chromium.org
Bug:  849415 
Change-Id: Ideec789a75583b96847851ebf546a012e3b284cc
Reviewed-on: https://chromium-review.googlesource.com/1086117
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Alan Bram <flyboy@chromium.org>

[modify] https://crrev.com/18b7ad465b6b7eca5528d4dd8a1c3f069aa38f66/recipes/recipe_modules/sync_submodules/resources/deps_utils.py

Mergedinto: 853312
Status: Duplicate (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/eda38f28eb96de3c5bd443c6effc3e818ddeb581

commit eda38f28eb96de3c5bd443c6effc3e818ddeb581
Author: Alan Bram <flyboy@chromium.org>
Date: Fri Aug 10 19:01:52 2018

Handle brace vars ("{var_name}/something") in DEPS.

Same temporary fix as was made earlier in the sync_submodules version
of this code; while we figure out if/how to make the more desirable
gclient migration here.  (It is more difficult here, since we are not
in a recipe at this point.)

(The earlier fix was https://chromium-review.googlesource.com/c/infra/infra/+/1086117)

Bug:  849415 
Change-Id: I540776d6d741589bf602314ee8e62f825dbf1d24
Reviewed-on: https://chromium-review.googlesource.com/1168478
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Alan Bram <flyboy@chromium.org>

[modify] https://crrev.com/eda38f28eb96de3c5bd443c6effc3e818ddeb581/infra/libs/deps2submodules/deps_utils.py

Sign in to add a comment