Issue metadata
Sign in to add a comment
|
deps2submodules is using its own DEPS parser. |
||||||||||||||||||||||||
Issue descriptiondeps2submodules is using its own DEPS parser: https://cs.chromium.org/chromium/infra/recipes/recipe_modules/sync_submodules/resources/deps_utils.py This caused the builder for infra codesearch to fail, since it doesn't support the same features gclient does: https://build.chromium.org/deprecated/chromium.infra.codesearch/builders/codesearch-submodules-infra/builds/5412/steps/deps2submodules/logs/stdio We should migrate it to use gclient.
,
Jul 4
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/eda38f28eb96de3c5bd443c6effc3e818ddeb581 commit eda38f28eb96de3c5bd443c6effc3e818ddeb581 Author: Alan Bram <flyboy@chromium.org> Date: Fri Aug 10 19:01:52 2018 Handle brace vars ("{var_name}/something") in DEPS. Same temporary fix as was made earlier in the sync_submodules version of this code; while we figure out if/how to make the more desirable gclient migration here. (It is more difficult here, since we are not in a recipe at this point.) (The earlier fix was https://chromium-review.googlesource.com/c/infra/infra/+/1086117) Bug: 849415 Change-Id: I540776d6d741589bf602314ee8e62f825dbf1d24 Reviewed-on: https://chromium-review.googlesource.com/1168478 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Alan Bram <flyboy@chromium.org> [modify] https://crrev.com/eda38f28eb96de3c5bd443c6effc3e818ddeb581/infra/libs/deps2submodules/deps_utils.py |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 6 2018