Cleanup DataSaver TalkBack |
|||
Issue descriptionFollow up after the blocking bug is fixed * Add support for indicating what sorting is currently active for the data use breakdown * Say "on switch, enabled" instead of "on switch, on"
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6b0ebd38a02eb0f144ac0493f4fd20e4ddbf190 commit e6b0ebd38a02eb0f144ac0493f4fd20e4ddbf190 Author: Robert Ogden <robertogden@chromium.org> Date: Fri Jun 08 18:35:03 2018 Minor DataSaver TalkBack fix This CL adds a content description to the "Details" TextView header over the Data Usage Breakdown table. This content description describes what the current sorting scheme to users using TalkBack. Bug: 849395 Change-Id: I8328a5a41a37a55a532c5955777200df73a44f53 Reviewed-on: https://chromium-review.googlesource.com/1090072 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#565699} [modify] https://crrev.com/e6b0ebd38a02eb0f144ac0493f4fd20e4ddbf190/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java [modify] https://crrev.com/e6b0ebd38a02eb0f144ac0493f4fd20e4ddbf190/chrome/android/java/strings/android_chrome_strings.grd
,
Jun 8 2018
+aposner Ariel, see comment#2. Do you think changing the "On/Off" word on the settings menu to something like "Data Saver" is worth the TalkBack improvement?
,
Jun 8 2018
Just to clarify, are you proposing changing the string "on" in the top left to "Data Saver" If so, I think that's not clear what the switch does so I'd prefer to leave as is.
,
Jun 8 2018
That's correct. I'll mark this as fixed then. The on switch thing is not terribly important and the rest of the settings page is pretty good for TalkBack. |
|||
►
Sign in to add a comment |
|||
Comment 1 by robertogden@chromium.org
, Jun 4 2018