New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849392 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 847857
issue 852886

Blocking:
issue 760553



Sign in to add a comment

Merging Smoothness Page Sets into Rendering Folder

Project Member Reported by amyqiu@google.com, Jun 4 2018

Issue description

As part of merging the smoothness and thread times benchmarks into a single rendering benchmark (http://crbug.com/760553), page sets used for smoothness benchmarks need to be migrated to the rendering folder. They also need to be refactored to inherit from the RenderingStory class and have a consistent structure.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7a5a810dfdf2fabb98c12a455dc33ca83513e66

commit b7a5a810dfdf2fabb98c12a455dc33ca83513e66
Author: Amy Qiu <amyqiu@google.com>
Date: Wed Jun 06 15:50:28 2018

Merge polymer.py into rendering page sets

Copy polymer.py into the rendering folder and refactor classes to
inherit from RenderingStory. Leave original polymer.py in page_sets
folder for now because key_hit_test_cases needs it.

Bug:  849392 
Change-Id: I356f9887849cffb6f576f4c0d6567e3f185e818d
Reviewed-on: https://chromium-review.googlesource.com/1087649
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#564905}
[modify] https://crrev.com/b7a5a810dfdf2fabb98c12a455dc33ca83513e66/tools/perf/expectations.config
[modify] https://crrev.com/b7a5a810dfdf2fabb98c12a455dc33ca83513e66/tools/perf/page_sets/data/rendering_mobile.json
[add] https://crrev.com/b7a5a810dfdf2fabb98c12a455dc33ca83513e66/tools/perf/page_sets/rendering/polymer.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e8ad698f6b147753dcf4fb8164cbef6f4b038de

commit 4e8ad698f6b147753dcf4fb8164cbef6f4b038de
Author: Amy Qiu <amyqiu@google.com>
Date: Wed Jun 06 16:23:18 2018

Fix rendering shared state to avoid supports_system_info

Due to
https://chromium-review.googlesource.com/c/chromium/src/+/1084057,
rendering_shared_state needs to be updated to directly call
GetSystemInfo(), the way webgl_supported_shared_state does.

Bug:  849392 
Change-Id: I9c974fb42a52522c203dd4dcdbdb49cc1d95bd5b
Reviewed-on: https://chromium-review.googlesource.com/1088209
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#564916}
[modify] https://crrev.com/4e8ad698f6b147753dcf4fb8164cbef6f4b038de/tools/perf/page_sets/rendering/rendering_shared_state.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2018

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9b6ca376392bab7d17a181e0ae821dca75940a9

commit f9b6ca376392bab7d17a181e0ae821dca75940a9
Author: Amy Qiu <amyqiu@google.com>
Date: Wed Jun 06 19:53:53 2018

Merge tough_scrolling_cases into rendering page set

Move tough_scrolling_cases into the rendering folder and refactor to
inherit from RenderingStory

Bug:  849392 
Change-Id: I7edf70dedb6fd74e2741c568cfc5df35a35ecbf1
Reviewed-on: https://chromium-review.googlesource.com/1089038
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#565009}
[modify] https://crrev.com/f9b6ca376392bab7d17a181e0ae821dca75940a9/tools/perf/expectations.config
[add] https://crrev.com/f9b6ca376392bab7d17a181e0ae821dca75940a9/tools/perf/page_sets/rendering/tough_scrolling_cases.py
[delete] https://crrev.com/f01be1adba53bc8a8e002e9631589025c52cce57/tools/perf/page_sets/tough_scrolling_cases.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cecab463353bdbb4ad45bef32d5f7b0f6c3663c

commit 1cecab463353bdbb4ad45bef32d5f7b0f6c3663c
Author: Amy Qiu <amyqiu@google.com>
Date: Wed Jun 06 21:58:27 2018

Merge tough_image_decode_cases into rendering page sets

Move tough_image_decode_cases into the rendering folder and refactor
classes to inherit from RenderingStory

Bug:  849392 
Change-Id: I888b1226bc8663c28d79e5871215547af1052b4a
Reviewed-on: https://chromium-review.googlesource.com/1089203
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#565049}
[modify] https://crrev.com/1cecab463353bdbb4ad45bef32d5f7b0f6c3663c/tools/perf/page_sets/data/rendering_desktop.json
[modify] https://crrev.com/1cecab463353bdbb4ad45bef32d5f7b0f6c3663c/tools/perf/page_sets/data/rendering_mobile.json
[add] https://crrev.com/1cecab463353bdbb4ad45bef32d5f7b0f6c3663c/tools/perf/page_sets/rendering/tough_image_decode_cases.py
[delete] https://crrev.com/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6/tools/perf/page_sets/tough_image_decode_cases.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0838a7c2441b4584bfcfdb63b98bd3932d2f9831

commit 0838a7c2441b4584bfcfdb63b98bd3932d2f9831
Author: Amy Qiu <amyqiu@google.com>
Date: Thu Jun 07 15:32:33 2018

Merge tough_texture_upload_cases into rendering page sets

Move tough_texture_upload_cases into the rendering folder and refactor
classes to inherit from RenderingStory

Bug:  849392 
Change-Id: I50dcebcb563e2c50229884a062feb285c0ec4f8d
Reviewed-on: https://chromium-review.googlesource.com/1089453
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#565276}
[modify] https://crrev.com/0838a7c2441b4584bfcfdb63b98bd3932d2f9831/tools/perf/expectations.config
[add] https://crrev.com/0838a7c2441b4584bfcfdb63b98bd3932d2f9831/tools/perf/page_sets/rendering/tough_texture_upload_cases.py
[delete] https://crrev.com/3c9ed082e94fa5f3d9ab42c376ecc49bf50390a9/tools/perf/page_sets/tough_texture_upload_cases.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d522f76c97d30dc1d9781f7d63afa7d8dd0b270

commit 2d522f76c97d30dc1d9781f7d63afa7d8dd0b270
Author: Amy Qiu <amyqiu@google.com>
Date: Thu Jun 07 16:29:40 2018

Merge tough_scheduling_cases into rendering page sets

Move tough_scheduling_cases into the rendering folder and refactor
classes to inherit from RenderingStory

Bug:  849392 
Change-Id: I247f9aff4fde03cda7ea479a9dcf88c04960c749
Reviewed-on: https://chromium-review.googlesource.com/1089459
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#565290}
[add] https://crrev.com/2d522f76c97d30dc1d9781f7d63afa7d8dd0b270/tools/perf/page_sets/rendering/tough_scheduling_cases.py
[delete] https://crrev.com/89e4972ca8aaa2eafd82a42947de96ad7c9d9707/tools/perf/page_sets/tough_scheduling_cases.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bffcae7f46e80299b6d17ed6b4ae356f22dae8b

commit 8bffcae7f46e80299b6d17ed6b4ae356f22dae8b
Author: Amy Qiu <amyqiu@google.com>
Date: Thu Jun 07 19:27:57 2018

Merge image_decoding_cases page set into rendering page sets

Move image_decoding_cases into rendering folder and modify to inherit
from RenderingStory class

Bug:  849392 
Change-Id: I56b02c60c1f674f7c48b8bf378b8bc92f68f4205
Reviewed-on: https://chromium-review.googlesource.com/1089290
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#565377}
[delete] https://crrev.com/32de3d2eeb84088e36236768d7ea799577e0d546/tools/perf/page_sets/image_decoding_cases.py
[add] https://crrev.com/8bffcae7f46e80299b6d17ed6b4ae356f22dae8b/tools/perf/page_sets/rendering/image_decoding_cases.py
[modify] https://crrev.com/8bffcae7f46e80299b6d17ed6b4ae356f22dae8b/tools/perf/page_sets/rendering/rendering_stories.py
[modify] https://crrev.com/8bffcae7f46e80299b6d17ed6b4ae356f22dae8b/tools/perf/page_sets/rendering/story_tags.py

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0a597faf7cdc0b1a909545c19235e947d44fc66

commit e0a597faf7cdc0b1a909545c19235e947d44fc66
Author: Amy Qiu <amyqiu@google.com>
Date: Thu Jun 07 20:50:06 2018

Add  _desktop_gpu_raster suffix to tough_pinch_zoom cases

For rendering.mobile, the "_desktop_gpu_raster" suffix is added to the
names of pages with the GPU_RASTERIZATION tag enabled. This needs to be
added to the rendering_mobile.json file to fix missing pages.

Bug:  849392 
Change-Id: I338542a87b681835a99451f09488c5b7bd54a416
Reviewed-on: https://chromium-review.googlesource.com/1090755
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#565399}
[modify] https://crrev.com/e0a597faf7cdc0b1a909545c19235e947d44fc66/tools/perf/page_sets/data/rendering_mobile.json

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9569c413494d73f11eb4477cf982ad8d9d5ae9a1

commit 9569c413494d73f11eb4477cf982ad8d9d5ae9a1
Author: Amy Qiu <amyqiu@google.com>
Date: Fri Jun 08 18:10:40 2018

Merge pathological_mobile_sites into rendering benchmarks

Move pathological_mobile_sites into the rendering folder and refactor to
inherit from the RenderingStory class

Bug:  849392 
Change-Id: Ie34cda5845f73b133e9d1df34430eede20f2d670
Reviewed-on: https://chromium-review.googlesource.com/1089383
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#565686}
[modify] https://crrev.com/9569c413494d73f11eb4477cf982ad8d9d5ae9a1/tools/perf/expectations.config
[modify] https://crrev.com/9569c413494d73f11eb4477cf982ad8d9d5ae9a1/tools/perf/page_sets/data/rendering_mobile.json
[delete] https://crrev.com/c68f46d7f02a7a511a7760bb18d9b3ac754b9b19/tools/perf/page_sets/pathological_mobile_sites.py
[add] https://crrev.com/9569c413494d73f11eb4477cf982ad8d9d5ae9a1/tools/perf/page_sets/rendering/pathological_mobile_sites.py

Comment 12 by amyqiu@google.com, Jun 14 2018

Blockedon: 852886
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88d37d7e858b08fb8b109933e299f9146fc8a7a5

commit 88d37d7e858b08fb8b109933e299f9146fc8a7a5
Author: Amy Qiu <amyqiu@google.com>
Date: Fri Jun 15 15:49:36 2018

Add tags to filter by page set

Add tags to all pages in each page set to enable filtering results by different page
sets.

Bug:  849392 
Change-Id: Icf6a97566925de783b81cf2f4cb71f3d68f11971
Reviewed-on: https://chromium-review.googlesource.com/1093012
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567659}
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/key_desktop_move_cases.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/key_silk_cases.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/maps.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/pathological_mobile_sites.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/polymer.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/rendering_shared_state.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/simple_mobile_sites.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/story_tags.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/top_real_world_desktop.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/top_real_world_mobile.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/tough_animation_cases.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/tough_canvas_cases.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/tough_filters_cases.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/tough_image_decode_cases.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/tough_path_rendering_cases.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/tough_pinch_zoom_cases.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/tough_scheduling_cases.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/tough_scrolling_cases.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/tough_texture_upload_cases.py
[modify] https://crrev.com/88d37d7e858b08fb8b109933e299f9146fc8a7a5/tools/perf/page_sets/rendering/tough_webgl_cases.py

Comment 14 by amyqiu@google.com, Jun 18 2018

Status: Fixed (was: Started)
This has been completed, now that all the renames are done and the perf dashboard results have been verified.
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96eb86ad018b53c98e5df959ca1e5ec0fda7d0b0

commit 96eb86ad018b53c98e5df959ca1e5ec0fda7d0b0
Author: Amy Qiu <amyqiu@google.com>
Date: Thu Jun 28 15:36:11 2018

Merge key hit test cases into rendering benchmarks

Move key_hit_test_cases into the rendering folder and refactor to
inherit from RenderingStory

Bug:  849392 
Change-Id: Iecf8c273fb137b051ab51ee47f4020addef2548d
Reviewed-on: https://chromium-review.googlesource.com/1118279
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#571135}
[modify] https://crrev.com/96eb86ad018b53c98e5df959ca1e5ec0fda7d0b0/tools/perf/expectations.config
[delete] https://crrev.com/94722d4e926dee2b8557c8b4abb881a4bf1e77f0/tools/perf/page_sets/key_hit_test_cases.py
[add] https://crrev.com/96eb86ad018b53c98e5df959ca1e5ec0fda7d0b0/tools/perf/page_sets/rendering/key_hit_test_cases.py
[modify] https://crrev.com/96eb86ad018b53c98e5df959ca1e5ec0fda7d0b0/tools/perf/page_sets/rendering/story_tags.py

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ee6335252a055e82e945dcc96f17ed13f736473

commit 3ee6335252a055e82e945dcc96f17ed13f736473
Author: Amy Qiu <amyqiu@google.com>
Date: Thu Jun 28 21:35:07 2018

Merge key idle power cases into rendering benchmarks

Move key_idle_power_cases.py into rendering folder and refactor classes
to inherit from RenderingStory. Since this page set uses
android_screen_restoration_shared_state, modify rendering_shared_state
to behave in the same manner

Bug:  849392 
Change-Id: I458523224946ddaec24f57c8d310e863088aa5a6
Reviewed-on: https://chromium-review.googlesource.com/1117576
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#571269}
[modify] https://crrev.com/3ee6335252a055e82e945dcc96f17ed13f736473/tools/perf/benchmarks/thread_times.py
[delete] https://crrev.com/9bbcf96a8c1c5b262ad71254b726b2d1b887c0d1/tools/perf/page_sets/key_idle_power_cases.py
[add] https://crrev.com/3ee6335252a055e82e945dcc96f17ed13f736473/tools/perf/page_sets/rendering/key_idle_power_cases.py
[modify] https://crrev.com/3ee6335252a055e82e945dcc96f17ed13f736473/tools/perf/page_sets/rendering/rendering_shared_state.py
[modify] https://crrev.com/3ee6335252a055e82e945dcc96f17ed13f736473/tools/perf/page_sets/rendering/story_tags.py

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5c12ff522444b1285d300490355c6207d7af128

commit c5c12ff522444b1285d300490355c6207d7af128
Author: Amy Qiu <amyqiu@google.com>
Date: Fri Jun 29 15:31:21 2018

Fix expectations for key hit test cases in rendering.mobile

After merging key_hit_test_cases into rendering.mobile, the expectations
were not copied over correctly. Change to make sure the right page is
skipped.

Bug:  849392 
Change-Id: I571a0af7254a8761171a31688dfa7c251ff8ebde
Reviewed-on: https://chromium-review.googlesource.com/1120158
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#571487}
[modify] https://crrev.com/c5c12ff522444b1285d300490355c6207d7af128/tools/perf/expectations.config

Sign in to add a comment