Deprecate grouping key in Telemetry |
|||||||
Issue descriptionHaving grouping key just add extra complexity for results processing, while its use cases can already be fulfilled through tags. We should remove grouping key support in Telemetry.
,
Jun 6 2018
Grouping keys will also need to be removed from TBM2 and results.html.
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/ba9d017c9e77b3e6bcd2bfa7dceeedc9f1de2414 commit ba9d017c9e77b3e6bcd2bfa7dceeedc9f1de2414 Author: Nghia Nguyen <nednguyen@google.com> Date: Wed Jun 06 05:45:32 2018 Add deprecation message for grouping_keys Bug: chromium:849363 Change-Id: Ibd448d33b805404027d0862aaf65bd9ae758eb6b Reviewed-on: https://chromium-review.googlesource.com/1085868 Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/ba9d017c9e77b3e6bcd2bfa7dceeedc9f1de2414/telemetry/telemetry/story/story.py
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a112d180593885d9bfd08b41d53d050f123b3e3c commit a112d180593885d9bfd08b41d53d050f123b3e3c Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Jun 06 07:47:55 2018 Roll src/third_party/catapult 9861a71..ba9d017 (1 commits) https://chromium.googlesource.com/catapult.git/+log/9861a71..ba9d017 git log 9861a71..ba9d017 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 nednguyen@google.com Add deprecation message for grouping_keys Created with: gclient setdep -r src/third_party/catapult@ba9d017 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849363 TBR=sullivan@chromium.org Change-Id: I5f393ee53d460a1081b727dc6bfc276643f2a553 Reviewed-on: https://chromium-review.googlesource.com/1088252 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564819} [modify] https://crrev.com/a112d180593885d9bfd08b41d53d050f123b3e3c/DEPS
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/09b82f4a5ef5fd8f73b5ff5d3a3b3b5aeacfd51c commit 09b82f4a5ef5fd8f73b5ff5d3a3b3b5aeacfd51c Author: Ben Hayden <benjhayden@chromium.org> Date: Thu Jun 07 23:08:36 2018 Plumb story tags through Telemetry Values. Currently, grouping keys are plumbed through Telemetry Values, but not story tags. Both grouping keys and story tags are plumbed through Histograms. Grouping keys are being deprecated in favor of tags. Long term, Values will be deprecated in favor of Histograms, but they'll stick around for a while yet. This CL plumbs story tags through Telemetry Values for consistency. Bug: chromium:849363 Change-Id: Id942705ee1501d1adb1fdf6293b0218883f5d96a Reviewed-on: https://chromium-review.googlesource.com/1091168 Reviewed-by: Ethan Kuefner <eakuefner@chromium.org> Commit-Queue: Ben Hayden <benjhayden@chromium.org> [modify] https://crrev.com/09b82f4a5ef5fd8f73b5ff5d3a3b3b5aeacfd51c/tracing/tracing/value/chart_json_converter_test.html [modify] https://crrev.com/09b82f4a5ef5fd8f73b5ff5d3a3b3b5aeacfd51c/telemetry/telemetry/internal/results/chart_json_output_formatter.py [modify] https://crrev.com/09b82f4a5ef5fd8f73b5ff5d3a3b3b5aeacfd51c/tracing/tracing/value/chart_json_converter.html
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c150be89c3fe3f157822b7aaa9436116e9adca0 commit 0c150be89c3fe3f157822b7aaa9436116e9adca0 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 08 02:30:58 2018 Roll src/third_party/catapult 72a8685..09b82f4 (2 commits) https://chromium.googlesource.com/catapult.git/+log/72a8685..09b82f4 git log 72a8685..09b82f4 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 benjhayden@chromium.org Plumb story tags through Telemetry Values. 2018-06-07 sadrul@chromium.org tabs: Ignore the duration for the new metric. Created with: gclient setdep -r src/third_party/catapult@09b82f4 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849363, chromium:849182 TBR=sullivan@chromium.org Change-Id: I025e96839825a8303a7108a11c23604b7fa3f6c3 Reviewed-on: https://chromium-review.googlesource.com/1091931 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565515} [modify] https://crrev.com/0c150be89c3fe3f157822b7aaa9436116e9adca0/DEPS
,
Jun 8 2018
I have grouping_keys is being deprecated (crbug.com/849363). Please do not use this field all over test output. Can we remove that log line, at least until it's no longer printed 1592 times per single test? (e.g. https://chromium-swarm.appspot.com/task?id=3df86e34daf9a710&refresh=10&show_raw=1)
,
Jun 8 2018
Ooops. I will revert that log for now. Thanks for reporting, Nico!
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/ff225ad467cdb49811a3207f93d2f4870b7aef2f commit ff225ad467cdb49811a3207f93d2f4870b7aef2f Author: Ned Nguyen <nednguyen@google.com> Date: Fri Jun 08 14:54:11 2018 Revert "Add deprecation message for grouping_keys" This reverts commit ba9d017c9e77b3e6bcd2bfa7dceeedc9f1de2414. Reason for revert: too spammy (see https://bugs.chromium.org/p/chromium/issues/detail?id=849363#c7) Original change's description: > Add deprecation message for grouping_keys > > Bug: chromium:849363 > Change-Id: Ibd448d33b805404027d0862aaf65bd9ae758eb6b > Reviewed-on: https://chromium-review.googlesource.com/1085868 > Reviewed-by: Ben Hayden <benjhayden@chromium.org> > Commit-Queue: Ned Nguyen <nednguyen@google.com> TBR=benjhayden@chromium.org,eakuefner@chromium.org,nednguyen@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:849363 Change-Id: I96975e8849fd2c03b548a13fdbe866122065dee5 Reviewed-on: https://chromium-review.googlesource.com/1091482 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/ff225ad467cdb49811a3207f93d2f4870b7aef2f/telemetry/telemetry/story/story.py
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/707536bc8ca2b2a19084ad3a73374fd5d4556f17 commit 707536bc8ca2b2a19084ad3a73374fd5d4556f17 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 08 20:17:00 2018 Roll src/third_party/catapult c971895..eca23c3 (3 commits) https://chromium.googlesource.com/catapult.git/+log/c971895..eca23c3 git log c971895..eca23c3 --date=short --no-merges --format='%ad %ae %s' 2018-06-08 benjhayden@chromium.org Allow controlling dev dashboard version with environ variable. 2018-06-08 perezju@chromium.org [soundwave] Ensure API and DB are always initialized 2018-06-08 nednguyen@google.com Revert "Add deprecation message for grouping_keys" Created with: gclient setdep -r src/third_party/catapult@eca23c3 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849363 TBR=sullivan@chromium.org Change-Id: Id60e3bb0d986359efdd4252cce4f5ff9e583d839 Reviewed-on: https://chromium-review.googlesource.com/1093454 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565726} [modify] https://crrev.com/707536bc8ca2b2a19084ad3a73374fd5d4556f17/DEPS
,
Jun 14 2018
Turns out that this is very important to make sharding working properly. THe reason is we are merging the runtime of cold & warm run of the loading benchmarks (e.g: facebook-cold & facebook-warm are currently treated as one page)
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9df654dc594da6380ef48c11417ffec7866176cd commit 9df654dc594da6380ef48c11417ffec7866176cd Author: nednguyen <nednguyen@google.com> Date: Fri Jun 15 17:04:26 2018 Make sure page of different cache temperatures & traffic settings are named differently We will remove the grouping key feature in Telemetry, hence these stories need to be named differently (right now, they are named the same but have different grouping keys) Bug: 849363 Change-Id: I360aea0720c13383486fdb113ceda775c9a4f136 Reviewed-on: https://chromium-review.googlesource.com/1101542 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ben Hayden <benjhayden@chromium.org> Cr-Commit-Position: refs/heads/master@{#567698} [modify] https://crrev.com/9df654dc594da6380ef48c11417ffec7866176cd/tools/perf/expectations.config [modify] https://crrev.com/9df654dc594da6380ef48c11417ffec7866176cd/tools/perf/page_sets/data/loading_desktop.json [modify] https://crrev.com/9df654dc594da6380ef48c11417ffec7866176cd/tools/perf/page_sets/data/loading_mobile.json [modify] https://crrev.com/9df654dc594da6380ef48c11417ffec7866176cd/tools/perf/page_sets/data/v8_top_25.json [modify] https://crrev.com/9df654dc594da6380ef48c11417ffec7866176cd/tools/perf/page_sets/loading_desktop.py [modify] https://crrev.com/9df654dc594da6380ef48c11417ffec7866176cd/tools/perf/page_sets/loading_mobile.py [modify] https://crrev.com/9df654dc594da6380ef48c11417ffec7866176cd/tools/perf/page_sets/v8_top_25.py
,
Jun 15 2018
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1fd8fc95d73f0d2611a6fa295c85f969e127019 commit d1fd8fc95d73f0d2611a6fa295c85f969e127019 Author: nednguyen <nednguyen@google.com> Date: Tue Jun 19 15:44:10 2018 Make sure page of different cache temperatures & traffic settings are named differently (part 2) Bug: 849363 Change-Id: Ief8da1eda983c68c0db49f08cbca7d388c952741 Reviewed-on: https://chromium-review.googlesource.com/1102910 Reviewed-by: Ethan Kuefner <eakuefner@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#568466} [modify] https://crrev.com/d1fd8fc95d73f0d2611a6fa295c85f969e127019/tools/perf/contrib/cros_benchmarks/page_cycler_v2.py [modify] https://crrev.com/d1fd8fc95d73f0d2611a6fa295c85f969e127019/tools/perf/page_sets/data/intl_ar_fa_he.json [modify] https://crrev.com/d1fd8fc95d73f0d2611a6fa295c85f969e127019/tools/perf/page_sets/data/intl_es_fr_pt-BR.json [modify] https://crrev.com/d1fd8fc95d73f0d2611a6fa295c85f969e127019/tools/perf/page_sets/data/intl_hi_ru.json [modify] https://crrev.com/d1fd8fc95d73f0d2611a6fa295c85f969e127019/tools/perf/page_sets/data/intl_ja_zh.json [modify] https://crrev.com/d1fd8fc95d73f0d2611a6fa295c85f969e127019/tools/perf/page_sets/data/intl_ko_th_vi.json [modify] https://crrev.com/d1fd8fc95d73f0d2611a6fa295c85f969e127019/tools/perf/page_sets/data/typical_25.json [modify] https://crrev.com/d1fd8fc95d73f0d2611a6fa295c85f969e127019/tools/perf/page_sets/intl_ar_fa_he.py [modify] https://crrev.com/d1fd8fc95d73f0d2611a6fa295c85f969e127019/tools/perf/page_sets/intl_es_fr_pt-BR.py [modify] https://crrev.com/d1fd8fc95d73f0d2611a6fa295c85f969e127019/tools/perf/page_sets/intl_hi_ru.py [modify] https://crrev.com/d1fd8fc95d73f0d2611a6fa295c85f969e127019/tools/perf/page_sets/intl_ja_zh.py [modify] https://crrev.com/d1fd8fc95d73f0d2611a6fa295c85f969e127019/tools/perf/page_sets/intl_ko_th_vi.py [modify] https://crrev.com/d1fd8fc95d73f0d2611a6fa295c85f969e127019/tools/perf/page_sets/typical_25.py
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/f153b902bec3811dd5faa9e807240b059e7bbc8c commit f153b902bec3811dd5faa9e807240b059e7bbc8c Author: nednguyen <nednguyen@google.com> Date: Tue Jun 19 23:15:59 2018 Asserting that all story names are unique within a story set Bug: chromium:849363 Change-Id: Idfeec0e4f99d4b4e15b855047a2e90027521997d Reviewed-on: https://chromium-review.googlesource.com/1102560 Reviewed-by: Ethan Kuefner <eakuefner@chromium.org> Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/f153b902bec3811dd5faa9e807240b059e7bbc8c/telemetry/telemetry/story/story_set.py [modify] https://crrev.com/f153b902bec3811dd5faa9e807240b059e7bbc8c/telemetry/telemetry/story/story_set_unittest.py
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b87396b92ff208c3c3d2c3f1ab1f1b087ae4d71 commit 6b87396b92ff208c3c3d2c3f1ab1f1b087ae4d71 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Jun 20 01:37:50 2018 Roll src/third_party/catapult f704817cbbab..f153b902bec3 (1 commits) https://chromium.googlesource.com/catapult.git/+log/f704817cbbab..f153b902bec3 git log f704817cbbab..f153b902bec3 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 nednguyen@google.com Asserting that all story names are unique within a story set Created with: gclient setdep -r src/third_party/catapult@f153b902bec3 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849363 TBR=sullivan@chromium.org Change-Id: Ie0d420fb2e9671476f55565d8870da4d413a9379 Reviewed-on: https://chromium-review.googlesource.com/1107177 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568687} [modify] https://crrev.com/6b87396b92ff208c3c3d2c3f1ab1f1b087ae4d71/DEPS
,
Nov 12
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by nednguyen@chromium.org
, Jun 4 2018