Issue metadata
Sign in to add a comment
|
rebaseline-cl is broken |
||||||||||||||||||||||
Issue description
Alexis just reported this problem:
Stack trace:
Traceback (most recent call last):
File "third_party/blink/tools/blink_tool.py", line 83, in <module>
main()
File "third_party/blink/tools/blink_tool.py", line 78, in main
BlinkTool(os.path.abspath(__file__)).main()
File "/src/chromium/src/third_party/blink/tools/blinkpy/tool/blink_tool.py", line 107, in main
result = command.check_arguments_and_execute(options, args, self)
File "/src/chromium/src/third_party/blink/tools/blinkpy/tool/commands/command.py", line 110, in check_arguments_and_execute
return self.execute(options, args, tool) or 0
File "/src/chromium/src/third_party/blink/tools/blinkpy/tool/commands/rebaseline_cl.py", line 97, in execute
self.selected_try_bots, patchset=options.patchset)
File "/src/chromium/src/third_party/blink/tools/blinkpy/common/net/git_cl.py", line 186, in latest_try_jobs
patchset=patchset))
File "/src/chromium/src/third_party/blink/tools/blinkpy/common/net/git_cl.py", line 200, in try_job_results
raw_results = self.fetch_raw_try_job_results(patchset=patchset)
File "/src/chromium/src/third_party/blink/tools/blinkpy/common/net/git_cl.py", line 227, in fetch_raw_try_job_results
self.run(command)
File "/src/chromium/src/third_party/blink/tools/blinkpy/common/net/git_cl.py", line 60, in run
return self._host.executive.run_command(command, cwd=self._cwd)
File "/src/chromium/src/third_party/blink/tools/blinkpy/common/system/executive.py", line 337, in run_command
(error_handler or self.default_error_handler)(script_error)
File "/src/chromium/src/third_party/blink/tools/blinkpy/common/system/executive.py", line 244, in default_error_handler
raise error
blinkpy.common.system.executive.ScriptError: Failed to run "['git', 'cl', 'try-results', '--json', '/tmp/tmpiFCNSo/try-results.json']" exit_code: 1
Just running "git cl try-results" returns an error:
Buildbucket error: Buildbucket returns invalid json content: {}.
Please file bugs at http://crbug.com, label "Infra-BuildBucket".
,
Jun 4 2018
Assigning to myself for now since it's P1, to at least reproduce and get some idea of what might be wrong.
,
Jun 4 2018
I can reproduce the problem. `git cl try-results` is broken. I tried various flags but no more output than "Buildbucket error: Buildbucket returns invalid json content: {}".
,
Jun 4 2018
Thanks - also filed bug 849361 for that specifically. Note, git cl try-results does seem to work after there are try results.
,
Jun 4 2018
Re #4: not for me... Even with try results, `git cl try-results` still gives Buildbucket error to me.
,
Jun 4 2018
> #5: same error? for which CL and patchset?
,
Jun 4 2018
https://chromium-review.googlesource.com/c/chromium/src/+/1082319 And sorry, turns out the commit message was changed after triggering the try jobs. So if I run `git cl try-results --patchset=2`, everything works fine. Otherwise (on patchset 3, which doesn't have tryjobs associated), it's the same error (invalid json content {}).
,
Jun 4 2018
,
Jun 4 2018
please verify that this is fixed (this requires rolling depot_tools if it is pinned)
,
Jun 4 2018
,
Jun 4 2018
After rolling depot_tools via `gclient sync`, everything seems to be working again. Thanks, nodir@! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by qyears...@chromium.org
, Jun 4 2018