Add PhishGuard data to chrome://safe-browsing |
||
Issue descriptionTo aid in development, testing, and debugging PhishGuard code, we should add some of the following to chrome://safe-browsing: * Log of password-reuse events and logic, incl the phishguard ping * State of the captured password(s) Design doc: https://docs.google.com/document/d/16d-MT_WODjEilYLo55D66Z58fJKavxwVVNQmj3DMVTE/edit?hl=en#
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09702691ff395d4fab43c45f663a394b1fa34913 commit 09702691ff395d4fab43c45f663a394b1fa34913 Author: Daniel Rubery <drubery@chromium.org> Date: Tue Jun 19 18:54:09 2018 Initial implementation of PhishGuard event log. Add a PhishGuard event log to chrome://safe-browsing. Currently only logs when triggered by on focus or password reuse events. Will add further logged events in future CLs. Screenshot: http://screen/YPyPv8CbirO Bug: 849351 Change-Id: I7341b79685af1839584a165a7c1e3ee200947329 Reviewed-on: https://chromium-review.googlesource.com/1102665 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: vitaliii <vitaliii@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#568544} [modify] https://crrev.com/09702691ff395d4fab43c45f663a394b1fa34913/chrome/browser/safe_browsing/chrome_password_protection_service.cc [modify] https://crrev.com/09702691ff395d4fab43c45f663a394b1fa34913/components/safe_browsing/DEPS [modify] https://crrev.com/09702691ff395d4fab43c45f663a394b1fa34913/components/safe_browsing/password_protection/BUILD.gn [modify] https://crrev.com/09702691ff395d4fab43c45f663a394b1fa34913/components/safe_browsing/web_ui/BUILD.gn [modify] https://crrev.com/09702691ff395d4fab43c45f663a394b1fa34913/components/safe_browsing/web_ui/resources/safe_browsing.html [modify] https://crrev.com/09702691ff395d4fab43c45f663a394b1fa34913/components/safe_browsing/web_ui/resources/safe_browsing.js [modify] https://crrev.com/09702691ff395d4fab43c45f663a394b1fa34913/components/safe_browsing/web_ui/safe_browsing_ui.cc [modify] https://crrev.com/09702691ff395d4fab43c45f663a394b1fa34913/components/safe_browsing/web_ui/safe_browsing_ui.h
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f97129a31931c5522f7c8799311218f07647f88f commit f97129a31931c5522f7c8799311218f07647f88f Author: Daniel Rubery <drubery@chromium.org> Date: Fri Jun 22 17:16:31 2018 Add Lookup and DialogInteraction events to chrome://safe-browsing All events in the sync Event Log are now displayed in the chrome://safe-browsing PhishGuard event log. Render: https://screenshot.googleplex.com/N6UOBVpmx95 Bug: 849351 Change-Id: I49509231f6dcab76122eb6218b26d8bb6630a22b Reviewed-on: https://chromium-review.googlesource.com/1106966 Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#569673} [modify] https://crrev.com/f97129a31931c5522f7c8799311218f07647f88f/chrome/browser/safe_browsing/chrome_password_protection_service.cc [modify] https://crrev.com/f97129a31931c5522f7c8799311218f07647f88f/chrome/browser/safe_browsing/chrome_password_protection_service.h [modify] https://crrev.com/f97129a31931c5522f7c8799311218f07647f88f/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc [modify] https://crrev.com/f97129a31931c5522f7c8799311218f07647f88f/components/safe_browsing/web_ui/safe_browsing_ui.cc [modify] https://crrev.com/f97129a31931c5522f7c8799311218f07647f88f/components/safe_browsing/web_ui/safe_browsing_ui.h
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/738e8479635e046eb9d6ebb28f290e5bb9f5d68b commit 738e8479635e046eb9d6ebb28f290e5bb9f5d68b Author: Daniel Rubery <drubery@chromium.org> Date: Thu Jun 28 16:43:26 2018 Add state of saved password hashes to chrome://safe-browsing Render: https://screenshot.googleplex.com/nvBOZqHXENq Bug: 849351 Change-Id: I8004424ed05d0b424fd9918c0e36d49d954bcabc Reviewed-on: https://chromium-review.googlesource.com/1117443 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#571161} [modify] https://crrev.com/738e8479635e046eb9d6ebb28f290e5bb9f5d68b/components/safe_browsing/web_ui/BUILD.gn [modify] https://crrev.com/738e8479635e046eb9d6ebb28f290e5bb9f5d68b/components/safe_browsing/web_ui/DEPS [modify] https://crrev.com/738e8479635e046eb9d6ebb28f290e5bb9f5d68b/components/safe_browsing/web_ui/resources/safe_browsing.html [modify] https://crrev.com/738e8479635e046eb9d6ebb28f290e5bb9f5d68b/components/safe_browsing/web_ui/resources/safe_browsing.js [modify] https://crrev.com/738e8479635e046eb9d6ebb28f290e5bb9f5d68b/components/safe_browsing/web_ui/safe_browsing_ui.cc [modify] https://crrev.com/738e8479635e046eb9d6ebb28f290e5bb9f5d68b/components/safe_browsing/web_ui/safe_browsing_ui.h
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/955fcacb448221dc4e5abafd56ce796882d3f0d7 commit 955fcacb448221dc4e5abafd56ce796882d3f0d7 Author: Daniel Rubery <drubery@chromium.org> Date: Fri Jun 29 20:50:02 2018 Add PhishGuard pings and responses to chrome://safe-browsing. Rename "resued_password_type" to "reused_password_type". Render: https://screenshot.googleplex.com/rRa1W6cEQqr Bug: 849351 , 857503 Change-Id: I13a2724548ce317788b49eb48e7ec345b98385eb Reviewed-on: https://chromium-review.googlesource.com/1120872 Reviewed-by: Jialiu Lin <jialiul@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#571621} [modify] https://crrev.com/955fcacb448221dc4e5abafd56ce796882d3f0d7/components/safe_browsing/password_protection/password_protection_request.cc [modify] https://crrev.com/955fcacb448221dc4e5abafd56ce796882d3f0d7/components/safe_browsing/password_protection/password_protection_request.h [modify] https://crrev.com/955fcacb448221dc4e5abafd56ce796882d3f0d7/components/safe_browsing/proto/csd.proto [modify] https://crrev.com/955fcacb448221dc4e5abafd56ce796882d3f0d7/components/safe_browsing/web_ui/resources/safe_browsing.css [modify] https://crrev.com/955fcacb448221dc4e5abafd56ce796882d3f0d7/components/safe_browsing/web_ui/resources/safe_browsing.html [modify] https://crrev.com/955fcacb448221dc4e5abafd56ce796882d3f0d7/components/safe_browsing/web_ui/resources/safe_browsing.js [modify] https://crrev.com/955fcacb448221dc4e5abafd56ce796882d3f0d7/components/safe_browsing/web_ui/safe_browsing_ui.cc [modify] https://crrev.com/955fcacb448221dc4e5abafd56ce796882d3f0d7/components/safe_browsing/web_ui/safe_browsing_ui.h
,
Jun 29 2018
Seems hit some crash. Repro steps: start chromium, go to chrome://safe-browsing (signed-in as phishguard.test.001@gmail.com) [219721:219721:0629/144940.339347:WARNING:large_icon_service.cc(424)] large icon server fetch empty https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true&check_seen=true&size=96&min_size=16&max_size=256&fallback_opts=TYPE,SIZE,URL&url=http://testsafebrowsing.appspot.com/s/bad_login.html [219721:219721:0629/144940.348074:WARNING:large_icon_service.cc(424)] large icon server fetch empty https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true&check_seen=true&size=96&min_size=16&max_size=256&fallback_opts=TYPE,SIZE,URL&url=http://localhost:8000/ [1:1:0629/145003.867054:ERROR:render_process_impl.cc(209)] WebFrame LEAKED 3 TIMES [219721:219721:0629/145003.934101:FATAL:web_ui_impl.cc(269)] Check failed: false. Unhandled chrome.send("getPGPings"); #0 0x7fe3eea6d32d base::debug::StackTrace::StackTrace() #1 0x7fe3ee7aa36c base::debug::StackTrace::StackTrace() #2 0x7fe3ee8193aa logging::LogMessage::~LogMessage() #3 0x7fe3e8de833e content::WebUIImpl::ProcessWebUIMessage() #4 0x7fe3e8de56ba content::WebUIImpl::OnWebUISend() #5 0x7fe3e8de8f3e _ZN3IPC20DispatchToMethodImplIN7content9WebUIImplEMS2_FvPNS1_15RenderFrameHostERKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEERKN4base9ListValueEES3_NS5_5tupleIJSB_SF_EEEJLm0ELm1EEEEvPT_T0_PT1_OT2_NS5_16integer_sequenceImJXspT3_EEEE #6 0x7fe3e8de8e60 _ZN3IPC16DispatchToMethodIN7content9WebUIImplENS1_15RenderFrameHostEJRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEERKN4base9ListValueEENS4_5tupleIJSA_SE_EEEEENS4_9enable_ifIXeqsZT1_sr3std10tuple_sizeINS4_5decayIT2_E4typeEEE5valueEvE4typeEPT_MSQ_FvPT0_DpT1_EST_OSL_ #7 0x7fe3e8de8d0d _ZN3IPC8MessageTI27FrameHostMsg_WebUISend_MetaNSt3__15tupleIJNS2_12basic_stringIcNS2_11char_traitsIcEENS2_9allocatorIcEEEEN4base9ListValueEEEEvE8DispatchIN7content9WebUIImplESG_NSF_15RenderFrameHostEMSG_FvPSH_RKS9_RKSB_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ #8 0x7fe3e8de53dc content::WebUIImpl::OnMessageReceived() #9 0x7fe3e8d26fae content::WebContentsImpl::OnMessageReceived() #10 0x7fe3e83e456c content::RenderFrameHostImpl::OnMessageReceived() #11 0x7fe3e89da963 content::RenderProcessHostImpl::OnMessageReceived() #12 0x7fe3ec81b1f5 IPC::ChannelProxy::Context::OnDispatchMessage() #13 0x7fe3ec82134f _ZN4base8internal13FunctorTraitsIMN3IPC12ChannelProxy7ContextEFvRKNS2_7MessageEEvE6InvokeIS9_RK13scoped_refptrIS4_EJS7_EEEvT_OT0_DpOT1_ #14 0x7fe3ec8212af _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN3IPC12ChannelProxy7ContextEFvRKNS4_7MessageEEJRK13scoped_refptrIS6_ES9_EEEvOT_DpOT0_ #15 0x7fe3ec82123d _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE7RunImplIRKSA_RKNSt3__15tupleIJSC_S6_EEEJLm0ELm1EEEEvOT_OT0_NSJ_16integer_sequenceImJXspT1_EEEE #16 0x7fe3ec82114c _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE3RunEPNS0_13BindStateBaseE #17 0x7fe3ee75954e _ZNO4base12OnceCallbackIFvvEE3RunEv #18 0x7fe3ee7ab832 base::debug::TaskAnnotator::RunTask() #19 0x7fe3ee838a89 base::internal::IncomingTaskQueue::RunTask() #20 0x7fe3ee842877 base::MessageLoop::RunTask() #21 0x7fe3ee842ae8 base::MessageLoop::DeferOrRunPendingTask() #22 0x7fe3ee842e19 base::MessageLoop::DoWork() #23 0x7fe3ee846d86 base::MessagePumpGlib::Run() #24 0x7fe3ee84206b base::MessageLoop::Run() #25 0x7fe3ee8edc8d base::RunLoop::Run() #26 0x55c58445bb1f ChromeBrowserMainParts::MainMessageLoopRun() #27 0x7fe3e7f20b91 content::BrowserMainLoop::RunMainMessageLoopParts() #28 0x7fe3e7f28cc0 content::BrowserMainRunnerImpl::Run() #29 0x7fe3e7f13d79 content::BrowserMain() #30 0x7fe3e9db3b67 content::RunBrowserProcessMain() #31 0x7fe3e9db60e0 content::ContentMainRunnerImpl::Run() #32 0x7fe3e9daa7f5 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #33 0x7fe3eed0e21e service_manager::Main() #34 0x7fe3e9db0a55 content::ContentMain() #35 0x55c582740246 ChromeMain #36 0x55c582740152 main #37 0x7fe3caa262b1 __libc_start_main #38 0x55c58274002a _start Received signal 6 #0 0x7fe3eea6d32d base::debug::StackTrace::StackTrace() #1 0x7fe3ee7aa36c base::debug::StackTrace::StackTrace() #2 0x7fe3eea6cd84 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7fe3cec9a0c0 <unknown> #4 0x7fe3caa38fcf gsignal #5 0x7fe3caa3a3fa abort #6 0x7fe3eea6c506 base::debug::(anonymous namespace)::DebugBreak() #7 0x7fe3eea6c4e8 base::debug::BreakDebugger() #8 0x7fe3ee81a1a4 logging::LogMessage::~LogMessage() #9 0x7fe3e8de833e content::WebUIImpl::ProcessWebUIMessage() #10 0x7fe3e8de56ba content::WebUIImpl::OnWebUISend() #11 0x7fe3e8de8f3e _ZN3IPC20DispatchToMethodImplIN7content9WebUIImplEMS2_FvPNS1_15RenderFrameHostERKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEERKN4base9ListValueEES3_NS5_5tupleIJSB_SF_EEEJLm0ELm1EEEEvPT_T0_PT1_OT2_NS5_16integer_sequenceImJXspT3_EEEE #12 0x7fe3e8de8e60 _ZN3IPC16DispatchToMethodIN7content9WebUIImplENS1_15RenderFrameHostEJRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEERKN4base9ListValueEENS4_5tupleIJSA_SE_EEEEENS4_9enable_ifIXeqsZT1_sr3std10tuple_sizeINS4_5decayIT2_E4typeEEE5valueEvE4typeEPT_MSQ_FvPT0_DpT1_EST_OSL_ #13 0x7fe3e8de8d0d _ZN3IPC8MessageTI27FrameHostMsg_WebUISend_MetaNSt3__15tupleIJNS2_12basic_stringIcNS2_11char_traitsIcEENS2_9allocatorIcEEEEN4base9ListValueEEEEvE8DispatchIN7content9WebUIImplESG_NSF_15RenderFrameHostEMSG_FvPSH_RKS9_RKSB_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ #14 0x7fe3e8de53dc content::WebUIImpl::OnMessageReceived() #15 0x7fe3e8d26fae content::WebContentsImpl::OnMessageReceived() #16 0x7fe3e83e456c content::RenderFrameHostImpl::OnMessageReceived() #17 0x7fe3e89da963 content::RenderProcessHostImpl::OnMessageReceived() #18 0x7fe3ec81b1f5 IPC::ChannelProxy::Context::OnDispatchMessage() #19 0x7fe3ec82134f _ZN4base8internal13FunctorTraitsIMN3IPC12ChannelProxy7ContextEFvRKNS2_7MessageEEvE6InvokeIS9_RK13scoped_refptrIS4_EJS7_EEEvT_OT0_DpOT1_ #20 0x7fe3ec8212af _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN3IPC12ChannelProxy7ContextEFvRKNS4_7MessageEEJRK13scoped_refptrIS6_ES9_EEEvOT_DpOT0_ #21 0x7fe3ec82123d _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE7RunImplIRKSA_RKNSt3__15tupleIJSC_S6_EEEJLm0ELm1EEEEvOT_OT0_NSJ_16integer_sequenceImJXspT1_EEEE #22 0x7fe3ec82114c _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE3RunEPNS0_13BindStateBaseE #23 0x7fe3ee75954e _ZNO4base12OnceCallbackIFvvEE3RunEv #24 0x7fe3ee7ab832 base::debug::TaskAnnotator::RunTask() #25 0x7fe3ee838a89 base::internal::IncomingTaskQueue::RunTask() #26 0x7fe3ee842877 base::MessageLoop::RunTask() #27 0x7fe3ee842ae8 base::MessageLoop::DeferOrRunPendingTask() #28 0x7fe3ee842e19 base::MessageLoop::DoWork() #29 0x7fe3ee846d86 base::MessagePumpGlib::Run() #30 0x7fe3ee84206b base::MessageLoop::Run() #31 0x7fe3ee8edc8d base::RunLoop::Run() #32 0x55c58445bb1f ChromeBrowserMainParts::MainMessageLoopRun() #33 0x7fe3e7f20b91 content::BrowserMainLoop::RunMainMessageLoopParts() #34 0x7fe3e7f28cc0 content::BrowserMainRunnerImpl::Run() #35 0x7fe3e7f13d79 content::BrowserMain() #36 0x7fe3e9db3b67 content::RunBrowserProcessMain() #37 0x7fe3e9db60e0 content::ContentMainRunnerImpl::Run() #38 0x7fe3e9daa7f5 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #39 0x7fe3eed0e21e service_manager::Main() #40 0x7fe3e9db0a55 content::ContentMain() #41 0x55c582740246 ChromeMain #42 0x55c582740152 main #43 0x7fe3caa262b1 __libc_start_main #44 0x55c58274002a _start r8: 0000000000000000 r9: 00007ffe86e6f140 r10: 0000000000000008 r11: 0000000000000246 r12: 000055c582740000 r13: 00007ffe86e73d90 r14: 0000000000000000 r15: 0000000000000000 di: 0000000000000002 si: 00007ffe86e6f140 bp: 00007ffe86e6f380 bx: 0000000000000006 dx: 0000000000000000 ax: 0000000000000000 cx: 00007fe3caa38fcf sp: 00007ffe86e6f1b8 ip: 00007fe3caa38fcf efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace]
,
Jun 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a59824eae60fca7f3c5b8ba5052a36659a143b96 commit a59824eae60fca7f3c5b8ba5052a36659a143b96 Author: Daniel Rubery <drubery@chromium.org> Date: Sat Jun 30 00:32:16 2018 Add handler for getPGPings and getPGResponses. Missing these caused the crash. Bug: 849351 Change-Id: I38a156a708c544bf02fe50d5d67a3aec8e4ed4ac Reviewed-on: https://chromium-review.googlesource.com/1121253 Reviewed-by: Jialiu Lin <jialiul@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#571717} [modify] https://crrev.com/a59824eae60fca7f3c5b8ba5052a36659a143b96/components/safe_browsing/web_ui/safe_browsing_ui.cc
,
Jul 20
|
||
►
Sign in to add a comment |
||
Comment 1 by nparker@chromium.org
, Jun 8 2018Owner: drubery@chromium.org
Status: Assigned (was: Untriaged)