Issue metadata
Sign in to add a comment
|
11.5%-73.4% regression in blink_perf.canvas at 563277:563531 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 4 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11fd19f6240000
,
Jun 4 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/11fd19f6240000 GPU: Remove transfer buffer autoflushing. by jdarpinian@chromium.org https://chromium.googlesource.com/chromium/src/+/dcfaac01164977c0e9862880ba33ba6edb5639c2 391.2 → 351.8 (-39.4) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b63225bbef75dc91b78029ad8f8b1e516934b268 commit b63225bbef75dc91b78029ad8f8b1e516934b268 Author: James Darpinian <jdarpinian@chromium.org> Date: Wed Jun 06 19:45:58 2018 Revert "GPU: Remove transfer buffer autoflushing." This reverts commit dcfaac01164977c0e9862880ba33ba6edb5639c2. Reason for revert: Regressed canvas 2d performance in some MotionMark tests. Will redo as a WebGL-specific change. Original change's description: > GPU: Remove transfer buffer autoflushing. > > This is change #2 of 3 reducing context switching during WebGL > rendering. On tiled rendering GPUs context switches are slow and can > even cause multisampling artifacts. Every time the command buffer is > flushed, a context switch is possible. > > Before, the transfer buffer would flush the command buffer after an > arbitrary number of bytes were sent. This change removes that threshold. > Any performance benefit of early flushing is killed by the additional > context switching. > > Bug: 828363,835353 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I8f71668d4b976332820d290868282d41286ab4fe > Reviewed-on: https://chromium-review.googlesource.com/1077568 > Commit-Queue: James Darpinian <jdarpinian@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563404} TBR=piman@chromium.org,jdarpinian@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 828363, 835353, 849348 Change-Id: Iba27bae33f5395333f54db4bea4e79e41cca7e31 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1087370 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565006} [modify] https://crrev.com/b63225bbef75dc91b78029ad8f8b1e516934b268/gpu/command_buffer/client/implementation_base.cc [modify] https://crrev.com/b63225bbef75dc91b78029ad8f8b1e516934b268/gpu/command_buffer/client/implementation_base.h [modify] https://crrev.com/b63225bbef75dc91b78029ad8f8b1e516934b268/gpu/command_buffer/client/mock_transfer_buffer.cc [modify] https://crrev.com/b63225bbef75dc91b78029ad8f8b1e516934b268/gpu/command_buffer/client/mock_transfer_buffer.h [modify] https://crrev.com/b63225bbef75dc91b78029ad8f8b1e516934b268/gpu/command_buffer/client/transfer_buffer.cc [modify] https://crrev.com/b63225bbef75dc91b78029ad8f8b1e516934b268/gpu/command_buffer/client/transfer_buffer.h [modify] https://crrev.com/b63225bbef75dc91b78029ad8f8b1e516934b268/gpu/command_buffer/client/transfer_buffer_unittest.cc
,
Jun 6 2018
,
Jun 28 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11db8767240000
,
Jun 28 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/11db8767240000 GPU: Grow and shrink transfer buffer by jdarpinian@chromium.org https://chromium-review.googlesource.com/c/chromium/src/+/1105505/8 392.2 → 402.7 (+10.59) Understanding performance regressions: http://g.co/ChromePerformanceRegressions |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jun 4 2018