New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849337 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

experimental.startup.android.coldish not uploading histograms

Project Member Reported by eakuefner@chromium.org, Jun 4 2018

Issue description

From an email thread, experimental.startup.android.coldish, which appears to only be running on an N5X bot on chromium.perf.fyi, is not uploading histograms.

It's present in this list: https://cs.chromium.org/chromium/src/tools/perf/core/perf_data_generator.py?l=35&rcl=4470fb8729c584cc732bf73d6c68fe52cd680809

so I expect that it's been scheduled as a one-off.

We used to have chromium.perf.fyi.extras.json, but I can't find that in code search anymore. Emily, has the logic around scheduling one-offs changed?
 
the FYI file is currently being updated manually.  To update that benchmark you would need to change https://cs.chromium.org/chromium/src/testing/buildbot/chromium.perf.fyi.json?l=59 to histograms.
Status: Started (was: Assigned)
Thank you for the brisk response! I'll do that!
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73c072de3f8263c327379a0eae67adcbfdc5b8f5

commit 73c072de3f8263c327379a0eae67adcbfdc5b8f5
Author: Ethan Kuefner <eakuefner@chromium.org>
Date: Tue Jun 05 13:58:34 2018

[Perf] Move remaining FYI benchmarks to histograms

A few benchmarks were left uploading chart JSON because they have been
scheduled manually. This CL updates all such benchmarks in
chromium.perf.fyi.json.

Bug:  849337 
Change-Id: I174bcea46ad74922aef4509fc4490c598bb1cef1
Reviewed-on: https://chromium-review.googlesource.com/1085892
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564476}
[modify] https://crrev.com/73c072de3f8263c327379a0eae67adcbfdc5b8f5/testing/buildbot/chromium.perf.fyi.json

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb7c4560ca39360eeb681248378bb7099ff28a00

commit bb7c4560ca39360eeb681248378bb7099ff28a00
Author: Chong Zhang <chongz@chromium.org>
Date: Mon Jun 11 18:29:24 2018

[Perf] Move Mojo Linux Perf back to chartjson

I174bcea46ad74922aef4509fc4490c598bb1cef1 moved FYI bots to histograms,
however Mojo Linux Perf is not ready yet and fails consistently.

As discussed in I26cd027d4b59f6b927736a43f068bd0d89d279c8 we need the
bot for 2 quarters, and I will either remove or rewrite after that.

Bug:  849337 ,822484
Change-Id: Id2a7ca39ec210b5b16c1c218d701ff81d2f27390
Reviewed-on: https://chromium-review.googlesource.com/1092794
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566069}
[modify] https://crrev.com/bb7c4560ca39360eeb681248378bb7099ff28a00/testing/buildbot/chromium.perf.fyi.json

Sign in to add a comment