New issue
Advanced search Search tips

Issue 849335 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Need to hide audio only receivers from sink list when Desktop Casting mode is selected

Project Member Reported by dbbrooks@chromium.org, Jun 4 2018

Issue description

Chrome Version: 68.0.3440.7
OS: Win and CrOS. (Works on Mac)

What steps will reproduce the problem?
(1) Select Cast Desktop from cast mode picker.

What is the expected result? Audio only devices should not appear as cast targets when desktop casting is the selected mode. (Until bug 662499 is implemented)

What happens instead? Audio only devices are listed as cast targets, selecting them displays a failure to cast error msg.
 
Owner: imch...@chromium.org
Can you see whether this is already addressed with the latest patch?
Owner: dbbrooks@chromium.org
Status: Fixed (was: Untriaged)
Should be fixed with the extension patch. Assigning to David to verify.
Status: Verified (was: Fixed)
verified fixed in 69.0.3452.0
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/100cd03a432d551fa92bf066920b8a4a3f298bc0

commit 100cd03a432d551fa92bf066920b8a4a3f298bc0
Author: Derek Cheng <imcheng@chromium.org>
Date: Thu Aug 09 06:03:47 2018

[Cast MRP] Hide audio-only devices for desktop mirroring.

The same change was made to the MR extension to hide audio-only devices
for desktop mirroring proper support is implemented. ( bug 849335 )

Bug:  849335 
Change-Id: I969000c50ba6c07068298e2149f393e8737461f7
Reviewed-on: https://chromium-review.googlesource.com/1167657
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581805}
[modify] https://crrev.com/100cd03a432d551fa92bf066920b8a4a3f298bc0/chrome/common/media_router/providers/cast/cast_media_source.cc
[modify] https://crrev.com/100cd03a432d551fa92bf066920b8a4a3f298bc0/chrome/common/media_router/providers/cast/cast_media_source_unittest.cc

Sign in to add a comment