[MacViews] Context menu doesn't start selection from bottom on arrow-up |
||
Issue descriptionWhat steps will reproduce the problem? 1. ctrl-click somewhere to get a context menu 2. hit arrow-up a few times What is the expected result? The first hit highlights the last item in the context menu, the second hit the 2nd-to-last, etc. What happens instead of that? Nothing. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.48 Safari/537.36
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a1a4e8c10cbde265a189736d083427152e464c4 commit 5a1a4e8c10cbde265a189736d083427152e464c4 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Jun 07 12:14:48 2018 macviews: adjust menu arrow wrap behavior Hitting up-arrow on a fresh menu with no selection should select the bottom item. The easiest way to implement this is to simply not prevent wrapping when selecting the very first item. Bug: 849298 Change-Id: Ifcd037cf2da8281618312f105965eb3494ab15a4 Reviewed-on: https://chromium-review.googlesource.com/1089660 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#565236} [modify] https://crrev.com/5a1a4e8c10cbde265a189736d083427152e464c4/ui/views/controls/menu/menu_controller.cc [modify] https://crrev.com/5a1a4e8c10cbde265a189736d083427152e464c4/ui/views/controls/menu/menu_controller.h [modify] https://crrev.com/5a1a4e8c10cbde265a189736d083427152e464c4/ui/views/controls/menu/menu_controller_unittest.cc
,
Jun 7 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by tapted@chromium.org
, Jun 5 2018Components: Internals>Views
Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)