New issue
Advanced search Search tips

Issue 849291 link

Starred by 2 users
Status: Fixed
Owner:
zhuoyu.q...@samsung.com
Closed: Sep 25
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Create separate class for managing user typed and autofilled values in PasswordAutofillAgent

Project Member Reported by dvadym@chromium.org, Jun 4 2018 
FieldValueAndPropertiesMaskMap (which is equal to std::map<
    uint32_t,
    std::pair<std::unique_ptr<base::string16>, FieldPropertiesMask>> ) is used for keeping different information related to input elements in PasswordAutofillAgent. It's started as simple map: Input->Typed value and became much more complicated with non-trivial logic. It would be good to move all that logic to a separate class with interface like that

class FieldDataManager {
 void SetUserTypedValue(id, value);
 string GetUserTypedValue(id, value);

 Get/SetFieldProperties
 etc

};

Comment 1 by dvadym@chromium.org, Jun 4 2018

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 2 by vabr@chromium.org, Jun 7 2018

Labels: Hotlist-TechnicalDebt Hotlist-Refactoring

Comment 3 by vabr@chromium.org, Jul 6 

Heads-up that there is a CL in progress for this: https://crrev.com/c/1126889
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3eb3b6abfcf489dafaab89d0f93595e0209c53fc

commit 3eb3b6abfcf489dafaab89d0f93595e0209c53fc
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Fri Aug 17 16:04:39 2018

Introduce FieldDataManager to replace FieldValueAndPropertiesMaskMap.

Create separate class FieldDataManager for managing user typed and
autofilled values in PasswordAutofillAgent to replace
FieldValueAndPropertiesMaskMap.

Bug:  849291 

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I42e4ab99254f1551209a3c4452d5b769efd794af
Reviewed-on: https://chromium-review.googlesource.com/1126889
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584091}
[modify] https://crrev.com/3eb3b6abfcf489dafaab89d0f93595e0209c53fc/components/BUILD.gn
[modify] https://crrev.com/3eb3b6abfcf489dafaab89d0f93595e0209c53fc/components/autofill/content/renderer/BUILD.gn
[add] https://crrev.com/3eb3b6abfcf489dafaab89d0f93595e0209c53fc/components/autofill/content/renderer/field_data_manager.cc
[add] https://crrev.com/3eb3b6abfcf489dafaab89d0f93595e0209c53fc/components/autofill/content/renderer/field_data_manager.h
[add] https://crrev.com/3eb3b6abfcf489dafaab89d0f93595e0209c53fc/components/autofill/content/renderer/field_data_manager_browsertest.cc
[modify] https://crrev.com/3eb3b6abfcf489dafaab89d0f93595e0209c53fc/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/3eb3b6abfcf489dafaab89d0f93595e0209c53fc/components/autofill/content/renderer/form_autofill_util.h
[modify] https://crrev.com/3eb3b6abfcf489dafaab89d0f93595e0209c53fc/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/3eb3b6abfcf489dafaab89d0f93595e0209c53fc/components/autofill/content/renderer/password_autofill_agent.h
[modify] https://crrev.com/3eb3b6abfcf489dafaab89d0f93595e0209c53fc/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/3eb3b6abfcf489dafaab89d0f93595e0209c53fc/components/autofill/content/renderer/password_form_conversion_utils.h
[modify] https://crrev.com/3eb3b6abfcf489dafaab89d0f93595e0209c53fc/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/3eb3b6abfcf489dafaab89d0f93595e0209c53fc/components/autofill/content/renderer/password_generation_agent.cc

Comment 5 by zhuoyu.q...@samsung.com, Sep 25

Owner: zhuoyu.q...@samsung.com
Status: Fixed (was: Available)
►

Sign in to add a comment