New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849287 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Two copy of trace_data module in catapult

Project Member Reported by nednguyen@chromium.org, Jun 4 2018

Issue description

Egor happens to find that we have two different copies of a same module in catapult. They are:
telemetry/timeline/trace_data.py 
tracing/trace_data/trace_data.py

Looking closely, it seems to me that tracing/trace_data/trace_data.py is supposed to be the source of truth (https://codereview.chromium.org/2725913002). 

It seems we did the copy but failed to finished the code migration from telemetry/.. to tracing/...

I will finish the rest by removing telemetry/timeline/trace_data.py 

 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a57d5cd0d0b48da2e8732b43bfb70123a336dada

commit a57d5cd0d0b48da2e8732b43bfb70123a336dada
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Jun 04 21:30:13 2018

Roll src/third_party/catapult 0ddb3a1..bf32270 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/0ddb3a1..bf32270


git log 0ddb3a1..bf32270 --date=short --no-merges --format='%ad %ae %s'
2018-06-04 nednguyen@google.com Clean up telemetry/timeline/trace_data*


Created with:
  gclient setdep -r src/third_party/catapult@bf32270

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:849287 
TBR=sullivan@chromium.org

Change-Id: Idc220fb49789e80557fc3216dffcbb564bd4ac86
Reviewed-on: https://chromium-review.googlesource.com/1086004
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564245}
[modify] https://crrev.com/a57d5cd0d0b48da2e8732b43bfb70123a336dada/DEPS

Status: Fixed (was: Assigned)

Comment 4 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 5 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment