New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849284 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit 28 days ago
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

"http/tests/devtools/editor/text-editor-ctrl-d-2.js" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 4 2018

Issue description

"http/tests/devtools/editor/text-editor-ctrl-d-2.js" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJodHRwL3Rlc3RzL2RldnRvb2xzL2VkaXRvci90ZXh0LWVkaXRvci1jdHJsLWQtMi5qcww.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Cc: yoichio@chromium.org lushnikov@chromium.org xiaoche...@chromium.org
Owner: yosin@chromium.org
Status: Assigned (was: Untriaged)
The test hasn't been touched for a while. First failure was seen in the following patch and seems to be editing related:
https://chromium-review.googlesource.com/c/chromium/src/+/1075918/11

yosin@ Can you take a look if it's related? Thanks!

Also CCing reviewers and the test owner.

Going to disable the test.
Might related to issue 846997.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3189b179957a41ada5d43d2da56b1c25e400403a

commit 3189b179957a41ada5d43d2da56b1c25e400403a
Author: Chong Zhang <chongz@chromium.org>
Date: Mon Jun 04 18:30:13 2018

Disable http/tests/devtools/editor/text-editor-ctrl-d-2.js on Mac

TBR=yosin@chromium.org,yutak@chromium.org

Bug:  849284 
Change-Id: I8101ce80403da2e8fb7cfa7f20ccf9f0ef6f301e
Reviewed-on: https://chromium-review.googlesource.com/1085551
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564158}
[modify] https://crrev.com/3189b179957a41ada5d43d2da56b1c25e400403a/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium Test-Disabled
Labels: OS-Mac

Comment 6 by yosin@chromium.org, Jun 13 2018

Components: -Tests>Flaky Platform>DevTools
Owner: ----
Status: Untriaged (was: Assigned)
Route to DevTools since Blink editing code isn't related.

Comment 7 by l...@chromium.org, Jun 13 2018

Cc: -lushnikov@chromium.org
Owner: lushnikov@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa8b12920e8c2042e47816d004b113c155e81aee

commit fa8b12920e8c2042e47816d004b113c155e81aee
Author: Alexis Hetu <sugoi@google.com>
Date: Fri Jul 06 14:14:32 2018

Attempt to unmark some tests as slow/timeout

Now that SwiftShader is on Linux/Windows/MacOS and that a recent
performance improvement has been landed in SwiftShader, verify
which tests still require the Slow/Timeout markers and which don't.

TBR=kbr@chromium.org

Bug:chromium:24182  chromium:433711  chromium:763197  chromium:311482   chromium:243871   chromium:664857   chromium:9798   chromium:237270   chromium:241576   chromium:241869   chromium:246749   chromium:535478   chromium:363029   chromium:364225   chromium:552556   chromium:570656   chromium:584807  chromium:614910  chromium:791659   chromium:726075   chromium:808153  chromium:816045  chromium:693568  chromium:626703 chromium:703533 chromium:786641  chromium:799137   chromium:831686   chromium:831230  chromium:818324  chromium:810437   chromium:847205  chromium:848799  chromium:828962   chromium:849284   chromium:855055 

Change-Id: I5d36d20bd87b234fefe4da3ea7e4af039c0188cb
Reviewed-on: https://chromium-review.googlesource.com/1102341
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572962}
[modify] https://crrev.com/fa8b12920e8c2042e47816d004b113c155e81aee/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/fa8b12920e8c2042e47816d004b113c155e81aee/third_party/WebKit/LayoutTests/TestExpectations

Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "http/tests/devtools/editor/text-editor-ctrl-d-2.js". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJodHRwL3Rlc3RzL2RldnRvb2xzL2VkaXRvci90ZXh0LWVkaXRvci1jdHJsLWQtMi5qcww. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
https://chromium-review.googlesource.com/c/chromium/src/+/1131174 is out for review to re-disable this test on Mac. When it lands, we can remove "Sheriff-Chromium".
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8961f23250494ef80e7ffecec601c79cc3d60ed

commit d8961f23250494ef80e7ffecec601c79cc3d60ed
Author: Colin Blundell <blundell@chromium.org>
Date: Tue Jul 10 12:59:24 2018

Disable http/tests/devtools/editor/text-editor-ctrl-d-2.js on Mac

https://chromium-review.googlesource.com/c/chromium/src/+/1102341
speculatively removed a whole bunch of test expectations including this
one; this one at least is still needed.

TBR=yosin@chromium.org,yutak@chromium.org

Bug:  849284 
Change-Id: I5bbd6c007e903c1bfc76e0c402e722af0a2ffb2f
Reviewed-on: https://chromium-review.googlesource.com/1131174
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573698}
[modify] https://crrev.com/d8961f23250494ef80e7ffecec601c79cc3d60ed/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Status: Archived (was: Assigned)
Test failures are processed as a part of a dedicated triage, bulk-closing the bugs.

Sign in to add a comment